Skip to contentSkip to conversation

OMAP: DMA: Attribution necessary only if the ch is not chained.

PATCH In review Carlos Aguiar 2 participants 2 messages Nov 24, 2007 – Nov 28, 2007

Subsystems (2)
Arm (32-bit) Arm sub-architectures
lore
Share & tools
lore

Carlos Aguiar

author
#0 lore raw

PATCH 1/1 OMAP: DMA: Attribution necessary only if the ch is not chained.

From: Carlos Eduardo Aguiar <[email protected]>

Attribution necessary only if the ch is not chained on arch/arm/plat-omap/dma.c

Signed-off-by Carlos Eduardo Aguiar <[email protected]>
Signed-off-by Ragner Magalhaes <[email protected]>
---
 arch/arm/plat-omap/dma.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/plat-omap/dma.c +2 -2
index dd0c874..a3c5d4f 100644
@@ -1709,9 +1709,9 @@ static int omap2_dma_handle_ch(int ch)
 
 		if (!OMAP_DMA_CHAIN_QEMPTY(chain_id))
 			OMAP_DMA_CHAIN_INCQHEAD(chain_id);
-	}
 
-	status = OMAP_DMA_CSR_REG(ch);
+		status = OMAP_DMA_CSR_REG(ch);
+	}
 
 	if (likely(dma_chan[ch].callback != NULL)) {
 		if (dma_chan[ch].chain_id != -1)

-- 1.5.3.GIT

#1 lore raw
Quoted 16 lines · Carlos Aguiar

From: Carlos Eduardo Aguiar <[email protected]>

Attribution necessary only if the ch is not chained on arch/arm/plat-omap/dma.c

Signed-off-by Carlos Eduardo Aguiar <[email protected]>
Signed-off-by Ragner Magalhaes <[email protected]>
---
 arch/arm/plat-omap/dma.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/plat-omap/dma.c +0 -0
index dd0c874..a3c5d4f 100644
@@ -1709,9 +1709,9 @@ static int omap2_dma_handle_ch(int ch)

arch/arm/plat-omap/dma.c static int omap2_dma_handle_ch(int ch) · line 1717

Quoted 10 lines
arch/arm/plat-omap/dma.c +2 -2
 		if (!OMAP_DMA_CHAIN_QEMPTY(chain_id))
 			OMAP_DMA_CHAIN_INCQHEAD(chain_id);
-	}
 
-	status = OMAP_DMA_CSR_REG(ch);
+		status = OMAP_DMA_CSR_REG(ch);
+	}
 
 	if (likely(dma_chan[ch].callback != NULL)) {
 		if (dma_chan[ch].chain_id != -1)

Thanks, pushed.

Tony