Skip to contentSkip to conversation

reiserfsprogs: remove fsck_sleep

PATCH New Jeff Mahoney 1 participant 1 message Nov 26, 2007

lore
Share & tools
lore

Jeff Mahoney

author
#0 lore raw

PATCH 1/1 reiserfsprogs: remove fsck_sleep

fsck_sleep causes the file descriptors to be kept open during mount. Multipath/kpartx doesn't like that.

Realistically, this optimization has always been suspect. It's useless now that we don't load all the bitmaps on mount.

The previous patch for better fsck -a behavior depends on this one for context.

Signed-off-by Jeff Mahoney <[email protected]>
---
 utils/fsck/main.c |   17 -----------------
 1 file changed, 17 deletions(-)
utils/fsck/main.c +0 -17
@@ -953,21 +953,6 @@ static void clean_attributes (reiserfs_f
 
 }
 
-/* Do not allow buffers to be flushed after finishing to avoid another bitmap 
- * reading on mounting. */
-static void fsck_sleep() {
-    int res;
-    
-    res = fork();
-    
-    if (res == -1) {
-	reiserfs_panic ("reiserfsck: Fork failed: %s", strerror(errno));
-    } else if (res == 0) {
-	/* Make the child process to sleep for 5 secs. */
-	sleep(5);
-    }
-}
-
 static int auto_check (reiserfs_filsys_t *fs) {
     __u16 state;
     int retval = 0;

@@ -1034,8 +1019,6 @@ static int auto_check (reiserfs_filsys_t
     
     util_device_dma_fini(fs->fs_dev, &dma_info);
     
-    fsck_sleep();
-    
     reiserfs_fs_close (fs);
     /* do not do anything else. */    
     exit (EXIT_OK);
Signature · 2 lines
Jeff Mahoney
SUSE Labs