: Complement va_start() with va_end().

Complement va_start() with va_end().

---
Compile-tested on i386 with allyesconfig and allmodconfig.

index ad02329..996b494 100644
@@ -187,12 +187,14 @@ static int i2c_senddata(struct saa5246a_device *t, ...)
 {
 	unsigned char buf[64];
 	int v;
-	int ct=0;
+	int ct = 0;
 	va_list argp;
-	va_start(argp,t);
+	va_start(argp, t);
 
-	while((v=va_arg(argp,int))!=-1)
-		buf[ct++]=v;
+	while ((v = va_arg(argp, int)) != -1)
+		buf[ct++] = v;
+
+	va_end(argp);
 	return i2c_sendbuf(t, buf[0], ct-1, buf+1);
 }
 

index 94bb59a..da5ca30 100644
@@ -282,12 +282,14 @@ static int i2c_senddata(struct saa5249_device *t, ...)
 {
 	unsigned char buf[64];
 	int v;
-	int ct=0;
+	int ct = 0;
 	va_list argp;
 	va_start(argp,t);
 
-	while((v=va_arg(argp,int))!=-1)
-		buf[ct++]=v;
+	while ((v = va_arg(argp, int)) != -1)
+		buf[ct++] = v;
+
+	va_end(argp);
 	return i2c_sendbuf(t, buf[0], ct-1, buf+1);
 }
 

Complement va_start() with va_end() + minor style fixes in the same function.

---
Compile-tested on i386 with allyesconfig and allmodconfig. Thanks to WANG Cong for pointing out the missing 'style fix'-description.

saa5246a.c | 10 ++++++----
saa5249.c | 8 +++++---

2 files changed, 11 insertions(+), 7 deletions(-)

index ad02329..996b494 100644
@@ -187,12 +187,14 @@ static int i2c_senddata(struct saa5246a_device *t, ...)

{
	unsigned char buf[64];
	int v;
-	int ct=0;
+	int ct = 0;
	va_list argp;

- va_start(argp,t);
+ va_start(argp, t);

- while((v=va_arg(argp,int))!=-1)
- buf[ct++]=v;
+ while ((v = va_arg(argp, int)) != -1)
+ buf[ct++] = v;
+

+	va_end(argp);
	return i2c_sendbuf(t, buf[0], ct-1, buf+1);
}

index 94bb59a..da5ca30 100644
@@ -282,12 +282,14 @@ static int i2c_senddata(struct saa5249_device *t, ...)

{
	unsigned char buf[64];
	int v;
-	int ct=0;
+	int ct = 0;
	va_list argp;
	va_start(argp,t);

- while((v=va_arg(argp,int))!=-1)
- buf[ct++]=v;
+ while ((v = va_arg(argp, int)) != -1)
+ buf[ct++] = v;
+

+	va_end(argp);
	return i2c_sendbuf(t, buf[0], ct-1, buf+1);
}

Please ignore the previous patch. Have resent it, but since my mail-client (Thunderbird) seem to be having a bad day, I had to use 'sendpatchset' and it can't continue on a thread.

Richard Knutsson