Remove unneeded ifdefs from sysctl_net_core.c
Subsystems (2)
PATCH 1/6 Remove unneeded ifdefs from sysctl_net_core.c
They include the whole file, but it is already compiled out when SYSCTL=n, since it is obj-$(CONFIG_SYSCTL) target in the Makefile.
---
net/core/sysctl_net_core.c +0 -4
@@ -13,8 +13,6 @@#include <net/sock.h> #include <net/xfrm.h> -#ifdef CONFIG_SYSCTL - ctl_table core_table[] = { #ifdef CONFIG_NET {
@@ -151,5 +149,3 @@ ctl_table core_table[] = { }, { .ctl_name = 0 } }; - -#endif
Signature · 1 line
1.5.3.4
Quoted 3 lines · Pavel Emelyanov
They include the whole file, but it is already compiled out when SYSCTL=n, since it is obj-$(CONFIG_SYSCTL) target in the
Makefile.
Pavel thanks for sending these patches. Might I ask for some level of acknowledgement when you rework one of my patches and send it off.
I suppose this could be a case of duplicate thinking but this patch looks very familiar.
Eric
Quoted 30 lines
Signed-off-by Pavel Emelyanov <[email protected]>---
net/core/sysctl_net_core.c +0
-4@@ -13,8 +13,6 @@#include <net/sock.h> #include <net/xfrm.h> -#ifdef CONFIG_SYSCTL - ctl_table core_table[] = { #ifdef CONFIG_NET {@@ -151,5 +149,3 @@ ctl_table core_table[] = { }, { .ctl_name = 0 } }; - -#endif Signature · 6 lines
1.5.3.4 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 9 lines · Eric W. Biederman
Quoted 3 lines · Pavel Emelyanov
They include the whole file, but it is already compiled out when SYSCTL=n, since it is obj-$(CONFIG_SYSCTL) target in the
Makefile.Pavel thanks for sending these patches. Might I ask for some level of acknowledgement when you rework one of my patches and send it off.
Sure. I though I've been doing exactly this thing. I've said that unix ctls were from your tree and so on.
Quoted 2 lines
I suppose this could be a case of duplicate thinking but this patch looks very familiar.
Hm... Do you mean that this one is from your tree? Sorry then, I didn't know this. I can resend it with From: <you> if you wish.
Quoted 1 line
Eric
Thanks,
Pavel
Quoted 31 lines
Quoted 30 lines
Signed-off-by Pavel Emelyanov <[email protected]>---
net/core/sysctl_net_core.c +0
-4@@ -13,8 +13,6 @@#include <net/sock.h> #include <net/xfrm.h> -#ifdef CONFIG_SYSCTL - ctl_table core_table[] = { #ifdef CONFIG_NET {@@ -151,5 +149,3 @@ ctl_table core_table[] = { }, { .ctl_name = 0 } }; - -#endif Signature · 6 lines
1.5.3.4 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 7 lines · Pavel Emelyanov
Quoted 6 lines · Eric W. Biederman
Quoted 3 lines · Pavel Emelyanov
They include the whole file, but it is already compiled out when SYSCTL=n, since it is obj-$(CONFIG_SYSCTL) target in the
Makefile.
Quoted 6 lines
Quoted 3 lines
Pavel thanks for sending these patches. Might I ask for some level of acknowledgement when you rework one of my patches and send it off.
Sure. I though I've been doing exactly this thing. I've said that unix ctls were from your tree and so on.
Ok. I guess I must have overlooked that attribution.
Quoted 5 lines
Quoted 2 lines
I suppose this could be a case of duplicate thinking but this patch looks very familiar.
Hm... Do you mean that this one is from your tree? Sorry then, I didn't know this. I can resend it with From: <you> if you wish.
It is. But I don't see any of this as needing a resend. Please just don't forget me in the future is all I ask.
Eric