Enabling MSI in sata_nv
Hi all,
At least for my hardware (MCP55), the sata controller supports MSI and it seems that turning it on is as simple as inserting the call to pci_enable_msi - after that it Just Works(tm).
Are there any gotchas that I'm missing? Would a patch to do this be accepted?
--phil
Quoted 8 lines · Philip Langdale
Hi all,
At least for my hardware (MCP55), the sata controller supports MSI and it seems that turning it on is as simple as inserting the call to
pci_enable_msi- after that it Just Works(tm).Are there any gotchas that I'm missing? Would a patch to do this be accepted?
..
Don't even dream about it for now. The driver is unstable enough without throwing MSI into the works.
Maybe in the new year, once we get it more up to spec.
Cheers
Quoted 7 lines · Mark Lord
Quoted 6 lines · Philip Langdale
Hi all,
At least for my hardware (MCP55), the sata controller supports MSI and it seems that turning it on is as simple as inserting the call to
pci_enable_msi- after that it Just Works(tm).
Quoted 6 lines
Quoted 2 lines
Are there any gotchas that I'm missing? Would a patch to do this be accepted?
..
Don't even dream about it for now. The driver is unstable enough without throwing MSI into the works.
..
Oh, wait a minute.. I misread "sata_nv" as "sata_mv" there.
No comment on "sata_nv".
(we really oughta rename one of those two..)
Quoted 10 lines · Mark Lord
Quoted 9 lines · Mark Lord
Quoted 8 lines · Philip Langdale
Hi all,
At least for my hardware (MCP55), the sata controller supports MSI and it seems that turning it on is as simple as inserting the call to
pci_enable_msi- after that it Just Works(tm).Are there any gotchas that I'm missing? Would a patch to do this be accepted?
Quoted 7 lines
Quoted 4 lines
..
Don't even dream about it for now. The driver is unstable enough without throwing MSI into the works.
..
Oh, wait a minute.. I misread "
sata_nv" as "sata_mv" there.
FWIW: Marvell says they run with MSI enabled on 6440 (mvsas) in their vendor driver, but not on any of the 50xx and 60xx variants supported by sata_mv.
Maybe that's changed in the past year with 7042, I dunno. But that's the latest info I have.
Jeff
Quoted 10 lines · Philip Langdale
Hi all,
At least for my hardware (MCP55), the sata controller supports MSI and it seems that turning it on is as simple as inserting the call to
pci_enable_msi- after that it Just Works(tm).Are there any gotchas that I'm missing? Would a patch to do this be accepted?
--phil
I don't know if it is relevant, but I had to disable MSI to get a MCP55 NIC to work under 2.6.22.
See https://bugzilla.novell.com/show_bug.cgi?id=287017#c1 for details if your curious.
Greg
Signature · 9 lines
Greg Freemyer Litigation Triage Solutions Specialist http://www.linkedin.com/in/gregfreemyer First 99 Days Litigation White Paper - http://www.norcrossgroup.com/forms/whitepapers/99%20Days%20whitepaper.pdf The Norcross Group The Intersection of Evidence & Technology http://www.norcrossgroup.com
Quoted 7 lines · Greg Freemyer
Quoted 6 lines · Philip Langdale
Hi all,
At least for my hardware (MCP55), the sata controller supports MSI and it seems that turning it on is as simple as inserting the call to
pci_enable_msi- after that it Just Works(tm).
Quoted 7 lines
Quoted 4 lines
Are there any gotchas that I'm missing? Would a patch to do this be accepted?
--phil
I don't know if it is relevant, but I had to disable MSI to get a MCP55 NIC to work under 2.6.22.
MSI is pretty flaky, but we default it to 'on' for AHCI, which is the "enhanced mode" side of the sata_nv chip.
So it is likely that it works on newer boards -- but even though Mark Lord's response was mistaken (he thought sata_mv was being discussed), he was right too... sata_nv has stability problems and I would prefer not to enable MSI just yet, until we cure the other problems.
Jeff
Quoted 3 lines · Jeff Garzik
MSI is pretty flaky, but we default it to 'on' for AHCI, which is the "enhanced mode" side of the
sata_nvchip.
If it's new enough. MCP55 has no ahci mode.
Quoted 4 lines
So it is likely that it works on newer boards -- but even though Mark Lord's response was mistaken (he thought
sata_mvwas being discussed), he was right too...sata_nvhas stability problems and I would prefer not to enable MSI just yet, until we cure the other problems.
Fair enough. Well, just chalk me down as a data point where it seems to be working.
--phil