Skip to contentSkip to conversation

BRIDGE : br_fdb_fini() should be __exit_refok instead of __exit

PATCH In review Eric Dumazet 3 participants 3 messages Dec 5, 2007

Subsystems (3)
Networking Network drivers Ethernet bridge
lore
Share & tools
lore

Eric Dumazet

author
#0 lore raw

PATCH 1/1 BRIDGE : br_fdb_fini() should be __exit_refok instead of __exit

Hi David

Building last net-2.6.25 git tree gave me this warning :

WARNING: vmlinux.o(.init.text+0x2a957): Section mismatch: reference to .exit.text:br_fdb_fini (between 'br_init' and 'br_fdb_init')

This is because br_init() (marked __init) can call br_fdb_fini() (marked __exit).

I am not sure the following is the right fix, since __exit_refok is quite new, and seldom used.

[PATCH] BRIDGE : br_fdb_fini() should be __exit_refok instead of __exit

Signed-off-by Eric Dumazet <[email protected]>
net/bridge/br_fdb.c +1 -1
index eb57502..6caeba5 100644
@@ -44,7 +44,7 @@ int __init br_fdb_init(void)
 	return 0;
 }
 
-void __exit br_fdb_fini(void)
+void __exit_refok br_fdb_fini(void)
 {
 	kmem_cache_destroy(br_fdb_cache);
 }
#1 lore raw
Quoted 7 lines · On Wed, 05 Dec 2007 13:41:24 +0100 Eric Dumazet <[email protected]> wrote:

Hi David

Building last net-2.6.25 git tree gave me this warning :

WARNING: vmlinux.o(.init.text+0x2a957): Section mismatch: reference to .exit.text:br_fdb_fini (between 'br_init' and 'br_fdb_init')

Quoted 9 lines

This is because br_init() (marked __init) can call br_fdb_fini() (marked __exit).

I am not sure the following is the right fix, since __exit_refok is quite new, and seldom used.

[PATCH] BRIDGE : br_fdb_fini() should be __exit_refok instead of __exit

Signed-off-by Eric Dumazet <[email protected]>

Andrew put a patch in his tree to just take off the __exit. That seems like the easiest fix for a one line function.

maintainer
#2 lore raw
In reply to Eric Dumazet

From: Eric Dumazet <[email protected]>
Date: Wed, 05 Dec 2007 13:41:24 +0100

Quoted 5 lines

Building last net-2.6.25 git tree gave me this warning :

WARNING: vmlinux.o(.init.text+0x2a957): Section mismatch: reference to .exit.text:br_fdb_fini (between 'br_init' and 'br_fdb_init')

Quoted 8 lines

This is because br_init() (marked __init) can call br_fdb_fini() (marked __exit).

I am not sure the following is the right fix, since __exit_refok is quite new, and seldom used.

[PATCH] BRIDGE : br_fdb_fini() should be __exit_refok instead of __exit

Signed-off-by Eric Dumazet <[email protected]>

I have another patch like this from Andrew's -mm queue sitting in my inbox, which I'll review and apply.

Thanks!