reiserfs: Add mount counting

PATCH In review Jeff Mahoney 4 participants 16 messages Nov 26, 2007 – Jan 24, 2008

Share & tools

Jeff Mahoney

author

2007-11-26 22:42 UTC #0 lore raw

PATCH 2/2 reiserfs: Add mount counting

The following patch adds the fields for tracking mount counts and last fsck timestamps to the superblock. It also increments the mount count on every read-write mount.

Signed-off-by Jeff Mahoney <[email protected]>

---

 fs/reiserfs/super.c            |    6 +++++-
 include/linux/reiserfs_fs.h    |    6 +++++-
 include/linux/reiserfs_fs_sb.h |    3 +++
 3 files changed, 13 insertions(+), 2 deletions(-)

fs/reiserfs/super.c +5 -1

@@ -1239,6 +1239,8 @@ static int reiserfs_remount(struct super
 		REISERFS_SB(s)->s_mount_state = sb_umount_state(rs);
 		s->s_flags &= ~MS_RDONLY;
 		set_sb_umount_state(rs, REISERFS_ERROR_FS);
+		if (!old_format_only(s))
+			set_sb_mnt_count(rs, sb_mnt_count(rs) + 1);
 		/* mark_buffer_dirty (SB_BUFFER_WITH_SB (s), 1); */
 		journal_mark_dirty(&th, s, SB_BUFFER_WITH_SB(s));
 		REISERFS_SB(s)->s_mount_state = REISERFS_VALID_FS;

@@ -1764,7 +1766,9 @@ static int reiserfs_fill_super(struct su
 			} else if (!silent) {
 				reiserfs_info(s, "using 3.5.x disk format\n");
 			}
-		}
+		} else
+			set_sb_mnt_count(rs, sb_mnt_count(rs) + 1);
+
 
 		journal_mark_dirty(&th, s, SB_BUFFER_WITH_SB(s));
 		errval = journal_end(&th, s, 1);

include/linux/reiserfs_fs.h +5 -1

@@ -171,7 +171,11 @@ struct reiserfs_super_block {
 	__le32 s_flags;		/* Right now used only by inode-attributes, if enabled */
 	unsigned char s_uuid[16];	/* filesystem unique identifier */
 	unsigned char s_label[16];	/* filesystem volume label */
-	char s_unused[88];	/* zero filled by mkreiserfs and
+	__le16 s_mnt_count;		/* Count of mounts since last fsck */
+	__le16 s_max_mnt_count;		/* Maximum mounts before check */
+	__le32 s_lastcheck;		/* Timestamp of last fsck */
+	__le32 s_check_interval;	/* Interval between checks */
+	char s_unused[76];	/* zero filled by mkreiserfs and
 				 * reiserfs_convert_objectid_map_v1()
 				 * so any additions must be updated
 				 * there as well. */

include/linux/reiserfs_fs_sb.h +3 -0

@@ -73,6 +73,9 @@ typedef enum {
 #define sb_version(sbp)            (le16_to_cpu((sbp)->s_v1.s_version))
 #define set_sb_version(sbp,v)      ((sbp)->s_v1.s_version = cpu_to_le16(v))
 
+#define sb_mnt_count(sbp)	   (le16_to_cpu((sbp)->s_mnt_count))
+#define set_sb_mnt_count(sbp, v)   ((sbp)->s_mnt_count = cpu_to_le16(v))
+
 #define sb_reserved_for_journal(sbp) \
               (le16_to_cpu((sbp)->s_v1.s_reserved_for_journal))
 #define set_sb_reserved_for_journal(sbp,v) \

Signature · 2 lines

Jeff Mahoney
SUSE Labs

Jeff Mahoney

author

2007-12-03 19:46 UTC #1 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Any comments on this? I'd like to be able to check this into our kernel tree, but I can't do so until these fields have been officially reserved.

- -Jeff

Quoted 53 lines · Jeff Mahoney

The following patch adds the fields for tracking mount counts and last fsck timestamps to the superblock. It also increments the mount count on every read-write mount.

Signed-off-by Jeff Mahoney <[email protected]>

---

 fs/reiserfs/super.c            |    6 +++++-
 include/linux/reiserfs_fs.h    |    6 +++++-
 include/linux/reiserfs_fs_sb.h |    3 +++
 3 files changed, 13 insertions(+), 2 deletions(-)

fs/reiserfs/super.c +5 -1

@@ -1239,6 +1239,8 @@ static int reiserfs_remount(struct super
 		REISERFS_SB(s)->s_mount_state = sb_umount_state(rs);
 		s->s_flags &= ~MS_RDONLY;
 		set_sb_umount_state(rs, REISERFS_ERROR_FS);
+		if (!old_format_only(s))
+			set_sb_mnt_count(rs, sb_mnt_count(rs) + 1);
 		/* mark_buffer_dirty (SB_BUFFER_WITH_SB (s), 1); */
 		journal_mark_dirty(&th, s, SB_BUFFER_WITH_SB(s));
 		REISERFS_SB(s)->s_mount_state = REISERFS_VALID_FS;

@@ -1764,7 +1766,9 @@ static int reiserfs_fill_super(struct su
 			} else if (!silent) {
 				reiserfs_info(s, "using 3.5.x disk format\n");
 			}
-		}
+		} else
+			set_sb_mnt_count(rs, sb_mnt_count(rs) + 1);
+
 
 		journal_mark_dirty(&th, s, SB_BUFFER_WITH_SB(s));
 		errval = journal_end(&th, s, 1);

include/linux/reiserfs_fs.h +5 -1

@@ -171,7 +171,11 @@ struct reiserfs_super_block {
 	__le32 s_flags;		/* Right now used only by inode-attributes, if enabled */
 	unsigned char s_uuid[16];	/* filesystem unique identifier */
 	unsigned char s_label[16];	/* filesystem volume label */
-	char s_unused[88];	/* zero filled by mkreiserfs and
+	__le16 s_mnt_count;		/* Count of mounts since last fsck */
+	__le16 s_max_mnt_count;		/* Maximum mounts before check */
+	__le32 s_lastcheck;		/* Timestamp of last fsck */
+	__le32 s_check_interval;	/* Interval between checks */
+	char s_unused[76];	/* zero filled by mkreiserfs and
 				 * reiserfs_convert_objectid_map_v1()
 				 * so any additions must be updated
 				 * there as well. */

include/linux/reiserfs_fs_sb.h typedef enum { · line 81

Quoted 9 lines

include/linux/reiserfs_fs_sb.h +3 -0

@@ -73,6 +73,9 @@ typedef enum {
 #define sb_version(sbp)            (le16_to_cpu((sbp)->s_v1.s_version))
 #define set_sb_version(sbp,v)      ((sbp)->s_v1.s_version = cpu_to_le16(v))
 
+#define sb_mnt_count(sbp)	   (le16_to_cpu((sbp)->s_mnt_count))
+#define set_sb_mnt_count(sbp, v)   ((sbp)->s_mnt_count = cpu_to_le16(v))
+
 #define sb_reserved_for_journal(sbp) \
               (le16_to_cpu((sbp)->s_v1.s_reserved_for_journal))
 #define set_sb_reserved_for_journal(sbp,v) \

- --
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.4-svn0 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFHVF0NLPWxlyuTD7IRApOuAJ4+oIw0W37hkDrUv8GSGNgX9R8itwCbBWOx FLf7hNIByLk/lkjsLm/4HIY=
=gzSp
-----END PGP SIGNATURE-----

Edward Shishkin

2007-12-03 20:36 UTC #2 lore raw

Hi Jeff.

Personally, I don't object.
What does official reservation mean?
I can send a request to Hans, but I guess
we'll receive his "yes" or "no" with substantial delay..

Thanks,
Edward.

Quoted 89 lines · Jeff Mahoney

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Any comments on this? I'd like to be able to check this into our kernel tree, but I can't do so until these fields have been officially reserved.
- -Jeff
Quoted 53 lines · Jeff Mahoney
The following patch adds the fields for tracking mount counts and last fsck timestamps to the superblock. It also increments the mount count on every read-write mount.
Signed-off-by Jeff Mahoney <[email protected]>
---
 fs/reiserfs/super.c            |    6 +++++-
 include/linux/reiserfs_fs.h    |    6 +++++-
 include/linux/reiserfs_fs_sb.h |    3 +++
 3 files changed, 13 insertions(+), 2 deletions(-)
fs/reiserfs/super.c 2007-11-26 17:32:21.000000000 -0500 renamed from fs/reiserfs/super.c 2007-11-26 17:09:51.000000000 -0500 +5 -1
@@ -1239,6 +1239,8 @@ static int reiserfs_remount(struct super
              REISERFS_SB(s)->s_mount_state = sb_umount_state(rs);
              s->s_flags &= ~MS_RDONLY;
              set_sb_umount_state(rs, REISERFS_ERROR_FS);
+             if (!old_format_only(s))
+                     set_sb_mnt_count(rs, sb_mnt_count(rs) + 1);
              /* mark_buffer_dirty (SB_BUFFER_WITH_SB (s), 1); */
              journal_mark_dirty(&th, s, SB_BUFFER_WITH_SB(s));
              REISERFS_SB(s)->s_mount_state = REISERFS_VALID_FS;
@@ -1764,7 +1766,9 @@ static int reiserfs_fill_super(struct su
                      } else if (!silent) {
                              reiserfs_info(s, "using 3.5.x disk format\n");
                      }
-             }
+             } else
+                     set_sb_mnt_count(rs, sb_mnt_count(rs) + 1);
+
 
              journal_mark_dirty(&th, s, SB_BUFFER_WITH_SB(s));
              errval = journal_end(&th, s, 1);
include/linux/reiserfs_fs.h 2007-11-26 17:22:35.000000000 -0500 renamed from include/linux/reiserfs_fs.h 2007-11-26 17:09:58.000000000 -0500 +5 -1
@@ -171,7 +171,11 @@ struct reiserfs_super_block {
      __le32 s_flags;         /* Right now used only by inode-attributes, if enabled */
      unsigned char s_uuid[16];       /* filesystem unique identifier */
      unsigned char s_label[16];      /* filesystem volume label */
-     char s_unused[88];      /* zero filled by mkreiserfs and
+     __le16 s_mnt_count;             /* Count of mounts since last fsck */
+     __le16 s_max_mnt_count;         /* Maximum mounts before check */
+     __le32 s_lastcheck;             /* Timestamp of last fsck */
+     __le32 s_check_interval;        /* Interval between checks */
+     char s_unused[76];      /* zero filled by mkreiserfs and
                               * reiserfs_convert_objectid_map_v1()
                               * so any additions must be updated
                               * there as well. */
include/linux/reiserfs_fs_sb.h 2007-11-26 17:24:54.000000000 -0500 typedef enum { · line 81
Quoted 9 lines
include/linux/reiserfs_fs_sb.h 2007-11-26 17:24:54.000000000 -0500 renamed from include/linux/reiserfs_fs_sb.h 2007-11-26 17:09:58.000000000 -0500 +3 -0
@@ -73,6 +73,9 @@ typedef enum {
 #define sb_version(sbp)            (le16_to_cpu((sbp)->s_v1.s_version))
 #define set_sb_version(sbp,v)      ((sbp)->s_v1.s_version = cpu_to_le16(v))
 
+#define sb_mnt_count(sbp)       (le16_to_cpu((sbp)->s_mnt_count))
+#define set_sb_mnt_count(sbp, v)   ((sbp)->s_mnt_count = cpu_to_le16(v))
+
 #define sb_reserved_for_journal(sbp) \
               (le16_to_cpu((sbp)->s_v1.s_reserved_for_journal))
 #define set_sb_reserved_for_journal(sbp,v) \
- --
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.4-svn0 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org
iD8DBQFHVF0NLPWxlyuTD7IRApOuAJ4+oIw0W37hkDrUv8GSGNgX9R8itwCbBWOx FLf7hNIByLk/lkjsLm/4HIY=
=gzSp
-----END PGP SIGNATURE-----
-
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Jeff Mahoney

author

2007-12-03 20:40 UTC #3 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 6 lines · Edward Shishkin

Hi Jeff.
Personally, I don't object.
What does official reservation mean?
I can send a request to Hans, but I guess
we'll receive his "yes" or "no" with substantial delay..

I just mean that those 12 bytes in the superblock are guaranteed not to be used for something else. Given the pace of reiserfs development, I don't expect this to be a problem as there are 76 more of them. :)

- -Jeff

- --
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.4-svn0 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFHVGm4LPWxlyuTD7IRAlnYAJ96feQvRpbLlOtPoxPbziOb1BgsQQCgnmrI GC9Hxg0FnQnBAXtOwvri+SE=
=Gfxe
-----END PGP SIGNATURE-----

Edward Shishkin

2007-12-03 20:51 UTC #4 lore raw

Quoted 6 lines · Jeff Mahoney

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Quoted 2 lines · Edward Shishkin
Hi Jeff.

Quoted 8 lines

Quoted 4 lines
Personally, I don't object.
What does official reservation mean?
I can send a request to Hans, but I guess
we'll receive his "yes" or "no" with substantial delay..
I just mean that those 12 bytes in the superblock are guaranteed not to be used for something else. Given the pace of reiserfs development, I don't expect this to be a problem as there are 76 more of them. :)

Well, I promise to not use them for something else ;) It seems we need something like reiserfsprogs-3.6.20?

Edward.

Quoted 15 lines

- -Jeff
- --
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.4-svn0 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org
iD8DBQFHVGm4LPWxlyuTD7IRAlnYAJ96feQvRpbLlOtPoxPbziOb1BgsQQCgnmrI GC9Hxg0FnQnBAXtOwvri+SE=
=Gfxe
-----END PGP SIGNATURE-----

Jeff Mahoney

author

2007-12-03 21:32 UTC #5 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 4 lines · Edward Shishkin

Quoted 2 lines · On 12/3/07, Jeff Mahoney <[email protected]> wrote: Edward Shishkin wrote:
Quoted 2 lines
Quoted 2 lines
Hi Jeff.

Quoted 9 lines

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Personally, I don't object.
What does official reservation mean?
I can send a request to Hans, but I guess
we'll receive his "yes" or "no" with substantial delay..
I just mean that those 12 bytes in the superblock are guaranteed not to be used for something else. Given the pace of reiserfs development, I don't expect this to be a problem as there are 76 more of them. :)
Quoted 1 line
Well, I promise to not use them for something else ;)

Great. That's the assurance I was looking for. :)

Quoted 1 line

Quoted 1 line
It seems we need something like reiserfsprogs-3.6.20?

I actually posted a patch against reiserfsprogs-3.6.20 that reserves the same fields. It also implements the use of those fields. I have an updated version that treats timestamps in the future as suspect and forces a check. I'll post the update later today.

If there's interest in releasing a reiserfsprogs 3.6.21, I have some patches that we've maintaining locally for a while I'd like to submit for inclusion. Also, I don't think the code base would hurt from a whitespace removal run. :)

- -Jeff

- --
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.4-svn0 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFHVHXkLPWxlyuTD7IRAhM1AJ9vBrHDW3uhRb15HnO6BNpQGOdIiwCfUHyL aUwybiy8ZfuOwg0lXZ+xEKE=
=DpoT
-----END PGP SIGNATURE-----

Edward Shishkin

2007-12-03 22:56 UTC #6 lore raw

Quoted 18 lines · Jeff Mahoney

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Quoted 4 lines · Edward Shishkin
Quoted 2 lines · On 12/3/07, Jeff Mahoney <[email protected]> wrote: Edward Shishkin wrote:
Quoted 2 lines
Quoted 2 lines
Hi Jeff.
Quoted 9 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Personally, I don't object.
What does official reservation mean?
I can send a request to Hans, but I guess
we'll receive his "yes" or "no" with substantial delay..
I just mean that those 12 bytes in the superblock are guaranteed not to be used for something else. Given the pace of reiserfs development, I don't expect this to be a problem as there are 76 more of them. :)
Quoted 1 line
Well, I promise to not use them for something else ;)

Quoted 8 lines

Great. That's the assurance I was looking for. :)
Quoted 1 line
Quoted 1 line
It seems we need something like reiserfsprogs-3.6.20?
I actually posted a patch against reiserfsprogs-3.6.20 that reserves the same fields. It also implements the use of those fields. I have an updated version that treats timestamps in the future as suspect and forces a check. I'll post the update later today.

Sorry, I am a bit confused..
The latest git version of reiserfsprogs is 3.6.19; The latest website version is also 3.6.19.
At the same time I can google and see that some distros use reiserfsprogs-3.6.20.
Suse 10.3 uses "reiserfs utility package" 3.6.19-92 Also I remember that Vladimir worked on some version of reiserfsprogs not so long ago.

Any ideas about really latest version?

Thanks,
Edward.

Quoted 20 lines

If there's interest in releasing a reiserfsprogs 3.6.21, I have some patches that we've maintaining locally for a while I'd like to submit for inclusion. Also, I don't think the code base would hurt from a whitespace removal run. :)
- -Jeff
- --
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.4-svn0 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org
iD8DBQFHVHXkLPWxlyuTD7IRAhM1AJ9vBrHDW3uhRb15HnO6BNpQGOdIiwCfUHyL aUwybiy8ZfuOwg0lXZ+xEKE=
=DpoT
-----END PGP SIGNATURE-----

Jeff Mahoney

author

2007-12-03 23:00 UTC #7 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 14 lines · Edward Shishkin

Quoted 12 lines · On 12/4/07, Jeff Mahoney <[email protected]> wrote: Edward Shishkin wrote:
Quoted 12 lines
Quoted 12 lines · Jeff Mahoney
Quoted 6 lines · Edward Shishkin
Quoted 6 lines
Quoted 6 lines
Hi Jeff.
Personally, I don't object.
What does official reservation mean?
I can send a request to Hans, but I guess
we'll receive his "yes" or "no" with substantial delay..
I just mean that those 12 bytes in the superblock are guaranteed not to be used for something else. Given the pace of reiserfs development, I don't expect this to be a problem as there are 76 more of them. :)

Quoted 19 lines

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Well, I promise to not use them for something else ;)
Great. That's the assurance I was looking for. :)
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
It seems we need something like reiserfsprogs-3.6.20?
I actually posted a patch against reiserfsprogs-3.6.20 that reserves the same fields. It also implements the use of those fields. I have an updated version that treats timestamps in the future as suspect and forces a check. I'll post the update later today.
Quoted 10 lines
Sorry, I am a bit confused..
The latest git version of reiserfsprogs is 3.6.19; The latest website version is also 3.6.19.
At the same time I can google and see that some distros use reiserfsprogs-3.6.20.
Suse 10.3 uses "reiserfs utility package" 3.6.19-92 Also I remember that Vladimir worked on some version of reiserfsprogs not so long ago.
Any ideas about really latest version?

I think Vladimir must have released what he was working on as 3.6.20. That's the latest version I downloaded from ftp.namesys.com.

It reorganizes the code into a saner structure as well as cleans up the code quite a bit. It also adds the > 8 TB support that I ended up grafting onto 3.6.19 for our release.

- -Jeff

- --
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.4-svn0 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFHVIqPLPWxlyuTD7IRAlHNAJ90Czg1ZIcwodr0JBZuZ48oXdB1PQCePiwN i2hQJPXkmUU2P+ZPbSkecRk=
=CXkg
-----END PGP SIGNATURE-----

Ric Wheeler

2007-12-05 12:22 UTC #8 lore raw

Quoted 37 lines · Jeff Mahoney

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Quoted 14 lines · Edward Shishkin
Quoted 12 lines · On 12/4/07, Jeff Mahoney <[email protected]> wrote: Edward Shishkin wrote:
Quoted 12 lines
Quoted 12 lines · Jeff Mahoney
Quoted 6 lines · Edward Shishkin
Quoted 6 lines
Quoted 6 lines
Hi Jeff.
Personally, I don't object.
What does official reservation mean?
I can send a request to Hans, but I guess
we'll receive his "yes" or "no" with substantial delay..
I just mean that those 12 bytes in the superblock are guaranteed not to be used for something else. Given the pace of reiserfs development, I don't expect this to be a problem as there are 76 more of them. :)
Quoted 18 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Well, I promise to not use them for something else ;)
Great. That's the assurance I was looking for. :)
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
It seems we need something like reiserfsprogs-3.6.20?
I actually posted a patch against reiserfsprogs-3.6.20 that reserves the same fields. It also implements the use of those fields. I have an updated version that treats timestamps in the future as suspect and forces a check. I'll post the update later today.
Quoted 9 lines
Sorry, I am a bit confused..
The latest git version of reiserfsprogs is 3.6.19; The latest website version is also 3.6.19.
At the same time I can google and see that some distros use reiserfsprogs-3.6.20.
Suse 10.3 uses "reiserfs utility package" 3.6.19-92 Also I remember that Vladimir worked on some version of reiserfsprogs not so long ago.
Any ideas about really latest version?

Quoted 9 lines

I think Vladimir must have released what he was working on as 3.6.20. That's the latest version I downloaded from ftp.namesys.com.
It reorganizes the code into a saner structure as well as cleans up the code quite a bit. It also adds the > 8 TB support that I ended up grafting onto 3.6.19 for our release.
- -Jeff

We have also been working with & testing a draft of Vladimir's updated code (not sure how different it is from what you took in).

Vladimir, did Jeff's drop include all of the changes or part of what you did with us?

We can certainly update or refresh our copy for the next phase of qa,

thanks!

ric

Vladimir Saveliev

2007-12-05 13:01 UTC #9 lore raw

Hello

Quoted 46 lines · Ric Wheeler

Quoted 45 lines · Jeff Mahoney
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Quoted 15 lines · Edward Shishkin
Quoted 13 lines · On 12/4/07, Jeff Mahoney <[email protected]> wrote: Edward Shishkin wrote:
Quoted 13 lines
Quoted 13 lines · Jeff Mahoney
Quoted 6 lines · Edward Shishkin
Quoted 6 lines
Quoted 6 lines
Hi Jeff.
Personally, I don't object.
What does official reservation mean?
I can send a request to Hans, but I guess
we'll receive his "yes" or "no" with substantial delay..
I just mean that those 12 bytes in the superblock are guaranteed not to
be used for something else. Given the pace of reiserfs development, I don't expect this to be a problem as there are 76 more of them. :)
Quoted 18 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Well, I promise to not use them for something else ;)
Great. That's the assurance I was looking for. :)
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
It seems we need something like reiserfsprogs-3.6.20?
I actually posted a patch against reiserfsprogs-3.6.20 that reserves the same fields. It also implements the use of those fields. I have an updated version that treats timestamps in the future as suspect and forces a check. I'll post the update later today.
Quoted 9 lines
Sorry, I am a bit confused..
The latest git version of reiserfsprogs is 3.6.19; The latest website version is also 3.6.19.
At the same time I can google and see that some distros use reiserfsprogs-3.6.20.
Suse 10.3 uses "reiserfs utility package" 3.6.19-92 Also I remember that Vladimir worked on some version of reiserfsprogs not so long ago.
Any ideas about really latest version?
I think Vladimir must have released what he was working on as 3.6.20. That's the latest version I downloaded from ftp.namesys.com.
It reorganizes the code into a saner structure as well as cleans up the code quite a bit. It also adds the > 8 TB support that I ended up grafting onto 3.6.19 for our release.

Quoted 9 lines

Quoted 2 lines
- -Jeff
We have also been working with & testing a draft of Vladimir's updated code (not sure how different it is from what you took in).
Vladimir, did Jeff's drop include all of the changes or part of what you did with us?

No, I do not think so. I forked that work from 3.6.19 and did not put it anywhere but ftp.namesys.com/pub/tmp

Best regards,
Vladimir

Jeff Mahoney

author

2007-12-05 15:32 UTC #10 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 53 lines · Vladimir Saveliev

Hello
Quoted 50 lines · Ric Wheeler
Quoted 37 lines · Jeff Mahoney
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Quoted 15 lines · Edward Shishkin
Quoted 13 lines · On 12/4/07, Jeff Mahoney <[email protected]> wrote: Edward Shishkin wrote:
Quoted 13 lines
Quoted 13 lines · Jeff Mahoney
Quoted 6 lines · Edward Shishkin
Quoted 6 lines
Quoted 6 lines
Hi Jeff.
Personally, I don't object.
What does official reservation mean?
I can send a request to Hans, but I guess
we'll receive his "yes" or "no" with substantial delay..
I just mean that those 12 bytes in the superblock are guaranteed not to
be used for something else. Given the pace of reiserfs development, I don't expect this to be a problem as there are 76 more of them. :)
Quoted 18 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Well, I promise to not use them for something else ;)
Great. That's the assurance I was looking for. :)
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
It seems we need something like reiserfsprogs-3.6.20?
I actually posted a patch against reiserfsprogs-3.6.20 that reserves the same fields. It also implements the use of those fields. I have an updated version that treats timestamps in the future as suspect and forces a check. I'll post the update later today.
Quoted 9 lines
Sorry, I am a bit confused..
The latest git version of reiserfsprogs is 3.6.19; The latest website version is also 3.6.19.
At the same time I can google and see that some distros use reiserfsprogs-3.6.20.
Suse 10.3 uses "reiserfs utility package" 3.6.19-92 Also I remember that Vladimir worked on some version of reiserfsprogs not so long ago.
Any ideas about really latest version?
Quoted 9 lines
I think Vladimir must have released what he was working on as 3.6.20. That's the latest version I downloaded from ftp.namesys.com.
It reorganizes the code into a saner structure as well as cleans up the code quite a bit. It also adds the > 8 TB support that I ended up grafting onto 3.6.19 for our release.
- -Jeff
We have also been working with & testing a draft of Vladimir's updated code (not sure how different it is from what you took in).

Quoted 6 lines

Quoted 3 lines
Vladimir, did Jeff's drop include all of the changes or part of what you did with us?
No, I do not think so. I forked that work from 3.6.19 and did not put it anywhere but ftp.namesys.com/pub/tmp

That's strange. Someone else must've moved it to /pub/reiserfsprogs/ then. That's certainly where I got a copy of it. A google for reiserfsprogs 3.6.20, shows several pointers to ftp://ftp.namesys.com/pub/reiserfsprogs/reiserfsprogs-3.6.20.tar.gz too.

- -Jeff
- --
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.4-svn0 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFHVsSMLPWxlyuTD7IRAhEAAJ9KrNbKYs9Raio2lEuwpt4Ftpz8uQCbB7wl VHhSmxmQNRlwLC5ws6gs3sA=
=rpx2
-----END PGP SIGNATURE-----

Ric Wheeler

2007-12-05 15:39 UTC #11 lore raw

Jeff Mahoney wrote:
....
<snip>
....

Quoted 11 lines

Quoted 3 lines
Quoted 1 line
No, I do not think so. I forked that work from 3.6.19 and did not put it anywhere but ftp.namesys.com/pub/tmp
That's strange. Someone else must've moved it to /pub/reiserfsprogs/ then. That's certainly where I got a copy of it. A google for reiserfsprogs 3.6.20, shows several pointers to ftp://ftp.namesys.com/pub/reiserfsprogs/reiserfsprogs-3.6.20.tar.gz too.
- -Jeff
- --

It would be great to get that work out for broader review & testing if that is not what you picked up...

ric

Jeff Mahoney

author

2007-12-05 15:52 UTC #12 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 15 lines · Ric Wheeler

Jeff Mahoney wrote:
....
<snip>
....
Quoted 9 lines
Quoted 3 lines
Quoted 1 line
No, I do not think so. I forked that work from 3.6.19 and did not put it anywhere but ftp.namesys.com/pub/tmp
That's strange. Someone else must've moved it to /pub/reiserfsprogs/ then. That's certainly where I got a copy of it. A google for reiserfsprogs 3.6.20, shows several pointers to ftp://ftp.namesys.com/pub/reiserfsprogs/reiserfsprogs-3.6.20.tar.gz too.

Quoted 5 lines

Quoted 2 lines
- -Jeff
- --
It would be great to get that work out for broader review & testing if that is not what you picked up...

The testing part we'll get automatically. It's checked into our internal testing distribution at SUSE, which eventually gets mirrored out as OpenSUSE Factory.

- -Jeff

- --
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.4-svn0 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFHVslLLPWxlyuTD7IRAkvCAJ9WeQegQCl9JhJWr47eu6U7yYCt0wCeOKk6 S5rzZUEP4oRXAMkYdUlD8j4=
=3jac
-----END PGP SIGNATURE-----

Vladimir Saveliev

2007-12-05 17:53 UTC #13 lore raw

In reply to Jeff Mahoney

Hello

Quoted 2 lines · Jeff Mahoney

That's strange.

No, 3.6.20 was made by Vitaly, it mostly contains massive cleanups and an --rebuild-tree optimization for specific filesystem corruption which made reiserfsck to work extremely slow.

The work I did for EMC was about improving of overal reiserfsck performance. I have local cvs repository for that work and put code snapshots at ftp://ftp.namesys.com/pub/tmp. So, that work is not included into 3.6.20.

I am sorry that things got messed up that much, please let me know if I can help to work out something reasonable.

Quoted 5 lines

Someone else must've moved it to /pub/reiserfsprogs/
then. That's certainly where I got a copy of it. A google for reiserfsprogs 3.6.20, shows several pointers to ftp://ftp.namesys.com/pub/reiserfsprogs/reiserfsprogs-3.6.20.tar.gz too.

Best regards,
Vladimir

Ric Wheeler

2007-12-05 18:18 UTC #14 lore raw

Quoted 18 lines · Vladimir Saveliev

Hello
Quoted 1 line · Jeff Mahoney
That's strange.
No, 3.6.20 was made by Vitaly, it mostly contains massive cleanups and an --rebuild-tree optimization for specific filesystem corruption which made reiserfsck to work extremely slow.
The work I did for EMC was about improving of overal reiserfsck performance. I have local cvs repository for that work and put code snapshots at ftp://ftp.namesys.com/pub/tmp. So, that work is not included into 3.6.20.
I am sorry that things got messed up that much, please let me know if I can help to work out something reasonable.

Quoted 8 lines

Quoted 5 lines
Someone else must've moved it to /pub/reiserfsprogs/
then. That's certainly where I got a copy of it. A google for reiserfsprogs 3.6.20, shows several pointers to ftp://ftp.namesys.com/pub/reiserfsprogs/reiserfsprogs-3.6.20.tar.gz too.
Best regards,
Vladimir

And of course, we will be happy to try and help with the testing/error injection, etc...

It is good work and well worth getting rolled back into the changes,

ric

Jeff Mahoney

author

2008-01-24 19:52 UTC #15 lore raw

In reply to Jeff Mahoney

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 34 lines · Jeff Mahoney

Quoted 14 lines · Edward Shishkin
Quoted 12 lines · On 12/4/07, Jeff Mahoney <[email protected]> wrote: Edward Shishkin wrote:
Quoted 12 lines
Quoted 12 lines · Jeff Mahoney
Quoted 6 lines · Edward Shishkin
Quoted 6 lines
Quoted 6 lines
Hi Jeff.
Personally, I don't object.
What does official reservation mean?
I can send a request to Hans, but I guess
we'll receive his "yes" or "no" with substantial delay..
I just mean that those 12 bytes in the superblock are guaranteed not to be used for something else. Given the pace of reiserfs development, I don't expect this to be a problem as there are 76 more of them. :)
Quoted 18 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Well, I promise to not use them for something else ;)
Great. That's the assurance I was looking for. :)
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
It seems we need something like reiserfsprogs-3.6.20?
I actually posted a patch against reiserfsprogs-3.6.20 that reserves the same fields. It also implements the use of those fields. I have an updated version that treats timestamps in the future as suspect and forces a check. I'll post the update later today.
Quoted 9 lines
Sorry, I am a bit confused..
The latest git version of reiserfsprogs is 3.6.19; The latest website version is also 3.6.19.
At the same time I can google and see that some distros use reiserfsprogs-3.6.20.
Suse 10.3 uses "reiserfs utility package" 3.6.19-92 Also I remember that Vladimir worked on some version of reiserfsprogs not so long ago.
Any ideas about really latest version?

Quoted 6 lines

I think Vladimir must have released what he was working on as 3.6.20. That's the latest version I downloaded from ftp.namesys.com.
It reorganizes the code into a saner structure as well as cleans up the code quite a bit. It also adds the > 8 TB support that I ended up grafting onto 3.6.19 for our release.

Just to follow up here, the 3.6.20 release must've been a work in progress. It's totally hosed on big endian machines.

I'll repost those patches against 3.6.19, since I just had to backport them anyway.

- -Jeff

- --
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.4-svn0 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFHmOxsLPWxlyuTD7IRAt2/AKCFoobXXBjiyc50o46Lgp+iHMh7yQCfUwDM Ex6LTc+gkotgu4NfTfmtDj0=
=U8tD
-----END PGP SIGNATURE-----