Move CONFIG_X86 decleration to be x86 specific in configure script

PATCH In review Jerone Young 3 participants 7 messages Dec 5, 2007 – Dec 9, 2007 3 messages not in the archive KVM

Share & tools

Jerone Young

author

2007-12-05 21:50 UTC #0 lore raw

PATCH 1/1 Move CONFIG_X86 decleration to be x86 specific in configure script

# HG changeset patch
# User Jerone Young <jyoung5-r/[email protected]> # Date 1196891226 21600
# Node ID a30e578bd6e2cf7599ce0c57066880658ddf2886
# Parent b4cf8e05d20b3f4ca658bb4fdf3db3e4393a5d8a
Move CONFIG_X86 decleration to be x86 specific in configure script

In the configure script CONFIG_X86 is explicitly declared for qemu. Now while today the support for other archs is not exactly in kvm just yet (it's coming)..this shouldn't be specified for everyone ;-)

Signed-off-by Jerone Young <jyoung5-r/[email protected]>

configure +2 -1

@@ -99,6 +99,7 @@ fi
 #set parameters compiling
 if [ "$arch" = "i386" -o "$arch" = "x86_64" ]; then
     target_exec="x86_64-softmmu"
+    qemu_cflags+=" -DCONFIG_X86"
 fi
 
 #configure user dir

@@ -109,7 +110,7 @@ fi
 #configure qemu
 (cd qemu; ./configure --target-list=$target_exec \
     --disable-kqemu \
-    --extra-cflags="-I $PWD/../libkvm $qemu_cflags -DCONFIG_X86" \
+    --extra-cflags="-I $PWD/../libkvm $qemu_cflags" \
     --extra-ldflags="-L $PWD/../libkvm $qemu_ldflags" \
     --enable-kvm --kernel-path="$libkvm_kerneldir" \
     ${enable_alsa:+"--enable-alsa"} \

-------------------------------------------------------------------------
SF.Net email is sponsored by: The Future of Linux Business White Paper from Novell. From the desktop to the data center, Linux is going mainstream. Let it simplify your IT future.
http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4

Zhang, Xiantao

2007-12-06 03:06 UTC #1 lore raw

Re: [PATCH] Move CONFIG_X86 decleration to be x86 specificin configure script

Quoted 18 lines · Jerone Young

# HG changeset patch
# User Jerone Young <jyoung5-r/[email protected]> # Date 1196891226 21600
# Node ID a30e578bd6e2cf7599ce0c57066880658ddf2886
# Parent b4cf8e05d20b3f4ca658bb4fdf3db3e4393a5d8a
Move CONFIG_X86 decleration to be x86 specific in configure script
In the configure script CONFIG_X86 is explicitly declared for qemu. Now while today the support for other archs is not exactly in kvm just yet (it's coming)..this shouldn't be specified for everyone ;-)
Signed-off-by Jerone Young <jyoung5-r/[email protected]>

configure fi · line 102

Quoted 4 lines

configure +1 -0

@@ -99,6 +99,7 @@ fi
 #set parameters compiling
 if [ "$arch" = "i386" -o "$arch" = "x86_64" ]; then
     target_exec="x86_64-softmmu"
+    qemu_cflags+=" -DCONFIG_X86"

Hi, Young
Are you sure it works for you? Seems in script, it can't
recognize "+=". Anyway, I also have a fix about it in my patch queue, when I do ia64 porting.
Thanks
Xiantao

Quoted 1 line

------------------------------------------------------------------------
-

Quoted 8 lines

SF.Net email is sponsored by: The Future of Linux Business White Paper from Novell. From the desktop to the data center, Linux is going mainstream. Let it simplify your IT future.
http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4
_______________________________________________
kvm-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/kvm-devel

From 86c60dc416c8c8159bbe4c53bf6256a9d3cf82ce Mon Sep 17 00:00:00 2001
From: Zhang Xiantao <[email protected]>
Date: Wed, 5 Dec 2007 10:03:03 +0800
Subject: [PATCH] kvm : qemu : Moving CONFIG_X86 to x86 arch for other arch support.

Moving CONFIG_X86 to x86 arch for other arch support.

Signed-off-by Zhang Xiantao <[email protected]>

---
 configure |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

configure +2 -1

index c6b3ff3..dadda8e 100755
@@ -99,6 +99,7 @@ fi
 #set parameters compiling
 if [ "$arch" = "i386" -o "$arch" = "x86_64" ]; then
     target_exec="x86_64-softmmu"
+    qemu_cflags="$qemu_cflags -DCONFIG_X86"
 fi
 
 if [ "$arch" = "ia64" ]; then

@@ -113,7 +114,7 @@ fi
 #configure qemu
 (cd qemu; ./configure --target-list=$target_exec \
     --disable-kqemu \
-    --extra-cflags="-I $PWD/../libkvm $qemu_cflags -DCONFIG_X86" \
+    --extra-cflags="-I $PWD/../libkvm $qemu_cflags" \
     --extra-ldflags="-L $PWD/../libkvm $qemu_ldflags" \
     --enable-kvm --kernel-path="$libkvm_kerneldir" \
     ${enable_alsa:+"--enable-alsa"} \

Signature · 1 line

1.5.2

_______________________________________________
kvm-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/kvm-devel

A message that is not in the archive (sent off-list or not yet received): 42DFA526FC41B1429CE7279EF83C6BDCA85AC8-wq7ZOvIWXbMAbVU2wMM1CrfspsVTdybXVpNB7YpNyf8@public.gmane.org

Jerone Young

author

2007-12-06 19:13 UTC #3 lore raw

Re: [PATCH] Move CONFIG_X86 decleration to be x86 specificin configure script

Quoted 15 lines · Xiantao

Quoted 14 lines · Jerone Young
# HG changeset patch
# User Jerone Young <jyoung5-r/[email protected]> # Date 1196891226 21600
# Node ID a30e578bd6e2cf7599ce0c57066880658ddf2886
# Parent b4cf8e05d20b3f4ca658bb4fdf3db3e4393a5d8a
Move CONFIG_X86 decleration to be x86 specific in configure script
In the configure script CONFIG_X86 is explicitly declared for qemu. Now while today the support for other archs is not exactly in kvm just yet (it's coming)..this shouldn't be specified for everyone ;-)
Signed-off-by Jerone Young <jyoung5-r/[email protected]>

Quoted 13 lines

configure fi · line 102
Quoted 8 lines
configure +1 -0
@@ -99,6 +99,7 @@ fi
 #set parameters compiling
 if [ "$arch" = "i386" -o "$arch" = "x86_64" ]; then
     target_exec="x86_64-softmmu"
+    qemu_cflags+=" -DCONFIG_X86"
Hi, Young
Are you sure it works for you? Seems in script, it can't
recognize "+=". Anyway, I also have a fix about it in my patch queue, when I do ia64 porting.

Really? Hmmm.. that is valid bash syntax. Seems to work fine when I do it on the command line. Also seems to work out in my script as well. If this is the case then maybe it's a newer bash feature.

Quoted 16 lines

Thanks
Xiantao
Quoted 1 line
------------------------------------------------------------------------
-
Quoted 8 lines
SF.Net email is sponsored by: The Future of Linux Business White Paper from Novell. From the desktop to the data center, Linux is going mainstream. Let it simplify your IT future.
http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4
_______________________________________________
kvm-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Quoted 6 lines

-------------------------------------------------------------------------
SF.Net email is sponsored by: The Future of Linux Business White Paper
from Novell. From the desktop to the data center, Linux is going
mainstream. Let it simplify your IT future.
http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4
_______________________________________________ kvm-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/kvm-devel

Avi Kivity

2007-12-06 19:30 UTC #4 lore raw

Re: [PATCH] Move CONFIG_X86 decleration to be x86 specificin configure script

Quoted 10 lines · Jerone Young

Quoted 5 lines
Hi, Young
Are you sure it works for you? Seems in script, it can't
recognize "+=". Anyway, I also have a fix about it in my patch queue, when I do ia64 porting.
Really? Hmmm.. that is valid bash syntax. Seems to work fine when I do it on the command line. Also seems to work out in my script as well. If this is the case then maybe it's a newer bash feature.

Not all systems use bash.

Signature · 8 lines

Any sufficiently difficult bug is indistinguishable from a feature.


-------------------------------------------------------------------------
SF.Net email is sponsored by: The Future of Linux Business White Paper
from Novell.  From the desktop to the data center, Linux is going
mainstream.  Let it simplify your IT future.
http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4

A message that is not in the archive (sent off-list or not yet received): 47584DBF.40207-atKUWr5tajBWk0Htik3J/[email protected]

Jerone Young

author

2007-12-06 21:51 UTC #6 lore raw

Re: [PATCH] Move CONFIG_X86 decleration to be x86 specificin configure script

Quoted 7 lines · Avi Kivity

Quoted 6 lines · Jerone Young
Quoted 5 lines
Hi, Young
Are you sure it works for you? Seems in script, it can't
recognize "+=". Anyway, I also have a fix about it in my patch queue, when I do ia64 porting.

Quoted 6 lines

Quoted 4 lines
Really? Hmmm.. that is valid bash syntax. Seems to work fine when I do it on the command line. Also seems to work out in my script as well. If this is the case then maybe it's a newer bash feature.
Not all systems use bash.

True, but at the top of the configure script is "#!/bin/bash" :-)

perhaps an easier way is to just do

qemu_cflags="$qemu_cflags --DCONFIG_X86"

This way there shouldn't be any issues.

Here is a patch:

Signed-off-by Jerone Young <jyoung5-r/[email protected]>

Move CONFIG_X86 decleration to be x86 specific in configure script

In the configure script CONFIG_X86 is explicitly declared for qemu.

Signed-off-by Jerone Young <jyoung5-r/[email protected]>

configure +2 -1

@@ -99,6 +99,7 @@ fi
 #set parameters compiling
 if [ "$arch" = "i386" -o "$arch" = "x86_64" ]; then
     target_exec="x86_64-softmmu"
+    qemu_cflags="$qemu_cflags -DCONFIG_X86"
 fi
 
 if [ "$arch" = "ia64" ]; then

@@ -113,7 +114,7 @@ fi
 #configure qemu
 (cd qemu; ./configure --target-list=$target_exec \
     --disable-kqemu \
-    --extra-cflags="-I $PWD/../libkvm $qemu_cflags -DCONFIG_X86" \
+    --extra-cflags="-I $PWD/../libkvm $qemu_cflags" \
     --extra-ldflags="-L $PWD/../libkvm $qemu_ldflags" \
     --enable-kvm --kernel-path="$libkvm_kerneldir" \
     ${enable_alsa:+"--enable-alsa"} \

-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php

Zhang, Xiantao

2007-12-07 01:15 UTC #7 lore raw

Re: [PATCH] Move CONFIG_X86 decleration tobe x86 specificin configure script

Quoted 48 lines · Jerone Young

Quoted 7 lines · Avi Kivity
Quoted 6 lines · Jerone Young
Quoted 5 lines
Hi, Young
Are you sure it works for you? Seems in script, it can't
recognize "+=". Anyway, I also have a fix about it in my patch queue, when I do ia64 porting.
Quoted 6 lines
Quoted 4 lines
Really? Hmmm.. that is valid bash syntax. Seems to work fine when I do it on the command line. Also seems to work out in my script as well. If this is the case then maybe it's a newer bash feature.
Not all systems use bash.
True, but at the top of the configure script is "#!/bin/bash" :-)
perhaps an easier way is to just do
qemu_cflags="$qemu_cflags --DCONFIG_X86"
This way there shouldn't be any issues.
Here is a patch:
Signed-off-by Jerone Young <jyoung5-r/[email protected]>
Move CONFIG_X86 decleration to be x86 specific in configure script
In the configure script CONFIG_X86 is explicitly declared for qemu.
Signed-off-by Jerone Young <jyoung5-r/[email protected]>
configure +1 -0
@@ -99,6 +99,7 @@ fi
 #set parameters compiling
 if [ "$arch" = "i386" -o "$arch" = "x86_64" ]; then
     target_exec="x86_64-softmmu"
+    qemu_cflags="$qemu_cflags -DCONFIG_X86"
 fi
 
 if [ "$arch" = "ia64" ]; then

configure fi · line 120

Quoted 8 lines

configure +1 -1

@@ -113,7 +114,7 @@ fi
 #configure qemu
 (cd qemu; ./configure --target-list=$target_exec \
     --disable-kqemu \
-    --extra-cflags="-I $PWD/../libkvm $qemu_cflags -DCONFIG_X86" \
+    --extra-cflags="-I $PWD/../libkvm $qemu_cflags" \
     --extra-ldflags="-L $PWD/../libkvm $qemu_ldflags" \
     --enable-kvm --kernel-path="$libkvm_kerneldir" \
     ${enable_alsa:+"--enable-alsa"} \

Yes, That is also what I did in my patch. Been attached in privious mail :)

Xiantao

A message that is not in the archive (sent off-list or not yet received): 42DFA526FC41B1429CE7279EF83C6BDCA85D8E-wq7ZOvIWXbMAbVU2wMM1CrfspsVTdybXVpNB7YpNyf8@public.gmane.org

Avi Kivity

2007-12-09 17:10 UTC #9 lore raw

Re: [PATCH] Move CONFIG_X86 decleration tobe x86 specificin configure script

Quoted 4 lines · Xiantao

Yes, That is also what I did in my patch. Been attached in privious mail :)

Ok, applied that one.

Signature · 9 lines

error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php