ps3: "mm/Kconfig" fix

PATCH In review Miguel Botón 2 participants 3 messages Dec 8, 2007 – Dec 9, 2007

Subsystems (2)

Memory management MM core

lore

Share & tools

lore

Miguel Botón

author

2007-12-08 19:30 UTC #0 lore raw

PATCH 1/1 ps3: "mm/Kconfig" fix

sparsemem-make-sparsemem-vmemmap-selectable.patch introduces a little bug.

SPARSEMEM_VMEMMAP can be enabled in an architecture that doesn't support it. If the architecture supports SPARSEMEM_VMEMMAP, SPARSEMEM_VMEMMAP_ENABLE is enabled, so SPARSEMEM_VMEMMAP should depend on it.

Signed-off-by Miguel Botón <[email protected]>

mm/Kconfig +2 -2

index c0f5cbb..010a261 100644
@@ -117,8 +117,8 @@ config SPARSEMEM_VMEMMAP_ENABLE
 
 config SPARSEMEM_VMEMMAP
 	bool "Sparse Memory virtual memmap"
-	depends on SPARSEMEM
-	default y if (SPARSEMEM_VMEMMAP_ENABLE)
+	depends on SPARSEMEM_VMEMMAP_ENABLE
+	default y
 	help
 	 SPARSEMEM_VMEMMAP uses a virtually mapped memmap to optimise
 	 pfn_to_page and page_to_pfn operations.  This is the most

Signature · 1 line

	Miguel Botón

Miguel Botón

author

2007-12-08 20:06 UTC #1 lore raw

Previous patch had another bug. This one works fine.

Signed-off-by Miguel Botón <[email protected]>

mm/Kconfig +1 -1

index 010a261..9ef9741 100644
@@ -117,7 +117,7 @@ config SPARSEMEM_VMEMMAP_ENABLE
 
 config SPARSEMEM_VMEMMAP
 	bool "Sparse Memory virtual memmap"
-	depends on SPARSEMEM_VMEMMAP_ENABLE
+	depends on SPARSEMEM && SPARSEMEM_VMEMMAP_ENABLE
 	default y
 	help
 	 SPARSEMEM_VMEMMAP uses a virtually mapped memmap to optimise

Signature · 1 line

	Miguel Botón

Geoff Levand

2007-12-09 02:34 UTC #2 lore raw

In reply to Miguel Botón

Quoted 5 lines · Miguel Botón

sparsemem-make-sparsemem-vmemmap-selectable.patch introduces a little bug.
SPARSEMEM_VMEMMAP can be enabled in an architecture that doesn't support it. If the architecture supports SPARSEMEM_VMEMMAP, SPARSEMEM_VMEMMAP_ENABLE is enabled, so SPARSEMEM_VMEMMAP should depend on it.

sparsemem-make-sparsemem-vmemmap-selectable.patch is still only in my ps3-linux-patches.git development repo. I'll just fold this into the original patch. Thanks.

-Geoff