Skip to contentSkip to conversation

libata: add ST3160023AS / 3.42 to NCQ blacklist

PATCH In review Tejun Heo 2 participants 2 messages Dec 9, 2007 – Dec 18, 2007 libata

lore
Share & tools
lore

Tejun Heo

author
#0 lore raw

PATCH 1/1 libata: add ST3160023AS / 3.42 to NCQ blacklist

Like ST380817AS / 3.42, ST3160023AS / 3.42 times out commands if NCQ is used. Blacklist it. This is reported by Matheus Izvekov in the following thread.

http://thread.gmane.org/gmane.linux.ide/24202

Cc Matheus Izvekov <[email protected]>

---
It could be that all devices with 3.42 firmware have this problem. I'll ask around. Thanks.

 drivers/ata/libata-core.c |    1 +
 1 file changed, 1 insertion(+)
drivers/ata/libata-core.c +1 -0
index e4dea86..e080b07 100644
@@ -4149,6 +4149,7 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
 	{ "HITACHI HDS7250SASUN500G*", NULL,    ATA_HORKAGE_NONCQ },
 	{ "HITACHI HDS7225SBSUN250G*", NULL,    ATA_HORKAGE_NONCQ },
 	{ "ST380817AS",		"3.42",		ATA_HORKAGE_NONCQ },
+	{ "ST3160023AS",	"3.42",		ATA_HORKAGE_NONCQ },
 
 	/* Blacklist entries taken from Silicon Image 3124/3132
 	   Windows driver .inf file - also several Linux problem reports */
#1 lore raw
Quoted 20 lines · Tejun Heo

Like ST380817AS / 3.42, ST3160023AS / 3.42 times out commands if NCQ is used. Blacklist it. This is reported by Matheus Izvekov in the following thread.

http://thread.gmane.org/gmane.linux.ide/24202

Cc Matheus Izvekov <[email protected]>

---
It could be that all devices with 3.42 firmware have this problem. I'll ask around. Thanks.

 drivers/ata/libata-core.c |    1 +
 1 file changed, 1 insertion(+)
drivers/ata/libata-core.c +0 -0
index e4dea86..e080b07 100644

drivers/ata/libata-core.c static const struct ata_blacklist_entry ata_device_blacklist [] = { · line 4152

Quoted 4 lines
drivers/ata/libata-core.c +1 -0
@@ -4149,6 +4149,7 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
 	{ "HITACHI HDS7250SASUN500G*", NULL,    ATA_HORKAGE_NONCQ },
 	{ "HITACHI HDS7225SBSUN250G*", NULL,    ATA_HORKAGE_NONCQ },
 	{ "ST380817AS",		"3.42",		ATA_HORKAGE_NONCQ },
+	{ "ST3160023AS",	"3.42",		ATA_HORKAGE_NONCQ },

applied #upstream-fixes