Skip to contentSkip to conversation

scsi/lpfc/lpfc_attr.c: bogus code

DISCUSSION Adrian Bunk 2 participants 2 messages Dec 11, 2007 – Dec 12, 2007 SCSI

lore
Share & tools
lore
#0 lore raw

Commit 2e0fef85e098f6794956b8b80b111179fbb4cbb7 added the folowing code to drivers/scsi/lpfc/lpfc_attr.c that was most likely not intended to be dead code:

<-- snip -->

...
lpfc_state_show(struct class_device *cdev, char *buf) {
...

                switch (vport->port_state) {
                        len += snprintf(buf + len, PAGE_SIZE-len,
                                        "initializing\n");
                        break;

...

<-- snip -->

Spotted by the GNU C compiler version 3.3.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#1 lore raw

This has already been fixed. It's in our 8.2.3 patches, which were merged into James's scsi-misc-2.6 tree at the beginning of November, and targeted for 2.6.25.

-- james s

Quoted 21 lines · Adrian Bunk

Commit 2e0fef85e098f6794956b8b80b111179fbb4cbb7 added the folowing code to drivers/scsi/lpfc/lpfc_attr.c that was most likely not intended to be dead code:

<-- snip -->

...
lpfc_state_show(struct class_device *cdev, char *buf) {
...

                switch (vport->port_state) {
                        len += snprintf(buf + len, PAGE_SIZE-len,
                                        "initializing\n");
                        break;

...

<-- snip -->

Spotted by the GNU C compiler version 3.3.

cu
Adrian