Skip to contentSkip to conversation

ax25_send_frame() called with a constant paclen = 260

PATCH New Bernard Pidoux 1 participant 1 message Dec 14, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ax25_send_frame() called with a constant paclen = 260

Hi,

In rose_link.c ax25_send_frame() was called with a constant paclen parameter of 260 bytes.
This value looked odd to me for it did not correspond to any defined or possible computed length.Replacing this value by 0 (zero) allowed ax25_send_frame() to substitute it by the default AX25 frame size, which in turn induced significant results on the AX25 frame fragmentation and removed some garbage trailing characters in AX25 frames sent.

signed off by Bernard Pidoux, [email protected]

net/rose/rose_link.c +1 -1
@@ -107,7 +107,7 @@
 	else
 		rose_call = &rose_callsign;
 
-	neigh->ax25 = ax25_send_frame(skb, 260, rose_call, &neigh->callsign, neigh->digipeat, neigh->dev);
+	neigh->ax25 = ax25_send_frame(skb, 0, rose_call, &neigh->callsign, neigh->digipeat, neigh->dev);
 
 	return (neigh->ax25 != NULL);
 }