Skip to contentSkip to conversation

scsi: revert "[SCSI] Get rid of scsi_cmnd->done"

PATCH Thomas Meyer 2 participants 2 messages Jan 6, 2008

lore
Share & tools
lore
#0 lore raw

Hi,

I confirm Peter's observations:

Quoted 14 lines

To repeat:

1. Start with an empty drive.
2. pktsetup 0 /dev/scd0
3. Insert a CD containing an isofs filesystem.
4. mount /dev/pktcdvd/0 /mnt/tmp
5. umount /mnt/tmp
6. Press the eject button.
7. Insert a DVD containing a non-writable filesystem.
8. mount /dev/scd0 /mnt/tmp
9. find /mnt/tmp -type f -print0 | xargs -0 sha1sum >/dev/null
10. If the DVD contains data beyond the physical size of a CD, you get I/O errors in the terminal, and dmesg reports lots of "attempt to access beyond end of device" errors.

This is the correct setup to trigger the bug. And the commit 6f5391c283d7fdcf24bf40786ea79061919d1e1d has nothing to do with this bug. It was bad luck that i couldn't trigger the bug with said commit reverted (in my tests, the second boot with the reverted commit missed the first mount/umount smaller cd step, so...)

So sorry for all the mess and stress.

I'm glad that Peter found the real nature of this bug.

mfg
thomas

#1 lore raw
Quoted 5 lines · Thomas Meyer

This is the correct setup to trigger the bug. And the commit 6f5391c283d7fdcf24bf40786ea79061919d1e1d has nothing to do with this bug. It was bad luck that i couldn't trigger the bug with said commit reverted (in my tests, the second boot with the reverted commit missed the first mount/umount smaller cd step, so...)

Great. Linus, can you revert the revert now?

Signature · 4 lines
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."