x86: ioport_{32|64}.c unification -v2

PATCH In review Miguel Botón 2 participants 5 messages Jan 6, 2008 x86

lore

Share & tools

lore

Miguel Botón

author

2008-01-06 14:57 UTC #0 lore raw

PATCH 1/1 x86: ioport_{32|64}.c unification -v2

ioport_{32|64}.c unification.

This patch unifies the code from the ioport_32.c and ioport_64.c files.

Tested and working fine with i386 and x86_64 kernels.

Signed-off-by Miguel Botón <[email protected]>

arch/x86/kernel/Makefile +1 -1

index 0903bbf..92d9ac6 100644
@@ -10,7 +10,7 @@ CFLAGS_vsyscall_64.o := $(PROFILING) -g0
 
 obj-y			:= process_$(BITS).o signal_$(BITS).o entry_$(BITS).o
 obj-y			+= traps_$(BITS).o irq_$(BITS).o
-obj-y			+= time_$(BITS).o ioport_$(BITS).o ldt.o
+obj-y			+= time_$(BITS).o ioport.o ldt.o
 obj-y			+= setup_$(BITS).o i8259_$(BITS).o
 obj-$(CONFIG_X86_32)	+= sys_i386_32.o i386_ksyms_32.o
 obj-$(CONFIG_X86_64)	+= sys_x86_64.o x8664_ksyms_64.o

arch/x86/kernel/ioport.c new file +150 -0

150 lines not on this page · raw message

arch/x86/kernel/ioport_32.c deleted +0 ~~-129~~

129 lines not on this page · raw message

arch/x86/kernel/ioport_64.c deleted +0 ~~-117~~

117 lines not on this page · raw message

---
Miguel Botón

Ingo Molnar

2008-01-06 15:04 UTC #1 lore raw

Quoted 6 lines · Miguel Botón

ioport_{32|64}.c unification.
This patch unifies the code from the ioport_32.c and ioport_64.c files.
Tested and working fine with i386 and x86_64 kernels.

in what way have you tested it? Have you tried iopl() and ioperm() syscalls to check whether they properly block/allow port IO?

Ingo

Miguel Botón

author

2008-01-06 15:49 UTC #2 lore raw

Quoted 12 lines · Ingo Molnar

Quoted 6 lines · Miguel Botón
ioport_{32|64}.c unification.
This patch unifies the code from the ioport_32.c and ioport_64.c files.
Tested and working fine with i386 and x86_64 kernels.
in what way have you tested it? Have you tried iopl() and ioperm() syscalls to check whether they properly block/allow port IO?

Quoted 6 lines

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

I made a little app to check that iopl() and ioperm() were working properly.

---
Miguel Botón

Ingo Molnar

2008-01-06 16:17 UTC #3 lore raw

Quoted 5 lines · Miguel Botón

Quoted 2 lines
in what way have you tested it? Have you tried iopl() and ioperm() syscalls to check whether they properly block/allow port IO?
I made a little app to check that iopl() and ioperm() were working properly.

cool, thx. Could you check whether LTP includes something like that already - and if not, send it to the LTP maintainers?

Ingo

Miguel Botón

author

2008-01-06 16:34 UTC #4 lore raw

Quoted 10 lines · Ingo Molnar

Quoted 4 lines · Miguel Botón
Quoted 2 lines
in what way have you tested it? Have you tried iopl() and ioperm() syscalls to check whether they properly block/allow port IO?
I made a little app to check that iopl() and ioperm() were working properly.
cool, thx. Could you check whether LTP includes something like that already - and if not, send it to the LTP maintainers?

Quoted 6 lines

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

of course ;)

---
Miguel Botón