Skip to contentSkip to conversation

Not use absolute MBAR in MPC5200 Bestcomm firmware

PATCH New Oliver Weber 2 participants 2 messages Jan 9, 2008

lore
Share & tools
lore

Oliver Weber

author
#0 lore raw

PATCH 1/1 Not use absolute MBAR in MPC5200 Bestcomm firmware

Hi,

the following patch is for the MPC5200 Bestcomm firmware. This patch removes the absolute adressing of the MBAR registers at address 0xf0000000 and makes the FEC driver runable on custom boards which have the MBAR located at other places.

Best regards

Oliver Weber

cpu/mpc5xxx/firmware_sc_task_bestcomm.impl.S +4 -4
index 1d83fe2..a07c776 100644
@@ -23,7 +23,7 @@ scEthernetRecv_Entry:		/* Task 0 */
  .long   0x00000000
  .long   0x00000000
  .long   scEthernetRecv_CSave - taskTable	/* Task 0 context save space */
-.long   0xf0000000
+.long   CFG_MBAR
  .globl scEthernetXmit_Entry
  scEthernetXmit_Entry:		/* Task 1 */
  .long   scEthernetXmit_TDT - taskTable	/* Task 1 Descriptor Table */

@@ -33,7 +33,7 @@ scEthernetXmit_Entry:		/* Task 1 */
  .long   0x00000000
  .long   0x00000000
  .long   scEthernetXmit_CSave - taskTable	/* Task 1 context save space */
-.long   0xf0000000
+.long   CFG_MBAR
 
 
  .globl scEthernetRecv_TDT

@@ -151,7 +151,7 @@ scEthernetRecv_VarTab:	/* Task 0 Variabl
  .long   0x00000000	/* var[6] */
  .long   0x00000000	/* var[7] */
  .long   0x00000000	/* var[8] */
-.long   0xf0008800	/* var[9] */
+.long   (CFG_MBAR + 0x8800)	/* var[9] */
  .long   0x00000008	/* var[10] */
  .long   0x0000000c	/* var[11] */
  .long   0x80000000	/* var[12] */

@@ -190,7 +190,7 @@ scEthernetXmit_VarTab:	/* Task 1 Variabl
  .long   0x00000000	/* var[8] */
  .long   0x00000000	/* var[9] */
  .long   0x00000000	/* var[10] */
-.long   0xf0008800	/* var[11] */
+.long   (CFG_MBAR + 0x8800)	/* var[11] */
  .long   0x00000000	/* var[12] */
  .long   0x80000000	/* var[13] */
  .long   0x10000000	/* var[14] */
#1 lore raw

PATCH 1/1 Not use absolute MBAR in MPC5200 Bestcomm firmware

Quoted 6 lines · In message <[email protected]> you wrote:

Hi,

the following patch is for the MPC5200 Bestcomm firmware. This patch removes the absolute adressing of the MBAR registers at address 0xf0000000 and makes the FEC driver runable on custom boards which have the MBAR located at other places.

Your patch has corrupted whit space and cannot be applied. Please fix your mailer and resubmit.

And make sure to add the required signed-off-by line.

Best regards,

Wolfgang Denk

Signature · 5 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Worlds may change, galaxies disintegrate, but a woman always  remains
a woman.
	-- Kirk, "The Conscience of the King", stardate 2818.9