ata_piix: Add Toshiba Satellite R20 and Tecra M6 to broken suspend list.

PATCH In review Peter Schwenke 2 participants 7 messages Jan 17, 2008 libata

lore

Share & tools

lore

Peter Schwenke

author

2008-01-17 03:30 UTC #0 lore raw

PATCH 1/1 ata_piix: Add Toshiba Satellite R20 and Tecra M6 to broken suspend list.

From: Peter Schwenke <[email protected]>

Add Toshiba Satellite R20 and Tecra M6 to broken suspend list. This is from OSDL bug 7780.

Signed-off-by Peter Schwenke <[email protected]>

---
 drivers/ata/ata_piix.c |   14 ++++++++++++++
 1 files changed, 14 insertions(+), 0 deletions(-)

drivers/ata/ata_piix.c +14 -0

index bb62a58..867a263 100644
@@ -988,6 +988,13 @@ static int piix_broken_suspend(void)
 			},
 		},
 		{
+			.ident = "TECRA M6",
+			.matches = {
+				DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
+				DMI_MATCH(DMI_PRODUCT_NAME, "TECRA M6"),
+			},
+		},
+		{
 			.ident = "TECRA M7",
 			.matches = {
 				DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),

@@ -1002,6 +1009,13 @@ static int piix_broken_suspend(void)
 			},
 		},
 		{
+			.ident = "Satellite R20",
+			.matches = {
+				DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
+				DMI_MATCH(DMI_PRODUCT_NAME, "Satellite R20"),
+			},
+		},
+		{
 			.ident = "Satellite R25",
 			.matches = {
 				DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),

Signature · 1 line

1.5.2.5

Tejun Heo

Acked-by on v1 1/1

2008-01-17 03:46 UTC #1 lore raw

Quoted 6 lines · Peter Schwenke

From: Peter Schwenke <[email protected]>
Add Toshiba Satellite R20 and Tecra M6 to broken suspend list. This is from OSDL bug 7780.
Signed-off-by Peter Schwenke <[email protected]>

Acked-by Tejun Heo <[email protected]>

If Toshiba is still doing this for their new products. We either need a better way to blacklist them or contact and tell them to stop what they're doing. Does anyone have a Toshiba contact?

Thanks.

Signature · 1 line

tejun

Peter Schwenke

author

2008-01-17 07:09 UTC #2 lore raw

Quoted 4 lines · Tejun Heo

If Toshiba is still doing this for their new products. We either need a better way to blacklist them or contact and tell them to stop what they're doing. Does anyone have a Toshiba contact?

I've been thinking the same thing. It appears that all their newer laptops are doing this - and they have a lot of models.

So we probably do need a better method of blacklisting them and also let Toshiba know.

I have found a contact for engineering at [email protected] from http://linux.toshiba-dme.co.jp/linux/eng/contact.htm.

I'm willing to send them some mail if nobody else wants to or they have an "inside" contact.

I also realised I didn't give attribution to Matt Piermarini for the M6
lines in my comment.

Signature · 1 line

                                                              ...Peter

Tejun Heo

2008-01-17 07:43 UTC #3 lore raw

Quoted 9 lines · Peter Schwenke

Quoted 4 lines · Tejun Heo
If Toshiba is still doing this for their new products. We either need a better way to blacklist them or contact and tell them to stop what they're doing. Does anyone have a Toshiba contact?
I've been thinking the same thing. It appears that all their newer laptops are doing this - and they have a lot of models.

Quoted 8 lines

So we probably do need a better method of blacklisting them and also let Toshiba know.
I have found a contact for engineering at [email protected] from http://linux.toshiba-dme.co.jp/linux/eng/contact.htm.
I'm willing to send them some mail if nobody else wants to or they have an "inside" contact.

Yes, please go ahead and cc me and Jeff.

Quoted 2 lines

I also realised I didn't give attribution to Matt Piermarini for the M6
lines in my comment.

Feel free to post updated version.

Thanks.

Signature · 1 line

tejun

Peter Schwenke

author

2008-01-17 13:08 UTC #4 lore raw

Quoted 10 lines

Quoted 7 lines · Peter Schwenke
Tejun Heo wrote:
I have found a contact for engineering at [email protected] from http://linux.toshiba-dme.co.jp/linux/eng/contact.htm.
I'm willing to send them some mail if nobody else wants to or they have an "inside" contact.
Yes, please go ahead and cc me and Jeff.

Will do.

Quoted 6 lines

Quoted 3 lines
I also realised I didn't give attribution to Matt Piermarini for the M6
lines in my comment.
Feel free to post updated version.

Thank you. Coming in the next message in this thread.

Signature · 2 lines

                                                              Regards
                                                              ...Peter

Peter Schwenke

author

2008-01-17 13:08 UTC #5 lore raw

In reply to Tejun Heo

From: Peter Schwenke <[email protected]>

Add Toshiba Satellite R20 and Tecra M6 to broken suspend list. Matt Piermarini reported and provided the M6 patch. This is from OSDL bug 7780.

Signed-off-by Peter Schwenke <[email protected]>

Cc Matt Piermarini <[email protected]>

---
 drivers/ata/ata_piix.c |   14 ++++++++++++++
 1 files changed, 14 insertions(+), 0 deletions(-)

drivers/ata/ata_piix.c +14 -0

index bb62a58..867a263 100644
@@ -988,6 +988,13 @@ static int piix_broken_suspend(void)
 			},
 		},
 		{
+			.ident = "TECRA M6",
+			.matches = {
+				DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
+				DMI_MATCH(DMI_PRODUCT_NAME, "TECRA M6"),
+			},
+		},
+		{
 			.ident = "TECRA M7",
 			.matches = {
 				DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),

@@ -1002,6 +1009,13 @@ static int piix_broken_suspend(void)
 			},
 		},
 		{
+			.ident = "Satellite R20",
+			.matches = {
+				DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
+				DMI_MATCH(DMI_PRODUCT_NAME, "Satellite R20"),
+			},
+		},
+		{
 			.ident = "Satellite R25",
 			.matches = {
 				DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),

Signature · 1 line

1.5.2.5

Tejun Heo

Acked-by

2008-01-17 14:54 UTC #6 lore raw

Quoted 7 lines · Peter Schwenke

From: Peter Schwenke <[email protected]>
Add Toshiba Satellite R20 and Tecra M6 to broken suspend list. Matt Piermarini reported and provided the M6 patch. This is from OSDL bug 7780.
Signed-off-by Peter Schwenke <[email protected]>
Cc Matt Piermarini <[email protected]>

Acked-by Tejun Heo <[email protected]>

Signature · 1 line

tejun