Skip to contentSkip to conversation

pcmcia: Remove CONFIG_COMMANDS from marubun pcmcia driver

PATCH New Nobuhiro Iwamatsu 3 participants 7 messages Jan 15, 2008 – Jan 18, 2008 Pcmcia

lore
Share & tools
lore

Nobuhiro Iwamatsu

author
#0 lore raw

PATCH 1/1 pcmcia: Remove CONFIG_COMMANDS from marubun pcmcia driver

Signed-off-by Nobuhiro Iwamatsu <[email protected]>
---
 drivers/pcmcia/marubun_pcmcia.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
drivers/pcmcia/marubun_pcmcia.c +4 -2
index 7b112af..2479a66 100644
@@ -25,11 +25,13 @@
 #include <pcmcia.h>
 #include <asm/io.h>
 
-#if	(CONFIG_COMMANDS & CFG_CMD_PCMCIA)
+#undef CONFIG_PCMCIA
+
+#if defined(CONFIG_CMD_PCMCIA)
 #define	CONFIG_PCMCIA
 #endif
 
-#if	(CONFIG_COMMANDS & CFG_CMD_IDE)
+#if	defined(CONFIG_CMD_IDE)
 #define	CONFIG_PCMCIA
 #endif
Signature · 1 line
1.5.3.7
#1 lore raw

PATCH 1/1 pcmcia: Remove CONFIG_COMMANDS from marubun pcmcia driver

Quoted 15 lines · Nobuhiro Iwamatsu
Signed-off-by Nobuhiro Iwamatsu <[email protected]>
---
 drivers/pcmcia/marubun_pcmcia.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
drivers/pcmcia/marubun_pcmcia.c +1 -1
index 7b112af..2479a66 100644
@@ -25,11 +25,13 @@
 #include <pcmcia.h>
 #include <asm/io.h>
 
-#if	(CONFIG_COMMANDS & CFG_CMD_PCMCIA)
+#undef CONFIG_PCMCIA

drivers/pcmcia/marubun_pcmcia.c line 37

Quoted 10 lines
drivers/pcmcia/marubun_pcmcia.c +3 -1
+
+#if defined(CONFIG_CMD_PCMCIA)
 #define	CONFIG_PCMCIA
 #endif
 
-#if	(CONFIG_COMMANDS & CFG_CMD_IDE)
+#if	defined(CONFIG_CMD_IDE)
 #define	CONFIG_PCMCIA
 #endif
Amen-brother-by Jon Loeliger <[email protected]>

Oh, and, a "git grep CONFIG_COMMANDS" reveals that there are a few other lingering instances of this bug around.

jdl

author
#2 lore raw

PATCH 1/1 pcmcia: Remove CONFIG_COMMANDS from marubun pcmcia driver

2008/1/16, Jon Loeliger <[email protected]>:

Quoted 30 lines · Nobuhiro Iwamatsu
Quoted 15 lines
Signed-off-by Nobuhiro Iwamatsu <[email protected]>
---
 drivers/pcmcia/marubun_pcmcia.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
drivers/pcmcia/marubun_pcmcia.c +1 -1
index 7b112af..2479a66 100644
@@ -25,11 +25,13 @@
 #include <pcmcia.h>
 #include <asm/io.h>
 
-#if  (CONFIG_COMMANDS & CFG_CMD_PCMCIA)
+#undef CONFIG_PCMCIA

drivers/pcmcia/marubun_pcmcia.c line 37

Quoted 10 lines
drivers/pcmcia/marubun_pcmcia.c +3 -1
+
+#if defined(CONFIG_CMD_PCMCIA)
 #define      CONFIG_PCMCIA
 #endif
 
-#if  (CONFIG_COMMANDS & CFG_CMD_IDE)
+#if  defined(CONFIG_CMD_IDE)
 #define      CONFIG_PCMCIA
 #endif
Amen-brother-by Jon Loeliger <[email protected]>
Quoted 2 lines

Oh, and, a "git grep CONFIG_COMMANDS" reveals that there are a few other lingering instances of this bug around.

Thank you for your comment.
# I have not understood "Amen-brother-by" first.

I found an mistake in my tree based on your point.

Thanks
Nobuhiro

#3 lore raw

PATCH 1/1 pcmcia: Remove CONFIG_COMMANDS from marubun pcmcia driver

Quoted 11 lines · Nobuhiro Iwamatsu

2008/1/16, Jon Loeliger <[email protected]>:

Quoted 10 lines · Nobuhiro Iwamatsu
Quoted 9 lines
Signed-off-by Nobuhiro Iwamatsu <[email protected]>
---
 drivers/pcmcia/marubun_pcmcia.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
drivers/pcmcia/marubun_pcmcia.c +0 -0
index 7b112af..2479a66 100644
Quoted 8 lines
Quoted 5 lines
Amen-brother-by Jon Loeliger <[email protected]>

Oh, and, a "git grep CONFIG_COMMANDS" reveals that there are a few other lingering instances of this bug around.

Thank you for your comment.
# I have not understood "Amen-brother-by" first.

Sorry. It means "I _totally_ agree with this patch." The religious word "Amen" means "Let it be" or "So be it". By adding "Brother" to it, it makes it familiar, and connotes charismatic religious fervor. We should _all_ violently agree with this patch. :-)

Quoted 1 line

I found an mistake in my tree based on your point.

Atarashi pachi hoshii!

Fair is fair :-)

Quoted 2 lines

Thanks
Nobuhiro

Thanks,
jdl

#4 lore raw

PATCH 1/1 pcmcia: Remove CONFIG_COMMANDS from marubun pcmcia driver

Jon Loeliger wrote:
<snip>

Quoted 7 lines

Sorry. It means "I _totally_ agree with this patch." The religious word "Amen" means "Let it be" or "So be it". By adding "Brother" to it, it makes it familiar, and connotes charismatic religious fervor. We should _all_ violently agree with this patch. :-)

Nothing like a violent 'amen' first thing in the morning!

B-)

author
#5 lore raw

PATCH 1/1 pcmcia: Remove CONFIG_COMMANDS from marubun pcmcia driver

In reply to Jon Loeliger
Quoted 11 lines · On Thu, 17 Jan 2008 08:50:05 -0600 Jon Loeliger <[email protected]> wrote:
Quoted 5 lines
Quoted 2 lines

Oh, and, a "git grep CONFIG_COMMANDS" reveals that there are a few other lingering instances of this bug around.

Thank you for your comment.
# I have not understood "Amen-brother-by" first.

Sorry. It means "I _totally_ agree with this patch." The religious word "Amen" means "Let it be" or "So be it". By adding "Brother" to it, it makes it familiar, and connotes charismatic religious fervor. We should _all_ violently agree with this patch. :-)

Thank you for explaining. It is a good lesson for me.

Quoted 4 lines
Quoted 2 lines

I found an mistake in my tree based on your point.

Atarashi pachi hoshii!

:-)
I sent patch that fix CONFIG_COMMANDS problem yesterday.

regards,
Nobuhiro

Signature · 1 line
Nobuhiro Iwamatsu
#6 lore raw

PATCH 1/1 pcmcia: Remove CONFIG_COMMANDS from marubun pcmcia driver

Quoted 2 lines · Nobuhiro Iwamatsu
Quoted 1 line

We should _all_ violently agree with this patch. :-)

Thank you for explaining. It is a good lesson for me.

No problem.

Quoted 3 lines
Quoted 1 line

Atarashi pachi hoshii!

:-)
I sent patch that fix CONFIG_COMMANDS problem yesterday.

I saw that. Thanks!

jdl