rock-5b-plus: add
PATCH 1/1 rock-5b-plus: add
The Radxa ROCK 5B+ is an RK3588-based single-board computer and a successor to the ROCK 5B. It features LPDDR5 memory, onboard Wi-Fi 6, Bluetooth 5.2, dual M.2 M-Key connectors and 2.5 Gigabit Ethernet.
Product Page:
https://radxa.com/products/rock5/5b-plus/
Documentation page:
https://docs.radxa.com/en/rock5/rock5b
Specs:
- Rockchip RK3588
- Quad-Core Arm Cortex-A76 @ 2.4GHz
- Quad-Core Arm Cortex-A55 @ 1.8GHz
- Arm Mali-G610 MP4 GPU
- OpenGL ES 1.1/2.0/3.2
- OpenCL 1.1/1.2/2.2
- Vulkan 1.2
- 6 TOPS neural processing unit
- LPDDR5 RAM (4/8/16/32 GB)
- Onboard eMMC socket
- 2x M.2 M-Key connectors supporting NVMe SSDs
- 1x M.2 E-Key connector
- 1x MicroSD card slot
- 2x HDMI outputs
- 1x HDMI input
- 1x DisplayPort over USB Type-C
- 2x MIPI DSI
- 2x MIPI CSI
- Wi-Fi 6 and Bluetooth 5.2 with BLE
- 1x 2.5 Gigabit Ethernet
- 2x USB 3.0 HOST ports
- 2x USB 2.0 HOST ports
- 1x 4-ring 3.5mm audio jack
- 40-pin GPIO header with UART, SPI, I2C, I2S, PWM and GPIO
- USB Type-C power input
--- README | 1 + conf/machine/rock-5b-plus.conf | 11 +++++++++++ recipes-kernel/linux/linux-rockchip.inc | 1 + 3 files changed, 13 insertions(+) create mode 100644 conf/machine/rock-5b-plus.conf
README +1 -0
@@ -41,6 +41,7 @@ Status of supported boards: rock-4c-plus rock-5a rock-5b + rock-5b-plus rock-pi-4a rock-pi-4b rock-pi-4b-plus
conf/machine/rock-5b-plus.conf new file +11 -0
@@ -0,0 +1,11 @@ +#@TYPE: Machine +#@NAME: Radxa Rock 5B plus +#@DESCRIPTION: ROCK5 is the 5th generation of SBC designed by Radxa. +#https://docs.radxa.com/en/rock5/rock5b + +require conf/machine/include/rk3588.inc + +KERNEL_DEVICETREE = "rockchip/rk3588-rock-5b-plus.dtb" +MACHINE_EXTRA_RRECOMMENDS += "kernel-modules" + +UBOOT_MACHINE = "rock5b-rk3588_defconfig"
recipes-kernel/linux/linux-rockchip.inc +1 -0
@@ -25,6 +25,7 @@ COMPATIBLE_MACHINE:rock-3a = "rock-3a" COMPATIBLE_MACHINE:rock-4c-plus = "rock-4c-plus" COMPATIBLE_MACHINE:rock-5a = "rock-5a" COMPATIBLE_MACHINE:rock-5b = "rock-5b" +COMPATIBLE_MACHINE:rock-5b-plus = "rock-5b-plus" COMPATIBLE_MACHINE:rock-pi-4 = "rock-pi-4" COMPATIBLE_MACHINE:rock-pi-e = "rock-pi-e" COMPATIBLE_MACHINE:rock-pi-s = "rock-pi-s"
Signature · 1 line
2.34.1
Hi Vinay,
Thanks for the patch!
Quoted 82 lines · Vinay Patil via lists.yoctoproject.org
[You don't often get email from [email protected]. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
The Radxa ROCK 5B+ is an RK3588-based single-board computer and a successor to the ROCK 5B. It features LPDDR5 memory, onboard Wi-Fi 6, Bluetooth 5.2, dual M.2 M-Key connectors and 2.5 Gigabit Ethernet.
Product Page:
https://radxa.com/products/rock5/5b-plus/Documentation page:
https://docs.radxa.com/en/rock5/rock5bSpecs:
- Rockchip RK3588
- Quad-Core Arm Cortex-A76 @ 2.4GHz
- Quad-Core Arm Cortex-A55 @ 1.8GHz
- Arm Mali-G610 MP4 GPU
- OpenGL ES 1.1/2.0/3.2
- OpenCL 1.1/1.2/2.2
- Vulkan 1.2
- 6 TOPS neural processing unit
- LPDDR5 RAM (4/8/16/32 GB)
- Onboard eMMC socket
- 2x M.2 M-Key connectors supporting NVMe SSDs
- 1x M.2 E-Key connector
- 1x MicroSD card slot
- 2x HDMI outputs
- 1x HDMI input
- 1x DisplayPort over USB Type-C
- 2x MIPI DSI
- 2x MIPI CSI
- Wi-Fi 6 and Bluetooth 5.2 with BLE
- 1x 2.5 Gigabit Ethernet
- 2x USB 3.0 HOST ports
- 2x USB 2.0 HOST ports
- 1x 4-ring 3.5mm audio jack
- 40-pin GPIO header with UART, SPI, I2C, I2S, PWM and GPIO
- USB Type-C power inputSigned-off-by Vinay Patil <[email protected]>--- README | 1 + conf/machine/rock-5b-plus.conf | 11 +++++++++++ recipes-kernel/linux/linux-rockchip.inc | 1 + 3 files changed, 13 insertions(+)create mode 100644
conf/machine/rock-5b-plus.confREADME +1
-0@@ -41,6 +41,7 @@ Status of supported boards: rock-4c-plus rock-5a rock-5b + rock-5b-plus rock-pi-4a rock-pi-4b rock-pi-4b-plusconf/machine/rock-5b-plus.conf new file +11
-0@@ -0,0 +1,11 @@ +#@TYPE: Machine +#@NAME: Radxa Rock 5B plus +#@DESCRIPTION: ROCK5 is the 5th generation of SBC designed by Radxa. +#https://docs.radxa.com/en/rock5/rock5b + +require conf/machine/include/rk3588.inc + +KERNEL_DEVICETREE = "rockchip/rk3588-rock-5b-plus.dtb" +MACHINE_EXTRA_RRECOMMENDS += "kernel-modules" + +UBOOT_MACHINE = "rock5b-rk3588_defconfig"recipes-kernel/linux/linux-rockchip.inc +0
-0
recipes-kernel/linux/linux-rockchip.inc COMPATIBLE_MACHINE:rock-3a = "rock-3a" · line 31
Quoted 7 lines
recipes-kernel/linux/linux-rockchip.inc +1
-0@@ -25,6 +25,7 @@ COMPATIBLE_MACHINE:rock-3a = "rock-3a" COMPATIBLE_MACHINE:rock-4c-plus = "rock-4c-plus" COMPATIBLE_MACHINE:rock-5a = "rock-5a" COMPATIBLE_MACHINE:rock-5b = "rock-5b" +COMPATIBLE_MACHINE:rock-5b-plus = "rock-5b-plus" COMPATIBLE_MACHINE:rock-pi-4 = "rock-pi-4" COMPATIBLE_MACHINE:rock-pi-e = "rock-pi-e" COMPATIBLE_MACHINE:rock-pi-s = "rock-pi-s"
This is unnecessary as U-Boot can detect whether it's running on a Rock 5B, Rock 5B+ or even Rock 5T and select the appropriate device tree to use with the Linux kernel. What's important then is that this device tree is available to U-Boot, which it isn't at the moment.
I would recommend to instead advertise support for the Rock 5B+ (and Rock 5T) in the README via the rock-5b machine and in the conf/machine/rock-5b.conf at the top of the file, and then simply add the Rock 5B+ and Rock 5T device trees to KERNEL_DEVICETREE in that machine conf file, see board_models in board/radxa/rock5b-rk3588/rock5b-rk3588.c in U-Boot for reference.
This will avoid increasing the number of machines to build for to validate meta-rockchip still works as expected (I believe Trevor does that every now and then).
Cheers,
Quentin