Skip to contentSkip to conversation

change comment in read_swap_cache_async

PATCH In review Tomohiro Kusumi 2 participants 2 messages Jan 28, 2008

Subsystems (2)
Memory management MM swap
lore
Share & tools
lore

Tomohiro Kusumi

author
#0 lore raw

PATCH 1/1 change comment in read_swap_cache_async

Hi

The function try_to_swap_out seems to have been removed in 2.5 era. So shouldn't the following comment get changed ?

Tomohiro Kusumi

Signed-off-by Tomohiro Kusumi <[email protected]>
mm/swap_state.c +2 -2
diff -Nurp linux-2.6.24.org/mm/swap_state.c linux-2.6.24/mm/swap_state.c
@@ -349,8 +349,8 @@ struct page *read_swap_cache_async(swp_e
 		 * our caller observed it.  May fail (-EEXIST) if there
 		 * is already a page associated with this entry in the
 		 * swap cache: added by a racing read_swap_cache_async,
-		 * or by try_to_swap_out (or shmem_writepage) re-using
-		 * the just freed swap entry for an existing page.
+		 * or by shmem_writepage re-using the just freed swap
+		 * entry for an existing page.
 		 * May fail (-ENOMEM) if radix-tree node allocation failed.
 		 */
 		err = add_to_swap_cache(new_page, entry);

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

#1 lore raw
Quoted 3 lines · Tomohiro Kusumi

The function try_to_swap_out seems to have been removed in 2.5 era. So shouldn't the following comment get changed ?

You're right, that's wrong, it should be referring to add_to_swap instead - thank you. But by coincidence there's already a patch in Andrew's -mm tree which corrects that comment: should get into 2.6.25-rc in a couple of weeks.

Hugh

Quoted 21 lines

Tomohiro Kusumi

Signed-off-by Tomohiro Kusumi <[email protected]>

diff -Nurp linux-2.6.24.org/mm/swap_state.c linux-2.6.24/mm/swap_state.c

mm/swap_state.c +2 -3
@@ -349,8 +349,8 @@ struct page *read_swap_cache_async(swp_e
 		 * our caller observed it.  May fail (-EEXIST) if there
 		 * is already a page associated with this entry in the
 		 * swap cache: added by a racing read_swap_cache_async,
-		 * or by try_to_swap_out (or shmem_writepage) re-using
-		 * the just freed swap entry for an existing page.
+		 * or by shmem_writepage re-using the just freed swap
+		 * entry for an existing page.
 		 * May fail (-ENOMEM) if radix-tree node allocation failed.
 		 */
 		err = add_to_swap_cache(new_page, entry);
 
 
--
Quoted 5 lines

To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>