Skip to contentSkip to conversation

[] Test opcode, not definition in type_check(), drivers/scsi/aic7xxx/aicasm/aicasm_gram.y

PATCH In review Roel Kluin 2 participants 2 messages Jan 28, 2008 – Jan 29, 2008

Subsystems (2)
SCSI AIC7XXX / AIC79XX SCSI driver
lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 [] Test opcode, not definition in type_check(), drivers/scsi/aic7xxx/aicasm/aicasm_gram.y

drivers/scsi/aic7xxx_old/sequencer.h:130:#define AIC_OP_JZ 0xf --
Test opcode, not definition

Signed-off-by Roel Kluin <[email protected]>

---

drivers/scsi/aic7xxx/aicasm/aicasm_gram.y +1 -1
index 6066998..702e2db 100644
@@ -1837,7 +1837,7 @@ type_check(symbol_t *symbol, expression_t *expression, int opcode)
 	int and_op;
 
 	and_op = FALSE;
-	if (opcode == AIC_OP_AND || opcode == AIC_OP_JNZ || AIC_OP_JZ)
+	if (opcode == AIC_OP_AND || opcode == AIC_OP_JNZ || opcode == AIC_OP_JZ)
 		and_op = TRUE;
 
 	/*
#1 lore raw
Quoted 5 lines · Roel Kluin

drivers/scsi/aic7xxx_old/sequencer.h:130:#define AIC_OP_JZ 0xf --
Test opcode, not definition

Signed-off-by Roel Kluin <[email protected]>
Signed-off-by Hannes Reinecke <[email protected]>
Quoted 6 lines

---

drivers/scsi/aic7xxx/aicasm/aicasm_gram.y +0 -0
index 6066998..702e2db 100644

drivers/scsi/aic7xxx/aicasm/aicasm_gram.y type_check(symbol_t *symbol, expression_t *expression, int opcode) · line 1843

Quoted 8 lines
drivers/scsi/aic7xxx/aicasm/aicasm_gram.y +1 -1
@@ -1837,7 +1837,7 @@ type_check(symbol_t *symbol, expression_t *expression, int opcode)
 	int and_op;
 
 	and_op = FALSE;
-	if (opcode == AIC_OP_AND || opcode == AIC_OP_JNZ || AIC_OP_JZ)
+	if (opcode == AIC_OP_AND || opcode == AIC_OP_JNZ || opcode == AIC_OP_JZ)
 		and_op = TRUE;
 
 	/*

Cheers,

Hannes

Signature · 8 lines
Dr. Hannes Reinecke		      zSeries & Storage
[email protected]			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html