Skip to contentSkip to conversation

replace logical- by bit-and in alc_subsystem_id(), sound/pci/hda/patch_realtek.c

PATCH In review Roel Kluin 2 participants 2 messages Jan 28, 2008 Sound

lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 replace logical- by bit-and in alc_subsystem_id(), sound/pci/hda/patch_realtek.c

This was found in linus' git tree, am I right here? --
replace logical- by bit-and

Signed-off-by Roel Kluin <[email protected]>

---

sound/pci/hda/patch_realtek.c +1 -1
index 1c50278..0a13c53 100644
@@ -739,7 +739,7 @@ static void alc_subsystem_id(struct hda_codec *codec,
 	/* check sum */
 	tmp = 0;
 	for (i = 1; i < 16; i++) {
-		if ((ass >> i) && 1)
+		if ((ass >> i) & 1)
 			tmp++;
 	}
 	if (((ass >> 16) & 0xf) != tmp)
#1 lore raw

At Mon, 28 Jan 2008 14:35:39 +0100,

Quoted 6 lines · Roel Kluin

This was found in linus' git tree, am I right here? --
replace logical- by bit-and

Signed-off-by Roel Kluin <[email protected]>

Already fixed on ALSA tree.

thanks,

Takashi

Quoted 15 lines

---

sound/pci/hda/patch_realtek.c +1 -1
index 1c50278..0a13c53 100644
@@ -739,7 +739,7 @@ static void alc_subsystem_id(struct hda_codec *codec,
 	/* check sum */
 	tmp = 0;
 	for (i = 1; i < 16; i++) {
-		if ((ass >> i) && 1)
+		if ((ass >> i) & 1)
 			tmp++;
 	}
 	if (((ass >> 16) & 0xf) != tmp)