Skip to contentSkip to conversation

ata_piix: IDE mode SATA patch for Intel ICH10 DeviceID's

PATCH In review Jason Gaston 2 participants 3 messages Jan 29, 2008 libata

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ata_piix: IDE mode SATA patch for Intel ICH10 DeviceID's

This patch adds the Intel ICH10 IDE mode SATA Controller DeviceID's.

drivers/ata/ata_piix.c renamed from drivers/ata/ata_piix.c.orig +8 -0
@@ -263,6 +263,14 @@
 	{ 0x8086, 0x292e, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_sata_ahci },
 	/* SATA Controller IDE (Tolapai) */
 	{ 0x8086, 0x5028, PCI_ANY_ID, PCI_ANY_ID, 0, 0, tolapai_sata_ahci },
+	/* SATA Controller IDE (ICH10) */
+	{ 0x8086, 0x3a00, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_sata_ahci },
+	/* SATA Controller IDE (ICH10) */
+	{ 0x8086, 0x3a06, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_2port_sata },
+	/* SATA Controller IDE (ICH10) */
+	{ 0x8086, 0x3a20, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_sata_ahci },
+	/* SATA Controller IDE (ICH10) */
+	{ 0x8086, 0x3a26, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_2port_sata },
 
 	{ }	/* terminate list */
 };
#1 lore raw
Quoted 8 lines · Jason Gaston

This patch adds the Intel ICH10 IDE mode SATA Controller DeviceID's.

drivers/ata/ata_piix.c renamed from drivers/ata/ata_piix.c.orig +0 -0
@@ -263,6 +263,14 @@
 	{ 0x8086, 0x292e, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_sata_ahci },

drivers/ata/ata_piix.c line 273

Quoted 10 lines
drivers/ata/ata_piix.c renamed from drivers/ata/ata_piix.c.orig +8 -0
 	/* SATA Controller IDE (Tolapai) */
 	{ 0x8086, 0x5028, PCI_ANY_ID, PCI_ANY_ID, 0, 0, tolapai_sata_ahci },
+	/* SATA Controller IDE (ICH10) */
+	{ 0x8086, 0x3a00, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_sata_ahci },
+	/* SATA Controller IDE (ICH10) */
+	{ 0x8086, 0x3a06, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_2port_sata },
+	/* SATA Controller IDE (ICH10) */
+	{ 0x8086, 0x3a20, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_sata_ahci },
+	/* SATA Controller IDE (ICH10) */
+	{ 0x8086, 0x3a26, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_2port_sata },

can these do AHCI mode without losing any PATA ports?

if so, I would prefer to always drive the hardware in AHCI mode, if it is capable of doing so.

#2 lore raw
Quoted 7 lines

-----Original Message-----
From: Jeff Garzik [mailto:[email protected]]
Sent: Tuesday, January 29, 2008 9:14 AM
To: Gaston, Jason D
Cc: [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH 2.6.24] ata_piix: IDE mode SATA patch for Intel

ICH10

Quoted 10 lines

DeviceID's

Quoted 5 lines · Jason Gaston

This patch adds the Intel ICH10 IDE mode SATA Controller DeviceID's.

--- linux-2.6.24/drivers/ata/ata_piix.c.orig 2008-01-24

14:58:37.000000000 -0800

Quoted 1 line

+++ linux-2.6.24/drivers/ata/ata_piix.c 2008-01-28

14:58:22.000000000 -

Quoted 3 lines

0800

Review line 263

Quoted 2 lines
(quoted diff) +0 -0
@@ -263,6 +263,14 @@
 	{ 0x8086, 0x292e, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_sata_ahci

},

Quoted 2 lines

Review line 265

Quoted 2 lines
(quoted diff) +0 -0
 	/* SATA Controller IDE (Tolapai) */
 	{ 0x8086, 0x5028, PCI_ANY_ID, PCI_ANY_ID, 0, 0,

tolapai_sata_ahci },

Quoted 2 lines

Review line 267

Quoted 2 lines
(quoted diff) +2 -0
+	/* SATA Controller IDE (ICH10) */
+	{ 0x8086, 0x3a00, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_sata_ahci

},

Quoted 2 lines

Review line 269

Quoted 2 lines
(quoted diff) +2 -0
+	/* SATA Controller IDE (ICH10) */
+	{ 0x8086, 0x3a06, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_2port_sata

},

Quoted 2 lines

Review line 271

Quoted 2 lines
(quoted diff) +2 -0
+	/* SATA Controller IDE (ICH10) */
+	{ 0x8086, 0x3a20, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_sata_ahci

},

Quoted 2 lines

Review line 273

Quoted 2 lines
(quoted diff) +2 -0
+	/* SATA Controller IDE (ICH10) */
+	{ 0x8086, 0x3a26, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_2port_sata

},

Quoted 5 lines

can these do AHCI mode without losing any PATA ports?

if so, I would prefer to always drive the hardware in AHCI mode, if it is capable of doing so.

They do not have PATA.

Jason