add kernel-module-loop to roofs for collie and tosa
RFC 1/1 add kernel-module-loop to roofs for collie and tosa
altboot-console-image needs loopback file support either in the kernel or as kernel module. CONFIG_BLK_DEV_LOOP=m were set for both collie and tosa. Other Z deviced has loopback file support built into the kernel. I would propose the following change [both dev and stable] to pack kernel-module-loop into the default rootfs for collie and tosa; and bump PR for task-base.
============================================================
machine/collie.conf +2 -0
@@ -14,5 +14,7 @@ IMAGE_FSTYPES ?= "jffs2 tar.gz" IMAGE_LINGUAS = "" IMAGE_FSTYPES ?= "jffs2 tar.gz" +MACHINE_EXTRA_RRECOMMENDS += "kernel-module-loop" + ROOT_FLASH_SIZE = "14" # actually 14680064, see EXTRA_IMAGECMD above
============================================================
machine/tosa.conf +1 -1
@@ -7,6 +7,6 @@ IMAGE_FSTYPES ?= "jffs2" IMAGE_FSTYPES ?= "jffs2" # wlan-ng Modules -MACHINE_EXTRA_RRECOMMENDS += "wlan-ng-modules-usb" +MACHINE_EXTRA_RRECOMMENDS += "wlan-ng-modules-usb kernel-module-loop" ROOT_FLASH_SIZE = "28"
Regards
Gordon
Quoted 2 lines · Junqian Gordon Xu
altboot-console-image needs loopback file support either in the kernel or as kernel module.
It is not 'altboot-console-image' which needs it but altboot.
Quoted 2 lines
CONFIG_BLK_DEV_LOOP=mwere set for both collie and tosa. Other Z deviced has loopback file support built into the kernel.
Probably not for long as kernel size increase with each version ;(
Quoted 3 lines
I would propose the following change [both dev and stable] to pack kernel-module-loop into the default rootfs for collie and tosa; and bump PR for task-base.
As altboot needs it then it has to be added as RRECOMMENDS to altboot recipe rather.
Signature · 5 lines
JID: hrw-jabber.org
OpenEmbedded developer/consultant
We're here to give you a computer, not a religion.
-- Bob Pariseau, at the introduction of the AmigaQuoted 5 lines · Marcin Juszkiewicz
Quoted 2 lines · Junqian Gordon Xu
altboot-console-image needs loopback file support either in the kernel or as kernel module.
It is not 'altboot-console-image' which needs it but altboot.
You are right, but practically it's not nice to have users to go find kernel-module-loop before they can install roofs as a loopback image at SD/CF. For tosa, the typical case is to install altboot-console-image first then use altboot to install another image.
Quoted 4 lines
Quoted 2 lines
CONFIG_BLK_DEV_LOOP=mwere set for both collie and tosa. Other Z deviced has loopback file support built into the kernel.Probably not for long as kernel size increase with each version ;(
We can set it as module for all devices, sooner or later.
Quoted 4 lines
Quoted 2 lines
I would propose the following change [both dev and stable] to pack kernel-module-loop into the default rootfs for collie and tosa; and bump PR for task-base.
As altboot needs it then it has to be added as RRECOMMENDS to altboot recipe rather.
The point is to have it available with altboot at the very beginning. Although it's not techinically RDEPENDS, should we set it as RDEPENDS to altboot recipe?
Regards
Gordon
Quoted 11 lines · Junqian Gordon Xu
Quoted 5 lines · Marcin Juszkiewicz
Quoted 2 lines · Junqian Gordon Xu
altboot-console-image needs loopback file support either in the kernel or as kernel module.
It is not 'altboot-console-image' which needs it but altboot.
You are right, but practically it's not nice to have users to go find kernel-module-loop before they can install roofs as a loopback image at SD/CF. For tosa, the typical case is to install altboot-console-image first then use altboot to install another image.
Users does not have to go and find it. OE will take care of it and installing altboot into image will also adds kernel-module-loop package. Thats how dependencies works.
Quoted 10 lines
Quoted 6 lines
Quoted 3 lines
I would propose the following change [both dev and stable] to pack kernel-module-loop into the default rootfs for collie and tosa; and bump PR for task-base.
As altboot needs it then it has to be added as RRECOMMENDS to altboot recipe rather.
The point is to have it available with altboot at the very beginning. Although it's not techinically RDEPENDS, should we set it as RDEPENDS to altboot recipe?
RRECOMMENDS is proper for kernel modules as it does not break if package is not available (which is a case when loop is in kernel not module).
Signature · 5 lines
JID: hrw-jabber.org
OpenEmbedded developer/consultant
It is your destiny.
-- Darth VaderQuoted 5 lines · Marcin Juszkiewicz
Users does not have to go and find it. OE will take care of it and installing altboot into image will also adds kernel-module-loop package. Thats how dependencies works.
RRECOMMENDS is proper for kernel modules as it does not break if package is not available (which is a case when loop is in kernel not module).
Thanks. If CoreDump doesn't object, I will add kernel-module-loop as an RRECOMMENDS to altboot recipies.
Regards
Gordon
Quoted 31 lines · Junqian Gordon Xu
altboot-console-image needs loopback file support either in the kernel or as kernel module.
CONFIG_BLK_DEV_LOOP=mwere set for both collie and tosa. Other Z deviced has loopback file support built into the kernel. I would propose the following change [both dev and stable] to pack kernel-module-loop into the default rootfs for collie and tosa; and bump PR for task-base.============================================================
machine/collie.conf +2
-0@@ -14,5 +14,7 @@ IMAGE_FSTYPES ?= "jffs2 tar.gz" IMAGE_LINGUAS = "" IMAGE_FSTYPES ?= "jffs2 tar.gz" +MACHINE_EXTRA_RRECOMMENDS += "kernel-module-loop" + ROOT_FLASH_SIZE = "14" # actually 14680064, see EXTRA_IMAGECMD above============================================================
machine/tosa.conf +1
-1@@ -7,6 +7,6 @@ IMAGE_FSTYPES ?= "jffs2" IMAGE_FSTYPES ?= "jffs2" # wlan-ng Modules -MACHINE_EXTRA_RRECOMMENDS += "wlan-ng-modules-usb" +MACHINE_EXTRA_RRECOMMENDS += "wlan-ng-modules-usb kernel-module-loop" ROOT_FLASH_SIZE = "28"
Quoted 8 lines
Regards
Gordon_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Wouldn't it be better do make altboot depend on kernel-modules-loop?