Skip to contentSkip to conversation

linux-2.6.24 compile error in drivers/net/b44.c

DISCUSSION Li Zefan 2 participants 5 messages Feb 2, 2008 – Feb 3, 2008

Subsystems (2)
lore
Share & tools
lore

Li Zefan

author
#0 lore raw

drivers/net/b44.c: In function 'b44_remove_one':
drivers/net/b44.c:2231: error: implicit declaration of function 'ssb_pcihost_set_power_state' make[2]: *** [drivers/net/b44.o] Error 1
make[1]: *** [drivers/net] Error 2

I think it is caused by:

CONFIG_SSB_PCIHOST=n
CONFIG_B44=y

author
#1 lore raw

Add CCs:

Quoted 10 lines · Li Zefan

drivers/net/b44.c: In function 'b44_remove_one':
drivers/net/b44.c:2231: error: implicit declaration of function 'ssb_pcihost_set_power_state' make[2]: *** [drivers/net/b44.o] Error 1
make[1]: *** [drivers/net] Error 2

I think it is caused by:

CONFIG_SSB_PCIHOST=n
CONFIG_B44=y

#2 lore raw
Quoted 19 lines · Li Zefan

Add CCs:

Quoted 10 lines · Li Zefan

drivers/net/b44.c: In function 'b44_remove_one':
drivers/net/b44.c:2231: error: implicit declaration of function 'ssb_pcihost_set_power_state' make[2]: *** [drivers/net/b44.o] Error 1
make[1]: *** [drivers/net] Error 2

I think it is caused by:

CONFIG_SSB_PCIHOST=n
CONFIG_B44=y

Quoted 5 lines

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

This patch should fix b44 errors when 'SSB_PCIHOST' is not enabled.

drivers/net/b44.c +4 -0
index ea2a2b5..d081234 100644
@@ -2228,7 +2228,9 @@ static void __devexit b44_remove_one(struct ssb_device *sdev)
 	unregister_netdev(dev);
 	ssb_bus_may_powerdown(sdev->bus);
 	free_netdev(dev);
+#ifdef B44_PCI
 	ssb_pcihost_set_power_state(sdev, PCI_D3hot);
+#endif
 	ssb_set_drvdata(sdev, NULL);
 }
 
@@ -2257,7 +2259,9 @@ static int b44_suspend(struct ssb_device *sdev, pm_message_t state)
 		b44_setup_wol(bp);
 	}
 
+#ifdef B44_PCI
 	ssb_pcihost_set_power_state(sdev, PCI_D3hot);
+#endif
 	return 0;
 }
 

--
Miguel Botón

author
#3 lore raw
Quoted 13 lines · Miguel Botón
Quoted 12 lines · Li Zefan

Add CCs:

Quoted 5 lines · Li Zefan

drivers/net/b44.c: In function 'b44_remove_one':
drivers/net/b44.c:2231: error: implicit declaration of function 'ssb_pcihost_set_power_state' make[2]: *** [drivers/net/b44.o] Error 1
make[1]: *** [drivers/net] Error 2

Quoted 9 lines
Quoted 6 lines
Quoted 5 lines

I think it is caused by:

CONFIG_SSB_PCIHOST=n
CONFIG_B44=y

This patch should fix b44 errors when 'SSB_PCIHOST' is not enabled.

I tried the patch, but it does't work, same compile error. :(

If .config is needed, tell me and I will attach it.

Quoted 30 lines
drivers/net/b44.c +4 -1
index ea2a2b5..d081234 100644
@@ -2228,7 +2228,9 @@ static void __devexit b44_remove_one(struct ssb_device *sdev)
 	unregister_netdev(dev);
 	ssb_bus_may_powerdown(sdev->bus);
 	free_netdev(dev);
+#ifdef B44_PCI
 	ssb_pcihost_set_power_state(sdev, PCI_D3hot);
+#endif
 	ssb_set_drvdata(sdev, NULL);
 }
 
@@ -2257,7 +2259,9 @@ static int b44_suspend(struct ssb_device *sdev, pm_message_t state)
 		b44_setup_wol(bp);
 	}
 
+#ifdef B44_PCI
 	ssb_pcihost_set_power_state(sdev, PCI_D3hot);
+#endif
 	return 0;
 }
 
--

Miguel Botón

author
#4 lore raw
Quoted 19 lines · Li Zefan
Quoted 18 lines · Miguel Botón
Quoted 17 lines · Li Zefan

Add CCs:

Quoted 10 lines · Li Zefan

drivers/net/b44.c: In function 'b44_remove_one':
drivers/net/b44.c:2231: error: implicit declaration of function 'ssb_pcihost_set_power_state' make[2]: *** [drivers/net/b44.o] Error 1
make[1]: *** [drivers/net] Error 2

I think it is caused by:

CONFIG_SSB_PCIHOST=n
CONFIG_B44=y

Quoted 7 lines
Quoted 2 lines

This patch should fix b44 errors when 'SSB_PCIHOST' is not enabled.

I tried the patch, but it does't work, same compile error. :(

If .config is needed, tell me and I will attach it.

Sorry, I just made a mistake, actually the patch works.

Thanks!

Quoted 32 lines
Quoted 30 lines
drivers/net/b44.c +4 -1
index ea2a2b5..d081234 100644
@@ -2228,7 +2228,9 @@ static void __devexit b44_remove_one(struct ssb_device *sdev)
 	unregister_netdev(dev);
 	ssb_bus_may_powerdown(sdev->bus);
 	free_netdev(dev);
+#ifdef B44_PCI
 	ssb_pcihost_set_power_state(sdev, PCI_D3hot);
+#endif
 	ssb_set_drvdata(sdev, NULL);
 }
 
@@ -2257,7 +2259,9 @@ static int b44_suspend(struct ssb_device *sdev, pm_message_t state)
 		b44_setup_wol(bp);
 	}
 
+#ifdef B44_PCI
 	ssb_pcihost_set_power_state(sdev, PCI_D3hot);
+#endif
 	return 0;
 }
 
--

Miguel Botón