xircom_cb should return NETDEV_TX_BUSY when there are no descriptors available
Subsystems (2)
PATCH 1/1 xircom_cb should return NETDEV_TX_BUSY when there are no descriptors available
Hi,
Changes in other networking paths uncovered a bug in the xircom_cb driver which made the kernel spew lots of the following error messages:
BUG eth1 code -5 qlen 0
It turned out that the driver returned -EIO when there was no descriptor available for sending packets. It should return NETDEV_TX_BUSY instead. This was discussed on the netdev list before, see http://thread.gmane.org/gmane.linux.network/84603 .
drivers/net/tulip/xircom_cb.c +1 -1
@@ -441,7 +441,7 @@ static int xircom_start_xmit(struct sk_buff *skb, struct net_device *dev)spin_unlock_irqrestore (&card->lock,flags);trigger_transmit (card); -return -EIO ; +return NETDEV_TX_BUSY ; }
Quoted 11 lines · Erik Mouw
Changes in other networking paths uncovered a bug in the
xircom_cbdriver which made the kernel spew lots of the following error messages:BUG eth1 code -5 qlen 0
It turned out that the driver returned
-EIOwhen there was no descriptor available for sending packets. It should returnNETDEV_TX_BUSYinstead. This was discussed on the netdev list before, see http://thread.gmane.org/gmane.linux.network/84603 .Signed-off-by Erik Mouw <[email protected]>
Forgot to tell: the patch is against 2.6.24 but should apply cleanly to the latest git kernel. The xircom_cb driver appears to be orphaned so I've send the patch to you.
Erik
Signature · 2 lines
They're all fools. Don't worry. Darwin may be slow, but he'll eventually get them. -- Matthew Lammers in alt.sysadmin.recovery
Quoted 11 lines · Erik Mouw
Quoted 10 lines · Erik Mouw
Changes in other networking paths uncovered a bug in the
xircom_cbdriver which made the kernel spew lots of the following error messages:BUG eth1 code -5 qlen 0
It turned out that the driver returned
-EIOwhen there was no descriptor available for sending packets. It should returnNETDEV_TX_BUSYinstead. This was discussed on the netdev list before, see http://thread.gmane.org/gmane.linux.network/84603 .
Quoted 5 lines
Quoted 1 line
Signed-off-by Erik Mouw <[email protected]>Forgot to tell: the patch is against 2.6.24 but should apply cleanly to the latest git kernel. The
xircom_cbdriver appears to be orphaned so I've send the patch to you.
Yep, that's the right thing to do...
Jeff
Jeff Garzik
AppliedQuoted 19 lines · Erik Mouw
Hi,
Changes in other networking paths uncovered a bug in the
xircom_cbdriver which made the kernel spew lots of the following error messages:BUG eth1 code -5 qlen 0
It turned out that the driver returned
-EIOwhen there was no descriptor available for sending packets. It should returnNETDEV_TX_BUSYinstead. This was discussed on the netdev list before, see http://thread.gmane.org/gmane.linux.network/84603 .Signed-off-by Erik Mouw <[email protected]>drivers/net/tulip/xircom_cb.c +0
-0
drivers/net/tulip/xircom_cb.c static int xircom_start_xmit(struct sk_buff *skb, struct net_device *dev) · line 447
Quoted 8 lines
drivers/net/tulip/xircom_cb.c +1
-1@@ -441,7 +441,7 @@ static int xircom_start_xmit(struct sk_buff *skb, struct net_device *dev)spin_unlock_irqrestore (&card->lock,flags);trigger_transmit (card); -return -EIO ; +return NETDEV_TX_BUSY ; }
applied