Skip to contentSkip to conversation

Fix incorrect address test in AT91F_DataflashSelect().

PATCH New Stelian Pop 2 participants 2 messages Feb 6, 2008 Memory technology devices (MTD)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix incorrect address test in AT91F_DataflashSelect().

---
 drivers/mtd/dataflash.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mtd/dataflash.c +1 -1
index 4084ff7..2421407 100644
@@ -309,7 +309,7 @@ AT91PS_DataFlash AT91F_DataflashSelect (AT91PS_DataFlash pFlash,
 
 	for (i = 0; i < CFG_MAX_DATAFLASH_BANKS; i++)
 		if ( dataflash_info[i].id
-			&& ((((int) addr) & 0xFF000000) ==
+			&& ((((int) *addr) & 0xFF000000) ==
 			dataflash_info[i].logical_address)) {
 			addr_valid = 1;
 			break;
Signature · 1 line
1.5.3.3
#1 lore raw

PATCH 1/1 Fix incorrect address test in AT91F_DataflashSelect().

Hi,

Quoted 11 lines · Stelian Pop
---
 drivers/mtd/dataflash.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mtd/dataflash.c +0 -0
index 4084ff7..2421407 100644

drivers/mtd/dataflash.c AT91PS_DataFlash AT91F_DataflashSelect (AT91PS_DataFlash pFlash, · line 315

Quoted 8 lines
drivers/mtd/dataflash.c +1 -1
@@ -309,7 +309,7 @@ AT91PS_DataFlash AT91F_DataflashSelect (AT91PS_DataFlash pFlash,
 
 	for (i = 0; i < CFG_MAX_DATAFLASH_BANKS; i++)
 		if ( dataflash_info[i].id
-			&& ((((int) addr) & 0xFF000000) ==
+			&& ((((int) *addr) & 0xFF000000) ==
 			dataflash_info[i].logical_address)) {
 			addr_valid = 1;
 			break;

I will send this fix to mailing list 4 month ago :).

Is still present?

regards michael