Skip to contentSkip to conversation

Update irq descriptor affinity

PATCH New Nathan Fontenot 1 participant 1 message Feb 6, 2008 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/4 Update irq descriptor affinity

The affinity mask in the virq descriptor needs to be set before we reset the affinity for the virq. Without doing this the call to get the new irq server fails and we end up leaving the virq pinned to the cpu we are removing.

This does not fail the cpu remove from the kernel, but it does prevent cpu dlpar remove operations from returning the cpu to the hypervisor.

---

arch/powerpc/platforms/pseries/xics.c +1 -1
Index: linux-2.6/arch/powerpc/platforms/pseries/xics.c
===================================================================
@@ -880,8 +880,8 @@
 		       virq, cpu);
 
 		/* Reset affinity to all cpus */
+		irq_desc[virq].affinity = CPU_MASK_ALL;
 		desc->chip->set_affinity(virq, CPU_MASK_ALL);
-		irq_desc[irq].affinity = CPU_MASK_ALL;
 unlock:
 		spin_unlock_irqrestore(&desc->lock, flags);
 	}