Skip to contentSkip to conversation

ACPI: update intrd DSDT override console messages

PATCH Eric Piel 2 participants 2 messages Feb 7, 2008 ACPI

lore
Share & tools
lore

Eric Piel

author
#0 lore raw

(sorry for not keeping the message id, I'm not subscribed to linux-acpi)

Quoted 8 lines

From: Len Brown <[email protected]>

also, address some checkpatch.pl violations

---
 drivers/acpi/osl.c |   33 ++++++++++++++++++---------------
 1 files changed, 18 insertions(+), 15 deletions(-)

:

Review

Quoted 3 lines
(quoted diff) +1 -1
-	printk(KERN_INFO PREFIX "Looking for DSDT in initramfs... ");
+	printk(KERN_INFO PREFIX "Checking initramfs for custom DSDT");

You need to also add a \n here. Otherwise in case of error it will look ugly ;-)

See you,
Eric

reviewer
#1 lore raw
Quoted 9 lines · Eric Piel

(sorry for not keeping the message id, I'm not subscribed to linux-acpi)

Quoted 8 lines

From: Len Brown <[email protected]>

also, address some checkpatch.pl violations

---
 drivers/acpi/osl.c |   33 ++++++++++++++++++---------------
 1 files changed, 18 insertions(+), 15 deletions(-)
Quoted 6 lines

:

Review

Quoted 3 lines
(quoted diff) +1 -1
-	printk(KERN_INFO PREFIX "Looking for DSDT in initramfs... ");
+	printk(KERN_INFO PREFIX "Checking initramfs for custom DSDT");

You need to also add a \n here. Otherwise in case of error it will look ugly ;-)

got it.

thanks,
-len