Skip to contentSkip to conversation

joydev compat_ioctl still broken

DISCUSSION Daniel Drake 2 participants 2 messages Feb 7, 2008 HID

lore
Share & tools
lore
#0 lore raw

Hi Brian,

In 2005 you rejected a patch rejecting some COMPATIBLE_IOCTL entries for joydev:
http://readlist.com/lists/vger.kernel.org/linux-kernel/28/144445.html

Quoted 2 lines

The joydev ioctls are already fixed (using ->compat_ioctl) in more recent kernels.

This appears to still be non-functional as of the present day (tested on 2.6.22). Any chance you could weigh in on the following bug:
http://bugzilla.kernel.org/show_bug.cgi?id=9652

Thanks!
Daniel

#1 lore raw
Quoted 9 lines · Daniel Drake

Hi Brian,

In 2005 you rejected a patch rejecting some COMPATIBLE_IOCTL entries for joydev:
http://readlist.com/lists/vger.kernel.org/linux-kernel/28/144445.html

Quoted 2 lines

The joydev ioctls are already fixed (using ->compat_ioctl) in more recent kernels.

Quoted 7 lines

This appears to still be non-functional as of the present day (tested on 2.6.22). Any chance you could weigh in on the following bug:
http://bugzilla.kernel.org/show_bug.cgi?id=9652

Thanks!
Daniel

Commit 024ac44c701d43f5e2d34bd6a35b2813a36e6010 should have fixed the compat ioctls in the correct manner.

Running "jstest --old js0" works for me on my amd64 system (kernel 2.6.23.14-107.fc8).

--
Brian Gerst