Skip to contentSkip to conversation

e1000e hardware CRC stripping breaks bridging

DISCUSSION Daniel Drake 4 participants 5 messages Feb 12, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi,

Johan Andersson reported on the Gentoo bugzilla that the hardware CRC stripping enabled by e1000e breaks bridging because sometimes the CRC is not stripped:
https://bugs.gentoo.org/show_bug.cgi?id=209235

Apparently "upstream" are aware but I couldn't find any mails or bug reports on this topic.

What's the current status of this issue? Perhaps we should disable hardware CRC stripping for 2.6.24.x/2.6.25 until this gets fixed?

Thanks,
Daniel

#1 lore raw

Here is the bug report:
http://bugzilla.kernel.org/show_bug.cgi?id=9940

/Johan

Quoted 20 lines · Daniel Drake

Hi,

Johan Andersson reported on the Gentoo bugzilla that the hardware CRC stripping enabled by e1000e breaks bridging because sometimes the CRC is not stripped:
https://bugs.gentoo.org/show_bug.cgi?id=209235

Apparently "upstream" are aware but I couldn't find any mails or bug reports on this topic.

What's the current status of this issue? Perhaps we should disable hardware CRC stripping for 2.6.24.x/2.6.25 until this gets fixed?

Thanks,
Daniel
--
To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#2 lore raw
Quoted 21 lines · Johan Andersson

Here is the bug report:
http://bugzilla.kernel.org/show_bug.cgi?id=9940

/Johan

Quoted 15 lines · Daniel Drake

Hi,

Johan Andersson reported on the Gentoo bugzilla that the hardware CRC stripping enabled by e1000e breaks bridging because sometimes the CRC is not stripped:
https://bugs.gentoo.org/show_bug.cgi?id=209235

Apparently "upstream" are aware but I couldn't find any mails or bug reports on this topic.

What's the current status of this issue? Perhaps we should disable hardware CRC stripping for 2.6.24.x/2.6.25 until this gets fixed?

Thanks,
Daniel

This patch, just needs to get reverted:

commit 140a74802894e9db57e5cd77ccff77e590ece5f3

Author: Auke Kok <[email protected]>
Date:   Thu Oct 25 13:57:58 2007 -0700

e1000e: Re-enable SECRC - crc stripping

#3 lore raw
In reply to Daniel Drake
Quoted 10 lines · Daniel Drake

Johan Andersson reported on the Gentoo bugzilla that the hardware CRC stripping enabled by e1000e breaks bridging because sometimes the CRC is not stripped:
https://bugs.gentoo.org/show_bug.cgi?id=209235

Apparently "upstream" are aware but I couldn't find any mails or bug reports on this topic.

What's the current status of this issue? Perhaps we should disable hardware CRC stripping for 2.6.24.x/2.6.25 until this gets fixed?

Jesse figured it out. I just send you a patch to test, can you guys give that a try and see if it fixes the situation? Johan?

thanks,

Auke

#4 lore raw
Quoted 7 lines · Auke

Jesse figured it out. I just send you a patch to test, can you guys give that a try and see if it fixes the situation? Johan?

thanks,

Auke

Yes, I will test this patch right away.

/Johan