Skip to contentSkip to conversation

uml: adding include/asm generate rule

PATCH In review Jiri Olsa 2 participants 2 messages Feb 12, 2008 – Feb 13, 2008 User-mode Linux (UML)

lore
Share & tools
lore

Jiri Olsa

author
#0 lore raw

PATCH 1/1 uml: adding include/asm generate rule

Hi,

I noticed UML does not create include/asm symlink automatically. I found this during solving another issue, so I dont know if this really helps or it is useless..

---
 arch/um/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/um/Makefile +1 -1
index dbeab15..8708a56 100644
@@ -29,7 +29,7 @@ SYMLINK_HEADERS := $(foreach header,$(SYMLINK_HEADERS),include/asm-um/$(header))
 # These are cleaned up during mrproper. Please DO NOT fix it again, this is
 # the Correct Thing(tm) to do!
 ARCH_SYMLINKS = include/asm-um/arch $(ARCH_DIR)/include/sysdep $(ARCH_DIR)/os \
-	$(SYMLINK_HEADERS) $(ARCH_DIR)/include/uml-config.h
+	$(SYMLINK_HEADERS) $(ARCH_DIR)/include/uml-config.h include/asm
 
 MODE_INCLUDE	+= -I$(srctree)/$(ARCH_DIR)/include/skas
 

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
User-mode-linux-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

#1 lore raw
Quoted 5 lines · Jiri Olsa

Hi,

I noticed UML does not create include/asm symlink automatically. I found this during solving another issue, so I dont know if this really helps or it is useless..

This patch must be wrong, since
include/asm is created by the generic kbuild, not the arch Makefile if include/asm wasn't being created, lots and lots of people
would have noticed
the patch doesn't seem to take O= builds into account

Jeff

Signature · 10 lines
Work email - jdike at linux dot intel dot com

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
User-mode-linux-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel