Skip to contentSkip to conversation

Fix building of fdt_support.c if DEBUG set

PATCH New Kumar Gala 4 participants 4 messages Feb 13, 2008

lore
Share & tools
lore

Kumar Gala

author
#0 lore raw

PATCH 1/1 Fix building of fdt_support.c if DEBUG set

---

Wolfgang, would like to see this go into mainline as it fixes building.

 common/fdt_support.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
common/fdt_support.c +3 -3
index 92f1c7f..69eb667 100644
@@ -415,7 +415,7 @@ void do_fixup_by_path(void *fdt, const char *path, const char *prop,
 {
 #if defined(DEBUG)
 	int i;
-	debug("Updating property '%s/%s' = ", node, prop);
+	debug("Updating property '%s/%s' = ", path, prop);
 	for (i = 0; i < len; i++)
 		debug(" %.2x", *(u8*)(val+i));
 	debug("\n");
@@ -441,7 +441,7 @@ void do_fixup_by_prop(void *fdt,
 	int off;
 #if defined(DEBUG)
 	int i;
-	debug("Updating property '%s/%s' = ", node, prop);
+	debug("Updating property '%s' = ", prop);
 	for (i = 0; i < len; i++)
 		debug(" %.2x", *(u8*)(val+i));
 	debug("\n");
@@ -468,7 +468,7 @@ void do_fixup_by_compat(void *fdt, const char *compat,
 	int off = -1;
 #if defined(DEBUG)
 	int i;
-	debug("Updating property '%s/%s' = ", node, prop);
+	debug("Updating property '%s' = ", prop);
 	for (i = 0; i < len; i++)
 		debug(" %.2x", *(u8*)(val+i));
 	debug("\n");
Signature · 1 line
1.5.3.8
#2 lore raw

PATCH 1/1 Fix building of fdt_support.c if DEBUG set

Quoted 7 lines · Jon Loeliger
Quoted 2 lines · Kumar Gala

---

Kumar, Thanks for getting this one!

Ditto. That is on my list to check and add to u-boot-fdt, but if Wolfgang can apply this directly, it will heal the breakage faster.

My apologies for not catching it myself when I applied the original patch (obviously, I didn't do a build with DEBUG enabled).

I'm not wild about acking without personally building the patched s/w first, but it is pretty obviously broken so provisionally...

gvb

#3 lore raw

PATCH 1/1 Fix building of fdt_support.c if DEBUG set

In reply to Kumar Gala
Quoted 4 lines · In message <[email protected]> you wrote:

---

Wolfgang, would like to see this go into mainline as it fixes building.

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Objects in mirror are closer than they appear.