Skip to contentSkip to conversation

timer:fix build warning in timer.c

PATCH Applied Shi Weihua 3 participants 3 messages Feb 14, 2008

lore
Share & tools
lore

Shi Weihua

author
#0 lore raw

PATCH 1/1 timer:fix build warning in timer.c

Fix the following compile warning without CONFIG_PREEMPT_RT:
kernel/timer.c:937: warning: ‘count_active_rt_tasks’ defined but not used

---

kernel/timer.c +2 -4
diff -urpN linux-2.6.24-rt1.orig/kernel/timer.c linux-2.6.24-rt1/kernel/timer.c
@@ -930,20 +930,18 @@ static unsigned long count_active_tasks(
 #endif
 }
 
+#ifdef CONFIG_PREEMPT_RT
 /*
  * Nr of active tasks - counted in fixed-point numbers
  */
 static unsigned long count_active_rt_tasks(void)
 {
-#ifdef CONFIG_PREEMPT_RT
 	extern unsigned long rt_nr_running(void);
 	extern unsigned long rt_nr_uninterruptible(void);
 
 	return (rt_nr_running() + rt_nr_uninterruptible()) * FIXED_1;
-#else
-	return 0;
-#endif
 }
+#endif
 
 /*
  * Hmm.. Changed this, as the GNU make sources (load.c) seems to
#1 lore raw
Quoted 4 lines · Shi Weihua

Fix the following compile warning without CONFIG_PREEMPT_RT:
kernel/timer.c:937: warning: ‘count_active_rt_tasks’ defined but not used

Thanks, applied.

-- Steve

#2 lore raw

Lttng for 2.6.24-rt1 ?

In reply to Shi Weihua

Hi,

Just wanted to know if anybody uses LTTNG on the 2.6.24 rt kernel ? I am trying to trace down some performance problems on my mpc5200b based embedded box and LttNG would probably help quite a bit in analyzing which tasks besides our own burn how much CPU and how the exact scheduling order between ISR and application is.

Best regards,

Daniel Schnell.