igb: fix legacy mode irq issue
Subsystems (2)
PATCH 1/1 igb: fix legacy mode irq issue
I booted an igb kernel with the option pci=nomsi and instantly noticed that interrupts no longer worked on my igb device. I took a look at the interrupt initialization and quickly discovered a comment stating:
"DO NOT USE EIAME or IAME in legacy mode"
It seemed a bit odd that bits to enable IAM were being set in legacy interrupt mode, so I dropped out the following parts and interrupts began working fine again.
---
igb_main.c | 3 --- 1 files changed, 3 deletions(-)
drivers/net/igb/igb_main.c +0 -3
@@ -472,9 +471,6 @@ static int igb_request_irq(struct igb_adapter *adapter) goto request_done; } -/* enable IAM, auto-mask */ -wr32 (E1000_IAM ,IMS_ENABLE_MASK ); - request_done:return err; }
Quoted 11 lines · Andy Gospodarek
I booted an igb kernel with the option pci=nomsi and instantly noticed that interrupts no longer worked on my igb device. I took a look at the interrupt initialization and quickly discovered a comment stating:
"DO NOT USE EIAME or IAME in legacy mode"
It seemed a bit odd that bits to enable IAM were being set in legacy interrupt mode, so I dropped out the following parts and interrupts began working fine again.
Signed-off-by Andy Gospodarek <[email protected]>
looks valid, I'll test and see, thanks Andy
Auke
Quoted 23 lines
---
igb_main.c | 3 --- 1 files changed, 3 deletions(-)drivers/net/igb/igb_main.c +0
-4@@ -472,9 +471,6 @@ static int igb_request_irq(struct igb_adapter *adapter) goto request_done; } -/* enable IAM, auto-mask */ -wr32 (E1000_IAM ,IMS_ENABLE_MASK ); - request_done:return err; } --To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 21 lines · Andy Gospodarek
I booted an igb kernel with the option pci=nomsi and instantly noticed that interrupts no longer worked on my igb device. I took a look at the interrupt initialization and quickly discovered a comment stating:
"DO NOT USE EIAME or IAME in legacy mode"
It seemed a bit odd that bits to enable IAM were being set in legacy interrupt mode, so I dropped out the following parts and interrupts began working fine again.
Signed-off-by Andy Gospodarek <[email protected]>---
igb_main.c | 3 --- 1 files changed, 3 deletions(-)drivers/net/igb/igb_main.c +0
-0
drivers/net/igb/igb_main.c static int igb_request_irq(struct igb_adapter *adapter) · line 477
Quoted 6 lines
drivers/net/igb/igb_main.c +0
-3@@ -472,9 +471,6 @@ static int igb_request_irq(struct igb_adapter *adapter) goto request_done; } -/* enable IAM, auto-mask */ -wr32 (E1000_IAM ,IMS_ENABLE_MASK ); -
ACK from Auke? (apologies if I missed it...)
Quoted 26 lines · Jeff Garzik
Quoted 25 lines · Andy Gospodarek
I booted an igb kernel with the option pci=nomsi and instantly noticed that interrupts no longer worked on my igb device. I took a look at the interrupt initialization and quickly discovered a comment stating:
"DO NOT USE EIAME or IAME in legacy mode"
It seemed a bit odd that bits to enable IAM were being set in legacy interrupt mode, so I dropped out the following parts and interrupts began working fine again.
Signed-off-by Andy Gospodarek <[email protected]>---
igb_main.c | 3 --- 1 files changed, 3 deletions(-)drivers/net/igb/igb_main.c +0
-0@@ -472,9 +471,6 @@ static int igb_request_irq(struct igb_adapter *adapter) goto request_done; }
Quoted 5 lines
drivers/net/igb/igb_main.c static int igb_request_irq(struct igb_adapter *adapter) · line 477
Quoted 3 lines
drivers/net/igb/igb_main.c +0
-3-/* enable IAM, auto-mask */ -wr32 (E1000_IAM ,IMS_ENABLE_MASK ); -ACK from Auke? (apologies if I missed it...)
you did not miss it yet :)
So, in principle this patch might leave interrupts enabled way too long. Unfortunately the code to enable IAM is way too complex for upstream-fixes so I don't want to push that into 2.6.25. I'm scrambling right now to figure out if this patch doesn't create endless interrupts from the hardware.
Once I'm happy with that answer I'll push/ack it
Auke