Skip to contentSkip to conversation

Fix return value of mtest when CFG_ALT_MEMTEST set

PATCH New Guennadi Liakhovetski 3 participants 5 messages Feb 13, 2008 – Feb 15, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix return value of mtest when CFG_ALT_MEMTEST set

Fix a missing return statement from a non-void function.

---

common/cmd_mem.c +2 -2
index f6bff54..c905304 100644
@@ -695,6 +695,7 @@ int do_mem_mtest (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
 	vu_long	*addr, *start, *end;
 	ulong	val;
 	ulong	readback;
+	int     rcode = 0;
 
 #if defined(CFG_ALT_MEMTEST)
 	vu_long	len;
@@ -725,7 +726,6 @@ int do_mem_mtest (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
 #else
 	ulong	incr;
 	ulong	pattern;
-	int     rcode = 0;
 #endif
 
 	if (argc > 1) {
@@ -983,8 +983,8 @@ int do_mem_mtest (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
 		}
 		incr = -incr;
 	}
-	return rcode;
 #endif
+	return rcode;
 }
 
 
#1 lore raw

PATCH 1/1 Fix return value of mtest when CFG_ALT_MEMTEST set

Quoted 3 lines · In message <[email protected]> you wrote:

Fix a missing return statement from a non-void function.

Applied, thanks.

Ummm... I had to apply this manually:

error: patch failed: common/cmd_mem.c:695
error: common/cmd_mem.c: patch does not apply
fatal: sha1 information is lacking or useless (common/cmd_mem.c). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge.
Patch failed at 0001.

How old is your source tree?

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Life. Don't talk to me about life.      - Marvin the Paranoid Android
#2 lore raw

PATCH 1/1 Fix return value of mtest when CFG_ALT_MEMTEST set

Quoted 9 lines · Wolfgang Denk
Quoted 3 lines · In message <[email protected]> you wrote:

Fix a missing return statement from a non-void function.

Applied, thanks.

Ummm... I had to apply this manually:

Quoted 8 lines

error: patch failed: common/cmd_mem.c:695
error: common/cmd_mem.c: patch does not apply
fatal: sha1 information is lacking or useless (common/cmd_mem.c). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge.
Patch failed at 0001.

How old is your source tree?

I produced the patch against 1.2.0, but before that I've verified, that the file, or at least the affected function hasn't changed, so, thought it would be ok. Sorry. But what does the error message actually mean? Is it just because I referenced some "way too old" commit?

Thanks
Guennadi
---
Guennadi Liakhovetski

#3 lore raw

PATCH 1/1 Fix return value of mtest when CFG_ALT_MEMTEST set

Quoted 17 lines · Guennadi Liakhovetski
Quoted 15 lines · Wolfgang Denk
Quoted 3 lines · In message <[email protected]> you wrote:

Fix a missing return statement from a non-void function.

Applied, thanks.

Ummm... I had to apply this manually:

error: patch failed: common/cmd_mem.c:695
error: common/cmd_mem.c: patch does not apply
fatal: sha1 information is lacking or useless (common/cmd_mem.c). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge.
Patch failed at 0001.

Quoted 7 lines
Quoted 1 line

How old is your source tree?

I produced the patch against 1.2.0, but before that I've verified, that the file, or at least the affected function hasn't changed, so, thought it would be ok. Sorry. But what does the error message actually mean? Is it just because I referenced some "way too old" commit?

No. "Way too old" is not the issue with the error message.

First off, the patch didn't apply directly to the file. That's our key that the patch isn't up-to-date with the current tree, as that file has changed significantly enough that your changes are no longer applicable.

In that situation, git tries to do a clever trick by backing off to a common ancestor where the patch was originally created. That is the first SHA1 in the diff header, assuming the patch was generated by git. If it can find this commit, git knows that the patch will apply at that point as that is what your presumably started with for your patch creation. Git will apply the patch there, and try to follow the changes forward in an attempt to bring the changes up to date itself.

However, in this case, the SHA1 was only in your repository, and not a common commit that was also in the public repository. Thus, git couldn't fall back on the three-way merge trick, and ultimately was not able to apply your patch.

The remedy is to rebase your patch to a current repository and resubmit it! :-) Chance are it will require some conflict resolution.

jdl

#4 lore raw

PATCH 1/1 Fix return value of mtest when CFG_ALT_MEMTEST set

Quoted 26 lines · Jon Loeliger
Quoted 17 lines · Guennadi Liakhovetski
Quoted 15 lines · Wolfgang Denk
Quoted 3 lines · In message <[email protected]> you wrote:

Fix a missing return statement from a non-void function.

Applied, thanks.

Ummm... I had to apply this manually:

error: patch failed: common/cmd_mem.c:695
error: common/cmd_mem.c: patch does not apply
fatal: sha1 information is lacking or useless (common/cmd_mem.c). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge.
Patch failed at 0001.

Quoted 7 lines
Quoted 1 line

How old is your source tree?

I produced the patch against 1.2.0, but before that I've verified, that the file, or at least the affected function hasn't changed, so, thought it would be ok. Sorry. But what does the error message actually mean? Is it just because I referenced some "way too old" commit?

Quoted 6 lines

No. "Way too old" is not the issue with the error message.

First off, the patch didn't apply directly to the file. That's our key that the patch isn't up-to-date with the current tree, as that file has changed significantly enough that your changes are no longer applicable.

Ok, I think, I know the reason. Wolfgang, can it be, that you first tried to apply this patch, and only then my other patch

[PATCH v2] Fix wrong memory limit calculation in memory-test

which I sent 5 days earlier? Then there would be a conflict yes. Otherwise this specific function hasn't change since then. Probably, I should have specified a dependency on my previous patch, sorry.

Thanks
Guennadi
---
Guennadi Liakhovetski