arch/x86/kernel/signal_32.c: replace !likely(x) by likely(!x)
PATCH 1/2 arch/x86/kernel/signal_32.c: replace !likely(x) by likely(!x)
Replace !likely(x) by likely(!x)
Signed-off-by Roel Kluin <[email protected]>
---
arch/x86/kernel/signal_32.c +1 -1
@@ -303,7 +303,7 @@ get_sigframe(struct k_sigaction *ka, struct pt_regs * regs, size_t frame_size)* If we are on the alternate signal stack and would overflow it, don't. * Return an always-bogus address instead so we will die with SIGSEGV. */ -if (on_sig_stack (sp) && !likely (on_sig_stack (sp - frame_size))) +if (on_sig_stack (sp) &&likely (!on_sig_stack (sp - frame_size)))return (void __user *)-1L ;/* This is the X/Open sanctioned signal stack switching. */
Quoted 9 lines · Roel Kluin
Replace !likely(x) by likely(!x)
Signed-off-by Roel Kluin <[email protected]>---
arch/x86/kernel/signal_32.c +0
-0
arch/x86/kernel/signal_32.c get_sigframe(struct k_sigaction *ka, struct pt_regs * regs, size_t frame_size)
Quoted 9 lines
arch/x86/kernel/signal_32.c +1
-2@@ -303,7 +303,7 @@ get_sigframe(struct k_sigaction *ka, struct pt_regs * regs, size_t frame_size)* If we are on the alternate signal stack and would overflow it, don't. * Return an always-bogus address instead so we will die with SIGSEGV. */ -if (on_sig_stack (sp) && !likely (on_sig_stack (sp - frame_size))) +if (on_sig_stack (sp) &&likely (!on_sig_stack (sp - frame_size)))return (void __user *)-1L ;/* This is the X/Open sanctioned signal stack switching. */ --
sorry, please ignore this patch
Quoted 4 lines · Roel Kluin
Quoted 1 line · Roel Kluin
Replace !likely(x) by likely(!x)
sorry, please ignore this patch
The patch below shouldn't change semantics.
---
replace !likely(x) by unlikely(!x)
Signed-off-by Roel Kluin <[email protected]>
---
arch/x86/kernel/signal_32.c +1 -1
@@ -303,7 +303,7 @@ get_sigframe(struct k_sigaction *ka, struct pt_regs * regs, size_t frame_size)* If we are on the alternate signal stack and would overflow it, don't. * Return an always-bogus address instead so we will die with SIGSEGV. */ -if (on_sig_stack (sp) && !likely (on_sig_stack (sp - frame_size))) +if (on_sig_stack (sp) &&unlikely (!on_sig_stack (sp - frame_size)))return (void __user *)-1L ;/* This is the X/Open sanctioned signal stack switching. */
arch/x86/kernel/signal_32.c get_sigframe(struct k_sigaction *ka, struct pt_regs * regs, size_t frame_size) · line 306
Quoted 2 lines · Roel Kluin
arch/x86/kernel/signal_32.c +1
-1-if (on_sig_stack (sp) && !likely (on_sig_stack (sp - frame_size))) +if (on_sig_stack (sp) &&unlikely (!on_sig_stack (sp - frame_size)))
hm, what's the purpose of this change?
Ingo