snd-hda-intel: don't print using snd_printdd on device open
PATCH 1/1 snd-hda-intel: don't print using snd_printdd on device open
Hi,
When CONFIG_SND_DEBUG_DETECT is set the hda-intel driver prints verbose info like this:
ALSA sound/pci/hda/hda_intel.c:1259: azx_pcm_prepare: bufsize=0x4400, fragsize=0x1100, format=0x11
ALSA sound/pci/hda/hda_codec.c:682: hda_codec_setup_stream: NID=0x7, stream=0x5, channel=0, format=0x11
ALSA sound/pci/hda/hda_codec.c:682: hda_codec_setup_stream: NID=0x3, stream=0x5, channel=0, format=0x11
ALSA sound/pci/hda/hda_codec.c:682: hda_codec_setup_stream: NID=0x3, stream=0x0, channel=0, format=0x0
ALSA sound/pci/hda/hda_codec.c:682: hda_codec_setup_stream: NID=0x7, stream=0x0, channel=0, format=0x0
ALSA sound/pci/hda/hda_codec.c:682: hda_codec_setup_stream: NID=0x3, stream=0x0, channel=0, format=0x0
Every time when an app opens the sound device.
This makes it impossible for distribution to enable this config option (to get more debug information for bug reports), because its way too noisy.SND_DEBUG_DETECT should only print stuff once when loading the driver.
There are some options to fix this:
1) don't print anything in functions that gets called when the device gets opened/prepared for output.
2) use snd_printd instead of snd_printdd and make CONFIG_SND_DEBUG_DETECT not depend on CONFIG_SND_DEBUG (this should be done anyway)
3) introduce a CONFIG_SND_DEBUG_DETECT_VERBOSE and snd_printddv and use it in this places (this one should be disabled by distributions then)
The attached patch implements 1) if 2) or 3) is preferred I can send a patch to do this.
Please CC me when replying
----------
snd-hda-intel: don't print using snd_printdd on device open
sound/pci/hda/hda_codec.c 2008-02-17 11:08:58.000000000 +0100 renamed from sound/pci/hda/hda_codec.c 2008-02-11 06:51:11.000000000 +0100 +0 -3
@@ -677,9 +677,6 @@ void snd_hda_codec_setup_stream(struct h if (!nid) return; - snd_printdd("hda_codec_setup_stream: " - "NID=0x%x, stream=0x%x, channel=%d, format=0x%x\n", - nid, stream_tag, channel_id, format); snd_hda_codec_write(codec, nid, 0, AC_VERB_SET_CHANNEL_STREAMID, (stream_tag << 4) | channel_id); msleep(1);
sound/pci/hda/hda_intel.c 2008-02-17 11:10:16.000000000 +0100 renamed from sound/pci/hda/hda_intel.c 2008-02-11 06:51:11.000000000 +0100 +0 -3
@@ -1249,9 +1249,6 @@ static int azx_pcm_prepare(struct snd_pc return -EINVAL; } - snd_printdd("azx_pcm_prepare: bufsize=0x%x, fragsize=0x%x, " - "format=0x%x\n", - azx_dev->bufsize, azx_dev->fragsize, azx_dev->format_val); azx_setup_periods(azx_dev); azx_setup_controller(chip, azx_dev); if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
From: Adel Gadllah <[email protected]>
snd-hda-intel: don't print using snd_printdd on device open
When CONFIG_SND_DEBUG_DETECT is set the hda-intel driver prints verbose info like this:
ALSA sound/pci/hda/hda_intel.c:1259: azx_pcm_prepare: bufsize=0x4400, fragsize=0x1100, format=0x11
ALSA sound/pci/hda/hda_codec.c:682: hda_codec_setup_stream: NID=0x7, stream=0x5, channel=0, format=0x11
ALSA sound/pci/hda/hda_codec.c:682: hda_codec_setup_stream: NID=0x3, stream=0x5, channel=0, format=0x11
ALSA sound/pci/hda/hda_codec.c:682: hda_codec_setup_stream: NID=0x3, stream=0x0, channel=0, format=0x0
ALSA sound/pci/hda/hda_codec.c:682: hda_codec_setup_stream: NID=0x7, stream=0x0, channel=0, format=0x0
ALSA sound/pci/hda/hda_codec.c:682: hda_codec_setup_stream: NID=0x3, stream=0x0, channel=0, format=0x0
Don't print anything in functions that get called when the device gets opened/prepared for output.
---
Orignal patch was mangled by sender's mail software.
sound/pci/hda/hda_codec.c 2008-02-17 11:08:58.000000000 +0100 renamed from sound/pci/hda/hda_codec.c 2008-02-11 06:51:11.000000000 +0100 +0 -3
@@ -677,9 +677,6 @@ void snd_hda_codec_setup_stream(struct h if (!nid) return; - snd_printdd("hda_codec_setup_stream: " - "NID=0x%x, stream=0x%x, channel=%d, format=0x%x\n", - nid, stream_tag, channel_id, format); snd_hda_codec_write(codec, nid, 0, AC_VERB_SET_CHANNEL_STREAMID, (stream_tag << 4) | channel_id); msleep(1);
sound/pci/hda/hda_intel.c 2008-02-17 11:10:16.000000000 +0100 renamed from sound/pci/hda/hda_intel.c 2008-02-11 06:51:11.000000000 +0100 +0 -3
@@ -1249,9 +1249,6 @@ static int azx_pcm_prepare(struct snd_pc return -EINVAL; } - snd_printdd("azx_pcm_prepare: bufsize=0x%x, fragsize=0x%x, " - "format=0x%x\n", - azx_dev->bufsize, azx_dev->fragsize, azx_dev->format_val); azx_setup_periods(azx_dev); azx_setup_controller(chip, azx_dev); if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
At Sun, 17 Feb 2008 21:40:32 -0500,
Quoted 21 lines · Chuck Ebbert
From: Adel Gadllah <[email protected]>
snd-hda-intel: don't print using
snd_printddon device openWhen
CONFIG_SND_DEBUG_DETECTis set the hda-intel driver prints verbose info like this:ALSA
sound/pci/hda/hda_intel.c:1259:azx_pcm_prepare: bufsize=0x4400, fragsize=0x1100, format=0x11
ALSAsound/pci/hda/hda_codec.c:682:hda_codec_setup_stream: NID=0x7, stream=0x5, channel=0, format=0x11
ALSAsound/pci/hda/hda_codec.c:682:hda_codec_setup_stream: NID=0x3, stream=0x5, channel=0, format=0x11
ALSAsound/pci/hda/hda_codec.c:682:hda_codec_setup_stream: NID=0x3, stream=0x0, channel=0, format=0x0
ALSAsound/pci/hda/hda_codec.c:682:hda_codec_setup_stream: NID=0x7, stream=0x0, channel=0, format=0x0
ALSAsound/pci/hda/hda_codec.c:682:hda_codec_setup_stream: NID=0x3, stream=0x0, channel=0, format=0x0
Quoted 2 lines
Don't print anything in functions that get called when the device gets opened/prepared for output.
Why? This debug option is explicitly for debugging purposes, and I see no reason why such behavior is prohibited.
Takashi
At Sun, 17 Feb 2008 11:31:09 +0100,
Quoted 19 lines · Adel Gadllah
Hi,
When
CONFIG_SND_DEBUG_DETECTis set the hda-intel driver prints verbose info like this:ALSA
sound/pci/hda/hda_intel.c:1259:azx_pcm_prepare: bufsize=0x4400, fragsize=0x1100, format=0x11
ALSAsound/pci/hda/hda_codec.c:682:hda_codec_setup_stream: NID=0x7, stream=0x5, channel=0, format=0x11
ALSAsound/pci/hda/hda_codec.c:682:hda_codec_setup_stream: NID=0x3, stream=0x5, channel=0, format=0x11
ALSAsound/pci/hda/hda_codec.c:682:hda_codec_setup_stream: NID=0x3, stream=0x0, channel=0, format=0x0
ALSAsound/pci/hda/hda_codec.c:682:hda_codec_setup_stream: NID=0x7, stream=0x0, channel=0, format=0x0
ALSAsound/pci/hda/hda_codec.c:682:hda_codec_setup_stream: NID=0x3, stream=0x0, channel=0, format=0x0
Quoted 3 lines
Every time when an app opens the sound device.
This makes it impossible for distribution to enable this config option (to get more debug information for bug reports),
Grr... why distrubionts need to set this option blindly at all?
Quoted 8 lines
because its way too noisy.
SND_DEBUG_DETECTshould only print stuff once when loading the driver.There are some options to fix this:
1) don't print anything in functions that gets called when the device gets opened/prepared for output.
Quoted 6 lines
2) use
snd_printdinstead ofsnd_printddand makeCONFIG_SND_DEBUG_DETECTnot depend onCONFIG_SND_DEBUG(this should be done anyway)3) introduce a
CONFIG_SND_DEBUG_DETECT_VERBOSEandsnd_printddvand use it in this places (this one should be disabled by distributions then)
CONFIG_SND_DEBUG_DETECT is just a verbose debug option and thus wrongly named. snd_printdd() there is the exactly intended behavior.
The real fix is to rename CONFIG_SND_DEBUG_DETECT to CONFIG_SND_DEBUG_VERBOSE or so.
thanks,
Takashi