Skip to contentSkip to conversation

cgroup: remove duplicate code in find_css_set()

PATCH In review Li Zefan 3 participants 3 messages Feb 18, 2008 – Feb 20, 2008 1 message not in the archive

lore
Share & tools
lore

Li Zefan

author
#0 lore raw

PATCH 6/7 cgroup: remove duplicate code in find_css_set()

The list head res->tasks gets initialized twice in find_css_set().

---
 kernel/cgroup.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
kernel/cgroup.c +0 -1
index e8c8e58..71cf961 100644
@@ -473,7 +473,6 @@ static struct css_set *find_css_set(
 	/* Link this cgroup group into the list */
 	list_add(&res->list, &init_css_set.list);
 	css_set_count++;
-	INIT_LIST_HEAD(&res->tasks);
 	write_unlock(&css_set_lock);
 
 	return res;
Signature · 1 line
1.5.4.rc3

A message that is not in the archive (sent off-list or not yet received): [email protected]

Acked-by
#2 lore raw
Quoted 3 lines · Li Zefan

The list head res->tasks gets initialized twice in find_css_set().

Quoted 20 lines
---
 kernel/cgroup.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
kernel/cgroup.c +0 -2
index e8c8e58..71cf961 100644
@@ -473,7 +473,6 @@ static struct css_set *find_css_set(
        /* Link this cgroup group into the list */
        list_add(&res->list, &init_css_set.list);
        css_set_count++;
-       INIT_LIST_HEAD(&res->tasks);
        write_unlock(&css_set_lock);
 
        return res;
--

1.5.4.rc3

Acked-by on v1 6/7
#3 lore raw
In reply to Li Zefan
Quoted 3 lines · Li Zefan

The list head res->tasks gets initialized twice in find_css_set().

Quoted 20 lines
---
 kernel/cgroup.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
kernel/cgroup.c +0 -2
index e8c8e58..71cf961 100644
@@ -473,7 +473,6 @@ static struct css_set *find_css_set(
        /* Link this cgroup group into the list */
        list_add(&res->list, &init_css_set.list);
        css_set_count++;
-       INIT_LIST_HEAD(&res->tasks);
        write_unlock(&css_set_lock);
 
        return res;
--

1.5.4.rc3