Skip to contentSkip to conversation

Split list.h and move rcu-protected lists into rculist.h

PATCH New Franck Bui-Huu 1 participant 1 message Feb 19, 2008

Subsystems (9)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 Split list.h and move rcu-protected lists into rculist.h

From: Franck Bui-Huu <[email protected]>

This patch moves rcu-protected lists from list.h into a new header file rculist.h.

This is done because list are a very used primitive structure all over the kernel and it's currently impossible to include other header files in this list.h without creating some circular dependencies.

For example, list.h implements rcu-protected list and uses rcu_dereference() without including rcupdate.h. It actually compiles because users of rcu_dereference() are macros. Others RCU functions could be used too but aren't probably because of this.

Therefore this patch creates rculist.h which includes rcupdates without to many changes/troubles.

---

Andrew

The patchset has been rebased on your v2.6.25-rc2-mm1 tag. It compiles the 'allmodconfig' fine now.

Please consider,

Franck

 arch/ia64/sn/kernel/irq.c                       |    1 +
 crypto/async_tx/async_tx.c                      |    1 +
 drivers/infiniband/hw/ipath/ipath_verbs.c       |    1 +
 drivers/infiniband/hw/ipath/ipath_verbs_mcast.c |    3 +-
 drivers/net/macvlan.c                           |    2 +-
 include/linux/dcache.h                          |    1 +
 include/linux/list.h                            |  385 ----------------------
 include/linux/rculist.h                         |  396 +++++++++++++++++++++++
 kernel/pid.c                                    |    1 +
 lib/textsearch.c                                |    1 +
 net/802/psnap.c                                 |    1 +
 net/8021q/vlan.c                                |    1 +
 net/bridge/br_fdb.c                             |    1 +
 net/bridge/br_stp.c                             |    1 +
 net/netlabel/netlabel_domainhash.c              |    3 +-
 15 files changed, 409 insertions(+), 390 deletions(-)
 create mode 100644 include/linux/rculist.h
arch/ia64/sn/kernel/irq.c +1 -0
index 53351c3..96c31b4 100644
@@ -11,6 +11,7 @@
 #include <linux/irq.h>
 #include <linux/spinlock.h>
 #include <linux/init.h>
+#include <linux/rculist.h>
 #include <asm/sn/addrs.h>
 #include <asm/sn/arch.h>
 #include <asm/sn/intr.h>
crypto/async_tx/async_tx.c +1 -0
index 6975616..be08624 100644
@@ -23,6 +23,7 @@
  * 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA.
  *
  */
+#include <linux/rculist.h>
 #include <linux/kernel.h>
 #include <linux/async_tx.h>
 
drivers/infiniband/hw/ipath/ipath_verbs.c +1 -0
index 32d8f88..83be1ed 100644
@@ -35,6 +35,7 @@
 #include <rdma/ib_user_verbs.h>
 #include <linux/io.h>
 #include <linux/utsname.h>
+#include <linux/rculist.h>
 
 #include "ipath_kernel.h"
 #include "ipath_verbs.h"
drivers/infiniband/hw/ipath/ipath_verbs_mcast.c +1 -2
index 9e5abf9..d73e322 100644
@@ -31,8 +31,7 @@
  * SOFTWARE.
  */
 
-#include <linux/list.h>
-#include <linux/rcupdate.h>
+#include <linux/rculist.h>
 
 #include "ipath_verbs.h"
 
drivers/net/macvlan.c +1 -1
index f651a81..f363f8d 100644
@@ -20,7 +20,7 @@
 #include <linux/errno.h>
 #include <linux/slab.h>
 #include <linux/string.h>
-#include <linux/list.h>
+#include <linux/rculist.h>
 #include <linux/notifier.h>
 #include <linux/netdevice.h>
 #include <linux/etherdevice.h>
include/linux/dcache.h +1 -0
index 795de50..d8121d2 100644
@@ -5,6 +5,7 @@
 
 #include <asm/atomic.h>
 #include <linux/list.h>
+#include <linux/rculist.h>
 #include <linux/spinlock.h>
 #include <linux/cache.h>
 #include <linux/rcupdate.h>
include/linux/list.h +0 -385

445 lines not on this page · raw message

include/linux/rculist.h new file +396 -0

396 lines not on this page · raw message

kernel/pid.c +1 -0
index 4776915..d62e3f7 100644
@@ -30,6 +30,7 @@
 #include <linux/module.h>
 #include <linux/slab.h>
 #include <linux/init.h>
+#include <linux/rculist.h>
 #include <linux/bootmem.h>
 #include <linux/hash.h>
 #include <linux/pid_namespace.h>
lib/textsearch.c +1 -0
index be8bda3..a3e500a 100644
@@ -97,6 +97,7 @@
 #include <linux/types.h>
 #include <linux/string.h>
 #include <linux/init.h>
+#include <linux/rculist.h>
 #include <linux/rcupdate.h>
 #include <linux/err.h>
 #include <linux/textsearch.h>
net/802/psnap.c +1 -0
index 31128cb..ea46439 100644
@@ -20,6 +20,7 @@
 #include <linux/mm.h>
 #include <linux/in.h>
 #include <linux/init.h>
+#include <linux/rculist.h>
 
 static LIST_HEAD(snap_list);
 static DEFINE_SPINLOCK(snap_lock);
net/8021q/vlan.c +1 -0
index dbc81b9..db8956e 100644
@@ -27,6 +27,7 @@
 #include <linux/mm.h>
 #include <linux/in.h>
 #include <linux/init.h>
+#include <linux/rculist.h>
 #include <net/p8022.h>
 #include <net/arp.h>
 #include <linux/rtnetlink.h>
net/bridge/br_fdb.c +1 -0
index bc40377..55d8723 100644
@@ -15,6 +15,7 @@
 
 #include <linux/kernel.h>
 #include <linux/init.h>
+#include <linux/rculist.h>
 #include <linux/spinlock.h>
 #include <linux/times.h>
 #include <linux/netdevice.h>
net/bridge/br_stp.c +1 -0
index e38034a..9e96ffc 100644
@@ -13,6 +13,7 @@
  *	2 of the License, or (at your option) any later version.
  */
 #include <linux/kernel.h>
+#include <linux/rculist.h>
 
 #include "br_private.h"
 #include "br_private_stp.h"
net/netlabel/netlabel_domainhash.c +1 -2
index fd46231..fbd1a3d 100644
@@ -30,8 +30,7 @@
  */
 
 #include <linux/types.h>
-#include <linux/rcupdate.h>
-#include <linux/list.h>
+#include <linux/rculist.h>
 #include <linux/skbuff.h>
 #include <linux/spinlock.h>
 #include <linux/string.h>
Signature · 1 line
1.5.4