: Pick up an orphaned sctp_sockets_allocated counter.
Subsystems (3)
PATCH 1/1 : Pick up an orphaned sctp_sockets_allocated counter.
This counter is currently write-only.
Drawing an analogy with the similar tcp counter, I think that this one should be pointed by the sockets_allocated members of sctp_prot and sctpv6_prot.
Or should it be instead removed at all?
---
net/sctp/socket.c +2 -0
@@ -6488,6 +6488,7 @@ struct proto sctp_prot = { .memory_pressure = &sctp_memory_pressure, .enter_memory_pressure = sctp_enter_memory_pressure, .memory_allocated = &sctp_memory_allocated, + .sockets_allocated = &sctp_sockets_allocated, REF_PROTO_INUSE(sctp) };
@@ -6521,6 +6522,7 @@ struct proto sctpv6_prot = { .memory_pressure = &sctp_memory_pressure, .enter_memory_pressure = sctp_enter_memory_pressure, .memory_allocated = &sctp_memory_allocated, + .sockets_allocated = &sctp_sockets_allocated,REF_PROTO_INUSE (sctpv6) };#endif /* defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE) */
Quoted 9 lines · Pavel Emelyanov
This counter is currently write-only.
Drawing an analogy with the similar tcp counter, I think that this one should be pointed by the
sockets_allocatedmembers ofsctp_protandsctpv6_prot.Or should it be instead removed at all?
Signed-off-by Pavel Emelyanov <[email protected]>
Ack. Looks like it got missed. It should be added.
-vlad
Quoted 33 lines
---
net/sctp/socket.c +2
-1@@ -6488,6 +6488,7 @@ struct proto sctp_prot = { .memory_pressure = &sctp_memory_pressure, .enter_memory_pressure = sctp_enter_memory_pressure, .memory_allocated = &sctp_memory_allocated, + .sockets_allocated = &sctp_sockets_allocated, REF_PROTO_INUSE(sctp) };@@ -6521,6 +6522,7 @@ struct proto sctpv6_prot = { .memory_pressure = &sctp_memory_pressure, .enter_memory_pressure = sctp_enter_memory_pressure, .memory_allocated = &sctp_memory_allocated, + .sockets_allocated = &sctp_sockets_allocated,REF_PROTO_INUSE (sctpv6) };#endif /* defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE) */ -------------------------------------------------------------------------This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Lksctp-developers mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/lksctp-developers
From: Vlad Yasevich <[email protected]>
Date: Tue, 19 Feb 2008 11:43:44 -0500
Quoted 7 lines
Quoted 6 lines · Pavel Emelyanov
This counter is currently write-only.
Drawing an analogy with the similar tcp counter, I think that this one should be pointed by the
sockets_allocatedmembers ofsctp_protandsctpv6_prot.
Quoted 5 lines
Quoted 3 lines
Or should it be instead removed at all?
Signed-off-by Pavel Emelyanov <[email protected]>Ack. Looks like it got missed. It should be added.
Applied, thanks everyone.