: Make Xen 3.1 IDE flush on O_DIRECT with drive caching off
PATCH 1/1 : Make Xen 3.1 IDE flush on O_DIRECT with drive caching off
All,
Long ago Xen added code to the device model to basically do an fsync()
after every data write if the user in the guest specified that IDE write caching should be disabled. This works fine, except in the case where you are doing O_DIRECT writes inside the guest (ala dd if=/dev/zero of=/dev/hdb oflag=direct).
This is because you can get out of ide_write_dma_cb() in the middle of the loop
without going through the logic to sync. This simple patch makes sure that you always check (and sync) inside the write callback.
This patch applies to xen-3.1-testing.hg; I still have to test 3.2 (and the new AIO code) to see if it is affected by this bug.
tools/ioemu/hw/ide.c renamed from tools/ioemu/hw/ide.c.orig +3 -1
@@ -1024,7 +1024,9 @@ static int ide_write_dma_cb(IDEState *s,#else /* !DMA_MULTI_THREAD */ ;#endif /* DMA_MULTI_THREAD */ -return 0 ; + +/* make sure that we (possibly) flush before leaving */ +break ; }if (n >MAX_MULT_SECTORS ) n =MAX_MULT_SECTORS ;
_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel
Quoted 9 lines · Chris Lalancette
All,
Long ago Xen added code to the device model to basically do anfsync()
after every data write if the user in the guest specified that IDE write caching should be disabled. This works fine, except in the case where you are doingO_DIRECTwrites inside the guest (ala dd if=/dev/zero of=/dev/hdb oflag=direct).
This is because you can get out ofide_write_dma_cb()in the middle of the loop
without going through the logic to sync. This simple patch makes sure that you always check (and sync) inside the write callback.
Quoted 4 lines
This patch applies to xen-3.1-testing.hg; I still have to test 3.2 (and the new AIO code) to see if it is affected by this bug.
Signed-off-by Chris Lalancette <[email protected]>
I've gone through the logic in ide_write_dma_cb() and breaking out of the loop is the thing todo in this scenario. The new AIO code in 3.2 looks like it suffers from a similar problem, with one of the code paths missing the sync due to a mis-placed label / goto pair.
Dan.
Signature · 4 lines
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
Quoted 11 lines · Chris Lalancette
All,
Long ago Xen added code to the device model to basically do anfsync()
after every data write if the user in the guest specified that IDE write caching should be disabled. This works fine, except in the case where you are doingO_DIRECTwrites inside the guest (ala dd if=/dev/zero of=/dev/hdb oflag=direct).
This is because you can get out ofide_write_dma_cb()in the middle of the loop
without going through the logic to sync. This simple patch makes sure that you always check (and sync) inside the write callback.This patch applies to xen-3.1-testing.hg; I still have to test 3.2 (and the new AIO code) to see if it is affected by this bug.
After some testing, it looks like 3.2 is not affected by this bug, so it won't be needed there.
Chris Lalancette