Skip to contentSkip to conversation

fs/partitions/msdos: directly check if FAT boot sector

RFC PATCH In review Frank Seidel 3 participants 4 messages Feb 28, 2008 – Mar 1, 2008 VFS

lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 fs/partitions/msdos: directly check if FAT boot sector

Hi,

i received a complaint that some FAT formated medias
(e.g. sd memory cards) trigger a "unknown partition table" message even though there is no partition table and they work correctly, while in general (when e.g. formated with mkdosfs or even Windows Vista) this message is not shown.
Currently this seems only to happen when the medias get formatted with Windows XP (and possibly Win 2000). Then the boot indicator byte contains garbage (part of text message) and so do the other parts checked by msdos_paritition which then later triggers this message.

Would the patch below be appropriate to solve this issue/calm those users? It works ok here for the medias i could test.

Any feedback is very welcome. :-)

Thanks,
Frank
---
From: Frank Seidel <[email protected]>
Subject: detect fat media without partition table correctly
References: novell bug #364365

Most fat formatted media without partition table contains zeros in the boot indication and the other tested bytes and so falls through the checks in msdos_partition, leading it to return with 1 (all is fine).
But some (e.g. WinXP formatted) fat fomated medias don't use boot_ind and so the check fails and causes a "unkown partition table" warning eventhough there is none and everything would be fine.
This additional check directly verifies if there is a fat formatted medium without a partition table.

---
 fs/partitions/msdos.c |    9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
fs/partitions/msdos.c +8 -1
@@ -18,7 +18,7 @@
  *
  *  Re-organised Feb 1998 Russell King
  */
-
+#include <linux/msdos_fs.h>
 
 #include "check.h"
 #include "msdos.h"
@@ -419,6 +419,7 @@ int msdos_partition(struct parsed_partit
 	Sector sect;
 	unsigned char *data;
 	struct partition *p;
+	struct fat_boot_sector *fb;
 	int slot;
 
 	data = read_dev_sector(bdev, 0, &sect);
@@ -441,6 +442,12 @@ int msdos_partition(struct parsed_partit
 	 * partition table. Reject this in case the boot indicator
 	 * is not 0 or 0x80.
 	 */
+	fb = (struct fat_boot_sector *) data;
+	if (fb->reserved && fb->fats && FAT_VALID_MEDIA(fb->media)) {
+		printk("\n");
+		put_dev_sector(sect);
+		return 1;
+	}
 	p = (struct partition *) (data + 0x1be);
 	for (slot = 1; slot <= 4; slot++, p++) {
 		if (p->boot_ind != 0 && p->boot_ind != 0x80) {
#1 lore raw
Quoted 10 lines · Frank Seidel

i received a complaint that some FAT formated medias
(e.g. sd memory cards) trigger a "unknown partition table" message even though there is no partition table and they work correctly, while in general (when e.g. formated with mkdosfs or even Windows Vista) this message is not shown.
Currently this seems only to happen when the medias get formatted with Windows XP (and possibly Win 2000). Then the boot indicator byte contains garbage (part of text message) and so do the other parts checked by msdos_paritition which then later triggers this message.

Quoted 2 lines

Would the patch below be appropriate to solve this issue/calm those users? It works ok here for the medias i could test.

There is also a similar complaint from users who format ext3 directly on a disk/LUN without a partition table, because the partition table offset negatively impacts the performance of the filesystem (causing unaligned IO on a RAID device). Turning off this message is very good.

Quoted 54 lines

---
From: Frank Seidel <[email protected]>
Subject: detect fat media without partition table correctly
References: novell bug #364365

Most fat formatted media without partition table contains zeros in the boot indication and the other tested bytes and so falls through the checks in msdos_partition, leading it to return with 1 (all is fine).
But some (e.g. WinXP formatted) fat fomated medias don't use boot_ind and so the check fails and causes a "unkown partition table" warning eventhough there is none and everything would be fine.
This additional check directly verifies if there is a fat formatted medium without a partition table.

---
 fs/partitions/msdos.c |    9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
fs/partitions/msdos.c +8 -2
@@ -18,7 +18,7 @@
  *
  *  Re-organised Feb 1998 Russell King
  */
-
+#include <linux/msdos_fs.h>
 
 #include "check.h"
 #include "msdos.h"
@@ -419,6 +419,7 @@ int msdos_partition(struct parsed_partit
 	Sector sect;
 	unsigned char *data;
 	struct partition *p;
+	struct fat_boot_sector *fb;
 	int slot;
 
 	data = read_dev_sector(bdev, 0, &sect);
@@ -441,6 +442,12 @@ int msdos_partition(struct parsed_partit
 	 * partition table. Reject this in case the boot indicator
 	 * is not 0 or 0x80.
 	 */
+	fb = (struct fat_boot_sector *) data;
+	if (fb->reserved && fb->fats && FAT_VALID_MEDIA(fb->media)) {
+		printk("\n");
+		put_dev_sector(sect);
+		return 1;
+	}
 	p = (struct partition *) (data + 0x1be);
 	for (slot = 1; slot <= 4; slot++, p++) {
 		if (p->boot_ind != 0 && p->boot_ind != 0x80) {
-
Quoted 3 lines

To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.

#2 lore raw
In reply to Frank Seidel
Quoted 38 lines · On Thu, 28 Feb 2008 13:32:01 +0100 Frank Seidel <[email protected]> wrote:

Most fat formatted media without partition table contains zeros in the boot indication and the other tested bytes and so falls through the checks in msdos_partition, leading it to return with 1 (all is fine).
But some (e.g. WinXP formatted) fat fomated medias don't use boot_ind and so the check fails and causes a "unkown partition table" warning eventhough there is none and everything would be fine.
This additional check directly verifies if there is a fat formatted medium without a partition table.

---
 fs/partitions/msdos.c |    9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
fs/partitions/msdos.c +2 -1
@@ -18,7 +18,7 @@
  *
  *  Re-organised Feb 1998 Russell King
  */
-
+#include <linux/msdos_fs.h>
 
 #include "check.h"
 #include "msdos.h"
@@ -419,6 +419,7 @@ int msdos_partition(struct parsed_partit
 	Sector sect;
 	unsigned char *data;
 	struct partition *p;
+	struct fat_boot_sector *fb;
 	int slot;
 
 	data = read_dev_sector(bdev, 0, &sect);
@@ -441,6 +442,12 @@ int msdos_partition(struct parsed_partit
 	 * partition table. Reject this in case the boot indicator
 	 * is not 0 or 0x80.

fs/partitions/msdos.c int msdos_partition(struct parsed_partit · line 453

Quoted 10 lines
fs/partitions/msdos.c +6 -0
 	 */
+	fb = (struct fat_boot_sector *) data;
+	if (fb->reserved && fb->fats && FAT_VALID_MEDIA(fb->media)) {
+		printk("\n");
+		put_dev_sector(sect);
+		return 1;
+	}
 	p = (struct partition *) (data + 0x1be);
 	for (slot = 1; slot <= 4; slot++, p++) {
 		if (p->boot_ind != 0 && p->boot_ind != 0x80) {

fs/partitions/msdos.c: In function 'msdos_partition':
fs/partitions/msdos.c:446: warning: comparison is always true due to limited range of data type

didn't you get this?

The reason is that FAT_VALID_MEDIA() is bogus:

#define FAT_VALID_MEDIA(x) ((0xF8 <= (x) && (x) <= 0xFF) || (x) == 0xF0)

It appears that the on-disk field which FAT_VALID_MEDIA() is designed to test is only 8-bit, so the comparison with 0xff is pointless. The only existing caller of FAT_VALID_MEDIA() cheats by copying the value into a local unsigned int first.

So I'll leave things as they are for now, but I'd ask that someone can confirm that we should simply remove the 0xff test from FAT_VALID_MEDIA()?

#3 lore raw
Quoted 4 lines · Andrew Morton

fs/partitions/msdos.c: In function 'msdos_partition':
fs/partitions/msdos.c:446: warning: comparison is always true due to limited range of data type

didn't you get this?

Yes, sorry, but i saw it too late after posting.

Quoted 1 line

The reason is that FAT_VALID_MEDIA() is bogus:

yes, i stated this in our bug to the complaint
(https://bugzilla.novell.com/show_bug.cgi?id=364365#c15), but should have also posted it here, sorry.

Quoted 9 lines

#define FAT_VALID_MEDIA(x) ((0xF8 <= (x) && (x) <= 0xFF) || (x) == 0xF0)

It appears that the on-disk field which FAT_VALID_MEDIA() is designed to test is only 8-bit, so the comparison with 0xff is pointless. The only existing caller of FAT_VALID_MEDIA() cheats by copying the value into a local unsigned int first.

So I'll leave things as they are for now, but I'd ask that someone can confirm that we should simply remove the 0xff test from FAT_VALID_MEDIA()?

At least in my opinion it should be removed.

Thanks,
Frank