Skip to contentSkip to conversation

hda: disable power management on fixed ports.

PATCH Applied Matthew Ranostay 2 participants 2 messages Feb 29, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hda: disable power management on fixed ports.

Power management can't be enabled on fixed ports, since the presence will always return false and prevent output.

---

pci/hda/patch_sigmatel.c +4 -0
diff -r 54a51b975975 pci/hda/patch_sigmatel.c
@@ -3015,11 +3015,15 @@ static int stac92xx_init(struct hda_code
 					? STAC_HP_EVENT : STAC_PWR_EVENT;
 		int pinctl = snd_hda_codec_read(codec, spec->pwr_nids[i],
 					0, AC_VERB_GET_PIN_WIDGET_CONTROL, 0);
+		int def_conf = snd_hda_codec_read(codec, spec->pwr_nids[i],
+					0, AC_VERB_GET_CONFIG_DEFAULT, 0);
 		/* outputs are only ports capable of power management
 		 * any attempts on powering down a input port cause the
 		 * referenced VREF to act quirky.
 		 */
 		if (pinctl & AC_PINCTL_IN_EN)
+			continue;
+		if (get_defcfg_connect(def_conf) != AC_JACK_PORT_FIXED)
 			continue;
 		enable_pin_detect(codec, spec->pwr_nids[i], event | i);
 		codec->patch_ops.unsol_event(codec, (event | i) << 26);
Applied
#1 lore raw

At Thu, 28 Feb 2008 20:49:42 -0500,

Quoted 5 lines · Matthew Ranostay

Power management can't be enabled on fixed ports, since the presence will always return false and prevent output.

Applied to HG tree. Thanks.

Takashi