: Use proc_create to setup de->proc_fops.
Subsystems (3)
PATCH 1/4 : Use proc_create to setup de->proc_fops.
In addition to commit 160f17 use proc_create in two more places.
---
net/sctp/proc.c +3 -6
@@ -256,12 +256,10 @@ int __init sctp_eps_proc_init(void) {struct proc_dir_entry *p; - p =create_proc_entry ("eps" ,S_IRUGO , proc_net_sctp); + p =proc_create ("eps" ,S_IRUGO , proc_net_sctp, &sctp_eps_seq_fops);if (!p)return -ENOMEM ; - p->proc_fops = &sctp_eps_seq_fops; -return 0 ; }
@@ -367,12 +365,11 @@ int __init sctp_assocs_proc_init(void) {struct proc_dir_entry *p; - p =create_proc_entry ("assocs" ,S_IRUGO , proc_net_sctp); + p =proc_create ("assocs" ,S_IRUGO , proc_net_sctp, + &sctp_assocs_seq_fops);if (!p)return -ENOMEM ; - p->proc_fops = &sctp_assocs_seq_fops; -return 0 ; }
From: Pavel Emelyanov <[email protected]>
Date: Fri, 29 Feb 2008 16:42:45 +0300
Quoted 3 lines
In addition to commit 160f17 use
proc_createin two more places.Signed-off-by Pavel Emelyanov <[email protected]>
Applied to net-2.6
Please please please, when referencing commits DO NOT provide only the SHA ID, provide the headline of the commit log as well because when patches move around trees the IDs change.
I do this for a lot of people lately, please help lessen my load by taking care of this yourselves.
For example, the new commit log for this change here is now:
[SCTP]: Use proc_create to setup de->proc_fops.
In addition to commit 160f17 ("[SCTP]: Use proc_create() to setup ->proc_fops first") use proc_create in two more places.
Thanks.
David Miller
maintainerFrom: Pavel Emelyanov <[email protected]>
Date: Fri, 29 Feb 2008 16:42:45 +0300
Quoted 3 lines
In addition to commit 160f17 use
proc_createin two more places.Signed-off-by Pavel Emelyanov <[email protected]>
BTW, I put this into net-2.6 instead of net-2.6.26 because this is a bug fix which could easily trigger an OOPS.