Skip to contentSkip to conversation

Don't use seq_release_private where inappropriate.

PATCH Applied Pavel Emelyanov 2 participants 2 messages Feb 29, 2008

Subsystems (4)
Networking Network drivers netfilter Rxrpc sockets (AF_RXRPC)
lore
Share & tools
lore

Pavel Emelyanov

author
#0 lore raw

PATCH 4/4 Don't use seq_release_private where inappropriate.

Some netfilter code and rxrpc one use seq_open() to open a proc file, but seq_release_private to release one.

This is harmless, but ambiguous.

Signed-off-by Pavel Emelyanov <[email protected]>

---

net/ipv4/netfilter/nf_conntrack_l3proto_ipv4_compat.c +1 -1
index 089252e..9668c3a 100644
@@ -379,7 +379,7 @@ static const struct file_operations ct_cpu_seq_fops = {
 	.open    = ct_cpu_seq_open,
 	.read    = seq_read,
 	.llseek  = seq_lseek,
-	.release = seq_release_private,
+	.release = seq_release,
 };
 
 int __init nf_conntrack_ipv4_compat_init(void)
net/netfilter/nf_conntrack_standalone.c +1 -1
index e88e96a..a9bf6e4 100644
@@ -293,7 +293,7 @@ static const struct file_operations ct_cpu_seq_fops = {
 	.open	 = ct_cpu_seq_open,
 	.read	 = seq_read,
 	.llseek	 = seq_lseek,
-	.release = seq_release_private,
+	.release = seq_release,
 };
 #endif /* CONFIG_PROC_FS */
net/rxrpc/ar-proc.c +2 -2
index 83eda24..017322e 100644
@@ -103,7 +103,7 @@ const struct file_operations rxrpc_call_seq_fops = {
 	.open		= rxrpc_call_seq_open,
 	.read		= seq_read,
 	.llseek		= seq_lseek,
-	.release	= seq_release_private,
+	.release	= seq_release,
 };
 
 /*

@@ -188,5 +188,5 @@ const struct file_operations rxrpc_connection_seq_fops = {
 	.open		= rxrpc_connection_seq_open,
 	.read		= seq_read,
 	.llseek		= seq_lseek,
-	.release	= seq_release_private,
+	.release	= seq_release,
 };