vivi: registered as /dev/video%d

Now that vivi can be something other than /dev/video0, it should tell us what it
is. This works for n_devs>1.

sudo modprobe vivi n_devs=3

[115041.616401] vivi: V4L2 device registered as /dev/video0
[115041.616445] vivi: V4L2 device registered as /dev/video1
[115041.616481] vivi: V4L2 device registered as /dev/video2
[115041.616486] Video Technology Magazine Virtual Video Capture Board 

successfully loaded.

Carl,

Quoted 3 lines · On Fri, 29 Feb 2008 18:18:17 -0600 Carl Karsten <[email protected]> wrote:

Now that vivi can be something other than /dev/video0, it should tell us what it
is. This works for n_devs>1.

Quoted 6 lines

sudo modprobe vivi n_devs=3

[115041.616401] vivi: V4L2 device registered as /dev/video0
[115041.616445] vivi: V4L2 device registered as /dev/video1
[115041.616481] vivi: V4L2 device registered as /dev/video2
[115041.616486] Video Technology Magazine Virtual Video Capture Board successfully loaded.

Please, re-send your patches, adding your SOB. Please numberate them with something like [PATCH 1/3] for me to apply at the proper order.

I posted a week ago and haven't heard anything.

How long should I wait before
posting this? :)

linux/drivers/media/video/vivi.c +1 -1

-		else
+            printk(KERN_INFO "%s: /dev/video%d unregistered.\n", MODULE_NAME,

dev->vfd->minor);

} else
printk(KERN_INFO "Video Technology Magazine Virtual Video "

(quoted diff) +2 -1

-				 "Capture Board successfully loaded.\n");
+                 "Capture Board ver %u.%u.%u successfully loaded.\n",
+        (VIVI_VERSION >> 16) & 0xFF, (VIVI_VERSION >> 8) & 0xFF, VIVI_VERSION &

0xFF);

Quoted 1 line · On Wed, 28 May 2008 15:15:35 -0500 Carl Karsten <[email protected]> wrote:

I posted a week ago and haven't heard anything.

I was on vacations last week.

Quoted 2 lines

How long should I wait before
posting this? :)

There are a few issues on your patch:

Quoted 3 lines

(quoted diff) +1 -1

-		else
+            printk(KERN_INFO "%s: /dev/video%d unregistered.\n", MODULE_NAME,

dev->vfd->minor);

Your patch got word wrapped. So, it didn't apply.

Review

Quoted 2 lines

(quoted diff) +2 -0

+        }
+		else {

CodingStyle is wrong. It should be:

	} else {

(at the same line)

Also, on some places, you used space, instead of tabs.

Please, check your patch with checkpatch.pl (or, inside Mercurial, make checkpatch) before sending it.

Also, be sure that your emailer won't add line breaks at the wrong places.

Quoted 6 lines

} else
printk(KERN_INFO "Video Technology Magazine Virtual Video "

(quoted diff) +2 -1

-				 "Capture Board successfully loaded.\n");
+                 "Capture Board ver %u.%u.%u successfully loaded.\n",
+        (VIVI_VERSION >> 16) & 0xFF, (VIVI_VERSION >> 8) & 0xFF, VIVI_VERSION &

0xFF);

The indentation is very weird here.

Quoted 32 lines · Mauro Carvalho Chehab

Quoted 1 line · On Wed, 28 May 2008 15:15:35 -0500 Carl Karsten <[email protected]> wrote:

I posted a week ago and haven't heard anything.

I was on vacations last week.

Quoted 2 lines

How long should I wait before
posting this? :)

There are a few issues on your patch:

Quoted 3 lines

(quoted diff) +1 -1

-		else
+            printk(KERN_INFO "%s: /dev/video%d unregistered.\n", MODULE_NAME,

dev->vfd->minor);

Your patch got word wrapped. So, it didn't apply.

Review

Quoted 2 lines

(quoted diff) +2 -0

+        }
+		else {

CodingStyle is wrong. It should be:

	} else {

(at the same line)

Also, on some places, you used space, instead of tabs.

Please, check your patch with checkpatch.pl (or, inside Mercurial, make checkpatch) before sending it.

Also, be sure that your emailer won't add line breaks at the wrong places.

Quoted 6 lines

Quoted 6 lines

} else
printk(KERN_INFO "Video Technology Magazine Virtual Video "

linux/drivers/media/video/vivi.c +2 -1

-				 "Capture Board successfully loaded.\n");
+                 "Capture Board ver %u.%u.%u successfully loaded.\n",
+        (VIVI_VERSION >> 16) & 0xFF, (VIVI_VERSION >> 8) & 0xFF, VIVI_VERSION &

0xFF);

Fixed what you mentioned, make checkpatch doesn't report anything now. It was reporting "warning: line over 80 characters" so now that those are fixed maybe t-bird won't wrap them.

Quoted 2 lines

The indentation is very weird here.

Either the original code was weird ("quoted strings" were lined up) or a side effect of me using 4 space tabs.

If it still looks odd, I'll be happy to adjust.

------------------------------------------------------
Patch 1:
diff -r 9d04bba82511 linux/drivers/media/video/vivi.c

linux/drivers/media/video/vivi.c +15 -5

@@ -48,6 +48,8 @@
  #include <linux/freezer.h>
  #endif
 
+#define MODULE_NAME "vivi"
+
  /* Wake up at about 30 fps */
  #define WAKE_NUMERATOR 30
  #define WAKE_DENOMINATOR 1001

@@ -56,7 +58,7 @@
  #include "font.h"
 
  #define VIVI_MAJOR_VERSION 0
-#define VIVI_MINOR_VERSION 4
+#define VIVI_MINOR_VERSION 5
  #define VIVI_RELEASE 0
  #define VIVI_VERSION \
  	KERNEL_VERSION(VIVI_MAJOR_VERSION, VIVI_MINOR_VERSION, VIVI_RELEASE)

@@ -1086,10 +1088,15 @@ static int vivi_release(void)
  		list_del(list);
  		dev = list_entry(list, struct vivi_dev, vivi_devlist);
 
-		if (-1 != dev->vfd->minor)
+		if (-1 != dev->vfd->minor) {
  			video_unregister_device(dev->vfd);
-		else
+			printk(KERN_INFO "%s: /dev/video%d unregistered.\n",
+				MODULE_NAME, dev->vfd->minor);
+		} else {
  			video_device_release(dev->vfd);
+			printk(KERN_INFO "%s: /dev/video%d released.\n",
+				MODULE_NAME, dev->vfd->minor);
+		}
 
  		kfree(dev);
  	}

@@ -1202,6 +1209,8 @@ static int __init vivi_init(void)
  			video_nr++;
 
  		dev->vfd = vfd;
+		printk(KERN_INFO "%s: V4L2 device registered as /dev/video%d\n",
+			MODULE_NAME, vfd->minor);
  	}
 
  	if (ret < 0) {

@@ -1209,7 +1218,9 @@ static int __init vivi_init(void)
  		printk(KERN_INFO "Error %d while loading vivi driver\n", ret);
  	} else
  		printk(KERN_INFO "Video Technology Magazine Virtual Video "
-				 "Capture Board successfully loaded.\n");
+			"Capture Board ver %u.%u.%u successfully loaded.\n",
+			(VIVI_VERSION >> 16) & 0xFF, (VIVI_VERSION >> 8) & 0xFF,
+			VIVI_VERSION & 0xFF);
  	return ret;
  }
 
------------------------------------------------------

Signed-off-by Carl Karsten <[email protected]>

Carl K

Am Mittwoch, den 28.05.2008, 18:31 -0500 schrieb Carl Karsten:

Quoted 52 lines

Quoted 39 lines · hermann pitton

Hi Carl,

Am Mittwoch, den 28.05.2008, 17:03 -0500 schrieb Carl Karsten:

Quoted 28 lines

Quoted 27 lines · Mauro Carvalho Chehab

Quoted 1 line · On Wed, 28 May 2008 15:15:35 -0500 Carl Karsten <[email protected]> wrote:

I posted a week ago and haven't heard anything.

I was on vacations last week.

Quoted 2 lines

How long should I wait before
posting this? :)

There are a few issues on your patch:

Quoted 3 lines

(quoted diff) +1 -1

-		else
+            printk(KERN_INFO "%s: /dev/video%d unregistered.\n", MODULE_NAME,

dev->vfd->minor);

Your patch got word wrapped. So, it didn't apply.

Review

Quoted 2 lines

(quoted diff) +2 -0

+        }
+		else {

CodingStyle is wrong. It should be:

	} else {

(at the same line)

Also, on some places, you used space, instead of tabs.

Please, check your patch with checkpatch.pl (or, inside Mercurial, make checkpatch) before sending it.

Quoted 8 lines

Quoted 7 lines

Also, be sure that your emailer won't add line breaks at the wrong places.

Quoted 6 lines

} else
printk(KERN_INFO "Video Technology Magazine Virtual Video "

(quoted diff) +2 -1

-				 "Capture Board successfully loaded.\n");
+                 "Capture Board ver %u.%u.%u successfully loaded.\n",
+        (VIVI_VERSION >> 16) & 0xFF, (VIVI_VERSION >> 8) & 0xFF, VIVI_VERSION &

0xFF);

Fixed what you mentioned, make checkpatch doesn't report anything now. It was reporting "warning: line over 80 characters" so now that those are fixed maybe t-bird won't wrap them.

Quoted 6 lines

your hope is in vain for the one space indent in front of every line tbird adds. We have that issue already seen with your previous patches and I told you about, it is a very well known tbird flaw ;)

Please use always attachments with thunderbird.
It is no fun to fix all lines for indentation.

Sorry about that - I meant to attach it too.

What is the proper way to supply:

Signed-off-by Carl Karsten <[email protected]>

Quoted 1 line

Carl K

Hi,

no, at least I did not receive it as attachment.

Last known status, years back here, is that tbird attachments are always OK and unbroken.

Am Mittwoch, den 28.05.2008, 18:31 -0500 schrieb Carl Karsten:

Quoted 53 lines

Quoted 39 lines · hermann pitton

Hi Carl,

Am Mittwoch, den 28.05.2008, 17:03 -0500 schrieb Carl Karsten:

Quoted 28 lines

Quoted 27 lines · Mauro Carvalho Chehab

Quoted 1 line · On Wed, 28 May 2008 15:15:35 -0500 Carl Karsten <[email protected]> wrote:

I posted a week ago and haven't heard anything.

I was on vacations last week.

Quoted 2 lines

How long should I wait before
posting this? :)

There are a few issues on your patch:

Quoted 3 lines

(quoted diff) +1 -1

-		else
+            printk(KERN_INFO "%s: /dev/video%d unregistered.\n", MODULE_NAME,

dev->vfd->minor);

Your patch got word wrapped. So, it didn't apply.

Review

Quoted 2 lines

(quoted diff) +2 -0

+        }
+		else {

CodingStyle is wrong. It should be:

	} else {

(at the same line)

Also, on some places, you used space, instead of tabs.

Please, check your patch with checkpatch.pl (or, inside Mercurial, make checkpatch) before sending it.

Quoted 8 lines

Quoted 7 lines

Also, be sure that your emailer won't add line breaks at the wrong places.

Quoted 6 lines

} else
printk(KERN_INFO "Video Technology Magazine Virtual Video "

(quoted diff) +2 -1

-				 "Capture Board successfully loaded.\n");
+                 "Capture Board ver %u.%u.%u successfully loaded.\n",
+        (VIVI_VERSION >> 16) & 0xFF, (VIVI_VERSION >> 8) & 0xFF, VIVI_VERSION &

0xFF);

Fixed what you mentioned, make checkpatch doesn't report anything now. It was reporting "warning: line over 80 characters" so now that those are fixed maybe t-bird won't wrap them.

Quoted 6 lines

your hope is in vain for the one space indent in front of every line tbird adds. We have that issue already seen with your previous patches and I told you about, it is a very well known tbird flaw ;)

Please use always attachments with thunderbird.
It is no fun to fix all lines for indentation.

Sorry about that - I meant to attach it too.

What is the proper way to supply:

Signed-off-by Carl Karsten <[email protected]>

Carl K

Quoted 53 lines · hermann pitton

Am Mittwoch, den 28.05.2008, 18:31 -0500 schrieb Carl Karsten:

Quoted 52 lines

Quoted 41 lines · hermann pitton

Hi Carl,

Am Mittwoch, den 28.05.2008, 17:03 -0500 schrieb Carl Karsten:

Quoted 29 lines

Quoted 28 lines · Mauro Carvalho Chehab

Quoted 1 line · On Wed, 28 May 2008 15:15:35 -0500 Carl Karsten <[email protected]> wrote:

I posted a week ago and haven't heard anything.

I was on vacations last week.

Quoted 2 lines

How long should I wait before
posting this? :)

There are a few issues on your patch:

Quoted 3 lines

(quoted diff) +1 -1

-		else
+            printk(KERN_INFO "%s: /dev/video%d unregistered.\n", MODULE_NAME,

dev->vfd->minor);

Your patch got word wrapped. So, it didn't apply.

Review

Quoted 2 lines

(quoted diff) +2 -0

+        }
+		else {

CodingStyle is wrong. It should be:

	} else {

(at the same line)

Also, on some places, you used space, instead of tabs.

Please, check your patch with checkpatch.pl (or, inside Mercurial, make checkpatch) before sending it.

Also, be sure that your emailer won't add line breaks at the wrong places.

Quoted 9 lines

Quoted 6 lines

Quoted 6 lines

} else
printk(KERN_INFO "Video Technology Magazine Virtual Video "

linux/drivers/media/video/vivi.c +2 -1

-				 "Capture Board successfully loaded.\n");
+                 "Capture Board ver %u.%u.%u successfully loaded.\n",
+        (VIVI_VERSION >> 16) & 0xFF, (VIVI_VERSION >> 8) & 0xFF, VIVI_VERSION &

0xFF);

Fixed what you mentioned, make checkpatch doesn't report anything now. It was reporting "warning: line over 80 characters" so now that those are fixed maybe t-bird won't wrap them.

Quoted 6 lines

your hope is in vain for the one space indent in front of every line tbird adds. We have that issue already seen with your previous patches and I told you about, it is a very well known tbird flaw ;)

Please use always attachments with thunderbird.
It is no fun to fix all lines for indentation.

Sorry about that - I meant to attach it too.

What is the proper way to supply:

Quoted 3 lines

Quoted 3 lines

Signed-off-by Carl Karsten <[email protected]>

Carl K

list ate .diff, trying .patch.

Carl K

Am Mittwoch, den 28.05.2008, 18:31 -0500 schrieb Carl Karsten:

Quoted 52 lines

Quoted 39 lines · hermann pitton

Hi Carl,

Am Mittwoch, den 28.05.2008, 17:03 -0500 schrieb Carl Karsten:

Quoted 28 lines

Quoted 27 lines · Mauro Carvalho Chehab

Quoted 1 line · On Wed, 28 May 2008 15:15:35 -0500 Carl Karsten <[email protected]> wrote:

I posted a week ago and haven't heard anything.

I was on vacations last week.

Quoted 2 lines

How long should I wait before
posting this? :)

There are a few issues on your patch:

Quoted 3 lines

(quoted diff) +1 -1

-		else
+            printk(KERN_INFO "%s: /dev/video%d unregistered.\n", MODULE_NAME,

dev->vfd->minor);

Your patch got word wrapped. So, it didn't apply.

Review

Quoted 2 lines

(quoted diff) +2 -0

+        }
+		else {

CodingStyle is wrong. It should be:

	} else {

(at the same line)

Also, on some places, you used space, instead of tabs.

Please, check your patch with checkpatch.pl (or, inside Mercurial, make checkpatch) before sending it.

Quoted 8 lines

Quoted 7 lines

Also, be sure that your emailer won't add line breaks at the wrong places.

Quoted 6 lines

} else
printk(KERN_INFO "Video Technology Magazine Virtual Video "

(quoted diff) +2 -1

-				 "Capture Board successfully loaded.\n");
+                 "Capture Board ver %u.%u.%u successfully loaded.\n",
+        (VIVI_VERSION >> 16) & 0xFF, (VIVI_VERSION >> 8) & 0xFF, VIVI_VERSION &

0xFF);

Fixed what you mentioned, make checkpatch doesn't report anything now. It was reporting "warning: line over 80 characters" so now that those are fixed maybe t-bird won't wrap them.

Quoted 6 lines

your hope is in vain for the one space indent in front of every line tbird adds. We have that issue already seen with your previous patches and I told you about, it is a very well known tbird flaw ;)

Please use always attachments with thunderbird.
It is no fun to fix all lines for indentation.

Sorry about that - I meant to attach it too.

What is the proper way to supply:

Signed-off-by Carl Karsten <[email protected]>

Quoted 1 line

Carl K

Hi,

no, at least I did not receive it as attachment.

Last known status, years back here, is that tbird attachments are always OK and unbroken.