Skip to contentSkip to conversation

use smp_cpus as lapic id

PATCH Applied Glauber Costa 2 participants 2 messages Mar 3, 2008 – Mar 4, 2008 KVM

lore
Share & tools
lore

Glauber Costa

author
#0 lore raw

apic is not acpi, although they are acronyms. Due to a confusion of mine, those things were mixed, leading to a bug reported at
https://sourceforge.net/tracker/index.php?func=detail&aid=1903732&group_id=180599&atid=893831

This patch fixes it, by assigning smp_cpus instead of MAX_CPUS to lapic_id in the MP APIC tables.

Signed-off-by Glauber Costa <[email protected]>
bios/rombios32.c +2 -2
index 77e71ac..af18390 100755
@@ -983,7 +983,7 @@ #endif
     putstr(&q, "ISA   ");
 
     /* ioapic */
-    ioapic_id = MAX_CPUS;
+    ioapic_id = smp_cpus;
     putb(&q, 2); /* entry type = I/O APIC */
     putb(&q, ioapic_id); /* apic ID */
     putb(&q, 0x11); /* I/O APIC version number */

@@ -1427,7 +1427,7 @@ #endif
         io_apic = (void *)apic;
         io_apic->type = APIC_IO;
         io_apic->length = sizeof(*io_apic);
-        io_apic->io_apic_id = MAX_CPUS;
+        io_apic->io_apic_id = smp_cpus;
         io_apic->address = cpu_to_le32(0xfec00000);
         io_apic->interrupt = cpu_to_le32(0);
qemu/pc-bios/bios.bin binary +0 -0
index 64b7abb..3a75ff5 100644
Binary files a/qemu/pc-bios/bios.bin and b/qemu/pc-bios/bios.bin differ

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

_______________________________________________
kvm-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Applied
#1 lore raw
Quoted 8 lines · Glauber Costa

apic is not acpi, although they are acronyms. Due to a confusion of mine, those things were mixed, leading to a bug reported at
https://sourceforge.net/tracker/index.php?func=detail&aid=1903732&group_id=180599&atid=893831

This patch fixes it, by assigning smp_cpus instead of MAX_CPUS to lapic_id in the MP APIC tables.

Applied, thanks.

Signature · 7 lines
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/