Skip to contentSkip to conversation

Unknown option: no-signed-off-by-cc (git-send-email)

DISCUSSION Timur Tabi 3 participants 4 messages Jun 15, 2016

lore
Share & tools
lore

Timur Tabi

author
#0 lore raw

I just upgraded to 1.5.4, and when I tried to use git-send-email with my usual parameters, I got this:

Unknown option: no-signed-off-by-cc
git-send-email [options] <file | directory>...

The documentation for git-send-email still lists this option.

Signature · 2 lines
Timur Tabi
Linux kernel developer at Freescale
#1 lore raw
Quoted 8 lines · Timur Tabi

I just upgraded to 1.5.4, and when I tried to use git-send-email with my usual parameters, I got this:

Unknown option: no-signed-off-by-cc
git-send-email [options] <file | directory>...

The documentation for git-send-email still lists this option.

Except that the "no" and "signed" are not separated by "-".

jdl

author
#2 lore raw
Quoted 3 lines · Jon Loeliger

Except that the "no" and "signed" are not separated by "-".

From the man page:

--no-signed-off-by-cc
Do not add emails found in Signed-off-by: lines to the cc list.

However, when I removed the "-", it worked. So thanks for that.

It *used* to work with the "-", so I consider it a bug.

Signature · 2 lines
Timur Tabi
Linux kernel developer at Freescale
#3 lore raw
Quoted 4 lines · Timur Tabi
Quoted 1 line · Jon Loeliger

Except that the "no" and "signed" are not separated by "-".

Quoted 9 lines

From the man page:

--no-signed-off-by-cc
Do not add emails found in Signed-off-by: lines to the cc list.

However, when I removed the "-", it worked. So thanks for that.

It *used* to work with the "-", so I consider it a bug.

git-send-email.txt does still mention --no-signed-off-by-cc, and additionally --no-chain-reply-to, --no-suppress-from, and --no-thread.

Shouldn't either work? This is from the Getopt::Long man page:

! The option does not take an argument and may be negated, i.e. pre-
fixed by "no". E.g. "foo!" will allow "--foo" (a value of 1 will be assigned) and "--nofoo" and "--no-foo" (a value of 0 will be assigned). If the option has aliases, this applies to the aliases as well.

Looks like --no-signed-off-by-cc or --nosigned-off-by-cc should work, no?

-brandon