MMC: OMAP: Include missing from previous merging
Subsystems (2)
PATCH 1/18 MMC: OMAP: Include missing from previous merging
From: Carlos Eduardo Aguiar <[email protected]>
This patch adds an include missing from previous merging mainline tree into linux-omap tree.
--- drivers/mmc/host/omap.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/mmc/host/omap.c +1 -0
@@ -21,6 +21,7 @@#include <linux/delay.h> #include <linux/spinlock.h> #include <linux/timer.h> +#include <linux/mmc/mmc.h> #include <linux/mmc/host.h> #include <linux/mmc/card.h> #include <linux/clk.h>
-- 1.5.3.GIT
Quoted 8 lines · On Mon, 28 Jan 2008 15:07:06 -0400 Carlos Aguiar <[email protected]>…
From: Carlos Eduardo Aguiar <[email protected]>
This patch adds an include missing from previous merging mainline tree into linux-omap tree.
Signed-off-by Carlos Eduardo Aguiar <[email protected]>Signed-off-by Tony Lindgren <[email protected]>---
NAK. This header should not be needed in host drivers. It's a clear sign you're doing something bad.
Rgds
Signature · 5 lines
-- Pierre Ossman Linux kernel, MMC maintainer http://www.kernel.org PulseAudio, core developer http://pulseaudio.org rdesktop, core developer http://www.rdesktop.org
Quoted 9 lines · ext Pierre Ossman
Quoted 5 lines · On Mon, 28 Jan 2008 15:07:06 -0400 Carlos Aguiar <[email protected]>…
From: Carlos Eduardo Aguiar <[email protected]>
This patch adds an include missing from previous merging mainline tree into linux-omap tree.
Quoted 9 lines
Quoted 4 lines
Signed-off-by Carlos Eduardo Aguiar <[email protected]>Signed-off-by Tony Lindgren <[email protected]>---
NAK. This header should not be needed in host drivers. It's a clear sign you're doing something bad.
Rgds
Hi Pierre and folks,
First of all, sorry the delay of this response, I was on vacation for some weeks.
So, regarding the comments (thanks for all o them) in fact this missing include is really not needed. So, this patch will be disconsidered when I resent the series with corrections and comments suggested here.
BR,
Carlos.
Signature · 7 lines
Carlos Eduardo Aguiar Nokia Institute of Technology - INdT Open Source Mobile Research Center - OSMRC - Manaus Core Team Phone: +55 92 2126-1079 Mobile: +55 92 8127-1797 E-mail: [email protected]