Skip to contentSkip to conversation

SWNCQ should be enabled by default

DISCUSSION Zoltan Boszormenyi 2 participants 4 messages Mar 6, 2008 – Mar 9, 2008 libata

lore
Share & tools
lore
#0 lore raw

Hi,

the patch is already upstream, thanks for that. I am using it without any problems. Currently I am using kernel-2.6.24.3-12.fc8 from the updates-testing repository of Fedora 8. I had to add

options scsi_hostadapter1 swncq=1
options sata_nv swncq=1

before upgrading to get it enabled.
Can we enable it by default for 2.6.25?
It's completely independent from ADMA and its problems. E.g. my machine has 8GB memory now, no problems at all.

Best regards,
Zoltán Böszörményi

#1 lore raw

Ping. Now with patch.

Zoltan Boszormenyi írta:

Quoted 10 lines

Hi,

the patch is already upstream, thanks for that. I am using it without any problems. Currently I am using kernel-2.6.24.3-12.fc8 from the updates-testing repository of Fedora 8. I had to add

options scsi_hostadapter1 swncq=1
options sata_nv swncq=1

Quoted 7 lines

before upgrading to get it enabled.
Can we enable it by default for 2.6.25?
It's completely independent from ADMA and its problems. E.g. my machine has 8GB memory now, no problems at all.

Best regards,
Zoltán Böszörményi

Enable SWNCQ by default.

drivers/ata/sata_nv.c renamed from drivers/ata/sata_nv.c~ +2 -2
@@ -641,7 +641,7 @@
 MODULE_VERSION(DRV_VERSION);
 
 static int adma_enabled = 1;
-static int swncq_enabled;
+static int swncq_enabled = 1;
 
 static void nv_adma_register_mode(struct ata_port *ap)
 {
@@ -2600,5 +2600,5 @@
 module_param_named(adma, adma_enabled, bool, 0444);
 MODULE_PARM_DESC(adma, "Enable use of ADMA (Default: true)");
 module_param_named(swncq, swncq_enabled, bool, 0444);
-MODULE_PARM_DESC(swncq, "Enable use of SWNCQ (Default: false)");
+MODULE_PARM_DESC(swncq, "Enable use of SWNCQ (Default: true)");
 
#2 lore raw
Quoted 21 lines · Zoltan Boszormenyi

Ping. Now with patch.

Zoltan Boszormenyi írta:

Quoted 17 lines

Hi,

the patch is already upstream, thanks for that. I am using it without any problems. Currently I am using kernel-2.6.24.3-12.fc8 from the updates-testing repository of Fedora 8. I had to add

options scsi_hostadapter1 swncq=1
options sata_nv swncq=1

before upgrading to get it enabled.
Can we enable it by default for 2.6.25?
It's completely independent from ADMA and its problems. E.g. my machine has 8GB memory now, no problems at all.

Best regards,
Zoltán Böszörményi

I'll ACK this, at least for -mm..

#3 lore raw

Robert Hancock írta:

Quoted 19 lines
Quoted 18 lines · Zoltan Boszormenyi

Ping. Now with patch.

Zoltan Boszormenyi írta:

Quoted 15 lines

Hi,

the patch is already upstream, thanks for that. I am using it without any problems. Currently I am using kernel-2.6.24.3-12.fc8 from the updates-testing repository of Fedora 8. I had to add

options scsi_hostadapter1 swncq=1
options sata_nv swncq=1

before upgrading to get it enabled.
Can we enable it by default for 2.6.25?
It's completely independent from ADMA and its problems. E.g. my machine has 8GB memory now, no problems at all.

Quoted 5 lines
Quoted 3 lines
Quoted 2 lines

Best regards,
Zoltán Böszörményi

I'll ACK this, at least for -mm..

Thanks. On the other hand, the meat of the SWNCQ patch had its exposure in -mm, there were no problem reports...